src/bin/expr/expr.y, branch releng/12.3

expr(1): Fix overflow detection when operand is INTMAX_MIN

2018-04-14T04:35:10Z

PR: 227329 Submitted by: Tobias Stoeckmann

Fix overflow check for multiplication:

2015-01-27T18:04:41Z

- Add special test to detect the case of -1 * INTMAX_MIN - Protect against elimination of the test division by the optimizer Garrett Cooper noticed that the overflow checks were incomplete, and Bruce Evans suggested the use of the "volatile" qualifier to counter the effect of the undefined behaviour, when the prior multiplication caused overflow, and he also suggested improvements to the comments. Reviewed by: bde MFC after: 1 week

Remove redundant declaration of yyparse

2012-05-22T03:01:54Z

Reported by: tinderbox

rm[0].rm_so must be zero (an explicit check is made for zero in the

2012-03-19T00:45:01Z

outer if condition) Reviewed by: se Approved by: cperciva

Fix style, since this file has just been touched in a major way.

2011-07-09T12:20:15Z

No actual code changes.

Some refactoring for easier maintenance of the code. This is a follow-up

2011-07-09T12:14:57Z

to re-establishment of 64bit arithmetic, but is committed separately, to not obscure that conversion. This commit does not change the observed behaviour of expr in any way. Style will be fixed in a follow-up commit.

Make /bin/expr support 64bit numeric range and range checks by default,

2011-07-09T12:05:53Z

again. This brings back the behaviour of expr in FreeBSD-4, which had been reverted due to an assumed incompatbility with POSIX.1 for FreeBSD-5. This issue has been discussed in the freebsd-standards list, and the consensus was, that POSIX.1 is in fact not violated by this extension, since it affects only cases of POSIX undefined behaviour (overflow of signed long). Other operating systems did upgrade their versions of expr to support 64bit range, after it had been initially brought to FreeBSD. They have used it for a decade without problems, meanwhile. The -e option is retained, but it will only select less strict checking of numeric parameters (leading white-space, leading "+" are allowed and skipped, an empty string is considered to represent 0 in numeric context.) The call of check_utility_compat() as a means of establishing backwards compatibility with FreeBSD-4 is considered obsolete, but preserved in this commit. It is expected to be removed in a later revision of this file. Reviewed by: bde, das, jilles MFC after: 2 month (those parts that do not violate POLA)

Correct typos containing my login name (plus one more in expr.y).

2007-02-18T19:48:59Z

Found courtesy of a recursive grep in the wrong directory.

/*- or .\"- or #- to begin license clauses.

2005-01-10T08:39:26Z

Create a small library function, check_utility_compat(3), to determine

2002-10-28T00:15:43Z

whether a named utility should behave in FreeBSD 4.x-compatible mode or in a standard mode (default standard). The configuration is done malloc(3)-style, with either an environment variable or a symlink. Update expr(1) to use this new interface.