src/bin/rm, branch releng/10.2 FreeBSD source tree https://cgit-dev.freebsd.org/src/atom?h=releng%2F10.2 2014-10-01T16:18:40Z MFC r268376 (imp): 2014-10-01T16:18:40Z Glen Barber gjb@FreeBSD.org 2014-10-01T16:18:40Z urn:sha1:9a87d320f3a7b618f66488aee3db8408bb5265aa rm -rf can fail sometimes with an error from fts_read. Make it honor fflag to ignore fts_read errors, but stop deleting from that directory because no further progress can be made. When building a kernel with a high -j value on a high core count machine, during the cleanobj phase we can wind up doing multiple rm -rf at the same time for modules that have subdirectories. This exposed this race (sometimes) as fts_read can return an error if the directory is removed by another rm -rf. Since the intent of the -f flag was to ignore errors, even if this was a bug in fts_read, we should ignore the error like we've been instructed to do. Approved by: re (kib) Sponsored by: The FreeBSD Foundation Add two more 'static' qualifiers 2013-04-26T17:56:35Z Eitan Adler eadler@FreeBSD.org 2013-04-26T17:56:35Z urn:sha1:4c99904b9a7653435895f4e090cbd153b366152d Take some improvements from DragonFlyBSD: 2013-04-26T17:45:40Z Eitan Adler eadler@FreeBSD.org 2013-04-26T17:45:40Z urn:sha1:9d6d3f96d03feee62481767f309774b669fd185d - add const where appropriate - add static where appropriate - fix a whitespace issues Reviewed by: brooks Obtained from: DragonFlyBSD MFC After: 1 week Add -x option to avoid crossing mount points when removing a hierarchy. 2013-04-26T17:45:37Z Eitan Adler eadler@FreeBSD.org 2013-04-26T17:45:37Z urn:sha1:d4319e7433ce9d59d874020e85606f06deda9d30 Discussed on: -hackers Inspired by: DragonflyBSD MFC After: 1 week Add a few examples. 2013-03-15T20:12:54Z Joel Dahl joel@FreeBSD.org 2013-03-15T20:12:54Z urn:sha1:e9e3a1ab1fb5cad58704a28dc528be8c075d32d8 Obtained from: OpenBSD Fix bin/ build with a 64-bit ino_t. 2012-09-27T23:31:12Z Matthew D Fleming mdf@FreeBSD.org 2012-09-27T23:31:12Z urn:sha1:6db1a7f11e0f890229ef43a9e554b89756afa8c5 Original code by: Gleb Kurtsou Polish previous revision: if the fts_* routines have lstat()'ed the 2012-06-20T21:10:38Z Xin LI delphij@FreeBSD.org 2012-06-20T21:10:38Z urn:sha1:930e3238946d6fd3fa318e048289b6d6225784ef directory entry then use the struct stat from that instead of doing it again, and skip the rm_overwrite() call if fts_read() indicated that the entry couldn't be a regular file. Obtained from: OpenBSD MFC after: 1 week Fix potential symlink race condition in "rm -P" by adding a check 2012-06-20T02:21:53Z Kevin Lo kevlo@FreeBSD.org 2012-06-20T02:21:53Z urn:sha1:4ec1405b3943fed9dff52930055b037cc7a40069 that the file we have opened is the one we expected. Also open in non-blocking mode to avoid a potential hang with FIFOs. Obtained from: NetBSD via OpenBSD Put some static keywords in the source code. 2011-10-31T08:59:17Z Ed Schouten ed@FreeBSD.org 2011-10-31T08:59:17Z urn:sha1:f9d4afb439cc2c97183694169663cf6ae10c628e For these simple utilities, it doesn't harm to make all global variables static. In fact, this allows the compiler to perform better forms of optimisation and analysis. bin: Prefer strrchr() to rindex(). 2011-03-15T22:22:11Z Jilles Tjoelker jilles@FreeBSD.org 2011-03-15T22:22:11Z urn:sha1:0cf90cd1d37e29407d1fc74e39da6a1625b7cede This removes the last index/rindex usage from /bin.