src/bin/test/test.c, branch stable/14FreeBSD source treehttps://cgit-dev.freebsd.org/src/atom?h=stable%2F142026-01-02T20:44:28Zsh: avoid warnings about too-long initializer strings2026-01-02T20:44:28ZDimitry Andricdim@FreeBSD.org2025-12-25T20:13:48Zurn:sha1:3cd0026966d0174c7143ac1d8233ed81ffa68ddf
Mark `optletter` and `t_op::op_text` as `__non_string`, to avoid
warnings from clang 21 similar to:
bin/sh/options.h:77:36: error: initializer-string for character array is too long, array size is 19 but initializer has size 20 (including the null terminating character); did you mean to use the 'nonstring' attribute? [-Werror,-Wunterminated-string-initialization]
77 | const char optletter[NSHORTOPTS] = "efIimnsxvVECabupTPh";
| ^~~~~~~~~~~~~~~~~~~~~
bin/test/test.c:153:3: error: initializer-string for character array is too long, array size is 2 but initializer has size 3 (including the null terminating character); did you mean to use the 'nonstring' attribute? [-Werror,-Wunterminated-string-initialization]
153 | {"==", STREQ},
| ^~~~
MFC after: 3 days
Reviewed by: jilles
Differential Revision: https://reviews.freebsd.org/D54362
(cherry picked from commit e6546807f4c1a8a6a6fa53fceab7b8c80e3ed802)
Remove $FreeBSD$: one-line .c pattern2023-08-16T17:54:42ZWarner Loshimp@FreeBSD.org2023-08-16T17:54:42Zurn:sha1:1d386b48a555f61cb7325543adbbb5c3f3407a66
Remove /^[\s*]*__FBSDID\("\$FreeBSD\$"\);?\s*\n/
Remove unused includes.2020-12-23T05:04:36ZXin LIdelphij@FreeBSD.org2020-12-23T05:04:36Zurn:sha1:1cc908de3ab2e11fca648fc874df2f9d255fc087Use NULL for pointers instead of 0.2016-04-19T00:38:07ZMarcelo Araujoaraujo@FreeBSD.org2016-04-19T00:38:07Zurn:sha1:172c3b0b5f610e0b342aa70922a355e511a67f3a
MFC after: 2 weeks.
test: Optimize operator lookup.2016-01-30T19:59:58ZJilles Tjoelkerjilles@FreeBSD.org2016-01-30T19:59:58Zurn:sha1:f1602fa51152d9aed042b6b742216e33975bcf33
The linear search using strcmp() shows up in pmcstat for several percent.
Split the operators into lengths and whether they start with '-' and compare
bytes using == instead of strcmp().
A simple test
sh -c 'i=0; w=$(printf %0100d 7); while [ "$i" -lt 1000000 ]; do
v=$(printf %sx%s "$w" "$w"); i=$((i+1)); done'
is over 4% faster on an amd64 bhyve VM.
test: Avoid looking up again the type of a known binary operator.2013-12-05T22:53:32ZJilles Tjoelkerjilles@FreeBSD.org2013-12-05T22:53:32Zurn:sha1:c80ad859e1a0f062dad42dd71efd40f1b6ef9184test: Simplify the code by unifying op_num and op_type.2013-12-01T17:00:57ZJilles Tjoelkerjilles@FreeBSD.org2013-12-01T17:00:57Zurn:sha1:577ad9b2d303a89c3944a6c8a705d51dd4011dd6
The global variable t_wp_op is no longer needed.
test: Remove -ntXY and -otXY primaries.2013-05-31T22:54:20ZJilles Tjoelkerjilles@FreeBSD.org2013-05-31T22:54:20Zurn:sha1:f19825af72b3ab9e4a6faa1a6f09002aae9f48bd
This reverts commit r247274.
As maintainer of sh, I disapprove of this feature addition.
It is too specific and can be done without easily using find(1) or stat(1).
I will add some hints to the test(1) man page shortly.
In general, FreeBSD sh is not the place to invent new shell language
features. This is how it has been maintained and adding features randomly
does not work with that.
The new syntax (e.g. [ FILE1 -ntca FILE2 ]) looks cryptic to me.
Enhance test(1) by adding provision to compare any combination of the2013-02-25T19:05:40ZPeter Jeremypeterj@FreeBSD.org2013-02-25T19:05:40Zurn:sha1:293beebc463697485b14136f4b2a5b1d154a3da9
access, birth, change and modify times of two files, instead of only
being able to compare modify times. The builtin test in sh(1) will
automagically acquire the same expansion.
Approved by: grog
MFC after: 2 weeks
test: Reduce code size of ops table.2011-11-25T23:45:29ZJilles Tjoelkerjilles@FreeBSD.org2011-11-25T23:45:29Zurn:sha1:ba22f6c6936b5b11eea306ec1f0ca51c120cd44c