src/cddl, branch releng/14.3

libdtrace: Fix an off-by-one in CPU ID handling

2025-04-02T15:14:37Z

The illumos-specific _SC_CPUID_MAX is the largest CPU ID in the system. This was mapped to _SC_NPROCESSORS_CONF, which is the total number of CPUs recognized by the kernel. If CPU IDs are contiguous, as is the case on amd64 and arm64, this value is one greater than the maximum ID. As a result, when consuming per-CPU dtrace buffers, libdtrace tries to fetch from a non-existent CPU. This is mostly harmless in practice, but still wrong. As we don't have a sysconf value for the maximum CPU ID, add a wrapper which fetches it using the kern.smp.maxid sysctl. MFC after: 2 weeks Sponsored by: Innovate UK Differential Revision: https://reviews.freebsd.org/D49243 (cherry picked from commit 9a30c8d347bf9aaa89277b6e5a275f737be8edce)

libdtrace: Fix an off-by-one in the priority queue implementation

2025-04-02T15:14:36Z

The zero'th index in the array is unused, so a priority queue of N elements needs N+1 array slots. Fix the allocation. Also fix the assertion in dt_pq_insert(): the assertion needs to be checked after incrementing the count of items in the priority queue, otherwise it can miss an overflow. Reported by: CHERI MFC after: 2 weeks Sponsored by: Innovate UK Differential Revision: https://reviews.freebsd.org/D49242 (cherry picked from commit 7ee1bdd094d376fdc547e8ca33e472f1d37a7d79)

libdtrace: Use designators to initialize the opcode array

2025-02-14T19:25:18Z

No functional change intended. MFC after: 2 weeks Sponsored by: Innovate UK (cherry picked from commit 51688136b161089b317edc34c3a3e9b40d54a18a)

libdtrace: Generalize handling of data models a bit

2025-02-14T19:25:18Z

Make it easier to support data models other than ILP32 and LP64 by avoiding constructs which assume that it must be one or the other. No functional change intended. MFC after: 2 weeks Sponsored by: Innovate UK (cherry picked from commit 096a5c6cd28c417456d5ce3598be15e6b656af5c)

dtrace tests: Fix the ATF config variable name

2025-01-30T15:23:05Z

Fixes: 6e6a67e98652 ("dtrace tests: Avoid hard-coding paths to required programs") Sponsored by: Innovate UK (cherry picked from commit fed08c59b7bf2cb4d05bacadadde2dcef4dc6c46)

dtrace tests: Avoid hard-coding paths to required programs

2025-01-30T15:23:05Z

MFC after: 1 week Sponsored by: Innovate UK (cherry picked from commit 6e6a67e98652e1477973d031b27ce085d7f200c2)

libdtrace: Use C99 designated initializers for dt_idops_t

2025-01-30T15:23:04Z

No functional change intended. MFC after: 1 week Sponsored by: Innovate UK (cherry picked from commit 61c4ac2df7b2b866c8ee5e944aedc96aa79bd315)

libdtrace: Be less strict when comparing pointer types

2025-01-15T17:10:57Z

If one of two pointers refers to a forward declaration, let the pointers be compatible so long as the referred types have the same name. Otherwise we can get spurious errors. To give a specific example, this can happen when ipfw_nat.ko is loaded before ipfw.ko and /usr/lib/dtrace/ipfw.d is processed. Currently, ipfw_nat.ko does not have a definition for struct inpcb (i.e., none of its files include in_pcb.h), so in the CTF type graph, struct ip_fw_args' "inp" member refers to a forward declaration, represented in CTF with CTF_K_FORWARD. Then, when libdtrace processes the ipfw_match_info_t translator in ipfw.d, it decides that the "inp" field assignment is incorrect because the two pointers are incompatible. However, there's no harm in allowing this assignment. Add some logic to dt_node_is_ptrcompat() to detect this case and declare the pointers as compatible so long as the name of the thing they refer to is the same, similar to how any pointer is compatible with a void *. Reported by: marck Reviewed by: Domagoj Stolfa MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D48254 (cherry picked from commit 4196f227aa84448ef3cae9e99678fbe787726cf7)

zfs: merge openzfs/zfs@e269af1b3 (zfs-2.2-release) into stable/14

2024-12-12T12:22:56Z

OpenZFS release 2.2.7 Notable upstream pull request merges: #15457 022bf8637 Increase L2ARC write rate and headroom #15527 1ba5b2ef8 freebsd: remove __FBSDID macro use #15792 9e7af55e8 Add custom debug printing for your asserts #15793 a1ea40af8 libzfs: use zfs_strerror() in place of strerror() #16181 -multiple zdb/ztest: improve and harmonise crash output #16208 e5e4957a5 Allow block cloning to be interrupted by a signal #16210 ba4e582a6 FreeBSD: Add const qualifier to members of struct opensolaris_utsname #16225 a6198f34b Simplify issig() #16335 25ec9a903 zdb: fix BRT dump #16364 cf80a803d zvol: ensure device minors are properly cleaned up #16404 384b53be8 FreeBSD: Add missing memory reclamation accounting #16492 -multiple Split "shared" userspace & kernel code into separate files #16496 f1694496a zfs_file: rename zfs_file_fallocate to zfs_file_deallocate #16511 bc0d89bfc Fix an uninitialized data access #16529 2dc8529d9 Fix handling of DNS names with '-' in them for sharenfs #16539 30ea44296 zfs_log: add flex array fields to log record structs #16546 098789216 Evicting too many bytes from MFU metadata #16551 54278533a Reduce and handle EAGAIN errors on AIO label reads #16554 84ad1d536 FreeBSD: restore zfs_znode_update_vfs() #16565 21c40e6d9 FreeBSD: Sync taskq_cancel_id() returns with Linux #16567 48482bb2f Properly release key in spa_keystore_dsl_key_hold_dd() #16584 e8f4592a1 Avoid computing strlen() inside loops #16605 acc8a3186 ARC: Cache arc_c value during arc_evict() #16650 fc60e0c6e freebsd: Use compiler.h from FreeBSD's base's linuxkpi #16667 b32b35cea zdb: show bp in uberblock dump #16684 1f5e1b919 Pack dmu_buf_impl_t by 16 bytes #16688 73b3e8ace Fix gcc uninitialized warning in FreeBSD zio_crypt.c #16690 727506c94 On the first vdev open ignore impossible ashift hints #16692 d83cd5307 zdb: add extra -T flag to show histograms of BRT refcounts #16693 82ab837a0 Fix gcc unused value warning in FreeBSD simd.h #16740 2bba6e3c5 BRT: Don't call brt_pending_remove() on holes/embedded #16801 299da6ace Fix race in libzfs_run_process_impl Obtained from: OpenZFS OpenZFS commit: e269af1b3c7b1b1c000d05f147a2f75e5e72e0ca OpenZFS tag: zfs-2.2.7

manuals: Fix "skipping end of block" .El errors

2024-11-04T16:05:53Z

These were reported by `mandoc -T lint ...` as errors; this commit only handles unnecessary .El commands. The rendered output (in ascii and html) is not affected by this commit. Signed-off-by: Graham Percival Reviewed by: mhorne MFC after: 3 days Sponsored by: Tarsnap Backup Inc. Pull Request: https://github.com/freebsd/freebsd-src/pull/1447 (cherry picked from commit c801836ff43deea3c86935abcad1069bfcd3989c)