src/games/random, branch upstream/10.1.0

Free buf when its no longer used. This helps eliminate a static analysis

2012-10-22T03:06:59Z

warning. PR: ports/172566 Submitted by: Erik Cederstrand Approved by: cperciva MFC after: 3 days

Drop advertising clause in manpages. It was done a long time ago

2010-12-06T19:12:51Z

for the source code. Discussed with: core

random(6): avoid dead assignments

2010-06-14T13:03:25Z

Found by: clang static analyzer

Remove the third clause for the Berkeley parts of games, per the

2010-02-15T18:46:02Z

letter in /COPYRIGHT.

games: make WARNS=6 the default, remove overrides

2010-02-15T14:32:00Z

This also bumps factor, fortune, primes, and random to WARNS=6. Approved by: ed (Co-mentor)

Suggections from bde@

2008-08-11T23:24:42Z

1) Split too long source lines 2) Portable code should not assume that null pointer == all-bits-0, so back out prev. calloc() change. Submitted by: bde

All cosmetic.

2008-08-10T11:31:56Z

1) Rename RANDOM_MAX to RANDOM_MAX_PLUS1 to not confuse with random()'s max 2) Use calloc() instead of zeroing fields explicitly 3) "too many lines" -> "too many delimiters" for err()

1) Fix longstanding math bug with denominator > 1 (wrong probability).

2008-08-08T02:46:47Z

Test case: random -f some_small_file 10000 (in most cases must be no output) 2) Prevent number of lines > RANDOM_MAX (overflow or nothing may be choosed) with EFBIG err() 3) After line is found, terminate list loop for -U case too, since nothing to do in the rest of the loop left.

I was confused a bit by the wrong construction with RAND_MAX

2008-08-08T01:42:17Z

used in randomize_fd.c. Although the max value is the same currently, RAND_MAX is for rand(), not for random(). So move RANDOM_MAX const to the common file now, make it UL and use in randomize_fd.c too. (in any case its old value was 1 less then must be, as noted in the prev. commit)

1) Replace hardcoded RANDOM_MAX macro with wrong (1 less than must be)

2008-08-08T01:02:30Z

value with ((double)RAND_MAX + 1) 2) For exit code increase valid denominator upper range from 255 to 256 since returned value is [0 .. denom - 1]