FreeBSD source tree https://cgit-dev.freebsd.org/src/atom?h=upstream%2F11.2.0 2018-03-29T02:50:57Z 2018-03-29T02:50:57Z Eitan Adler eadler@FreeBSD.org 2018-03-29T02:50:57Z urn:sha1:4ab2e064d7950be84256d671a7ae93f87cc6aa36 This was intended to be a non-functional change. It wasn't. The commit message was thus wrong. In addition it broke arm, and merged crypto related code. Revert with prejudice. This revert skips files touched in r316370 since that commit was since MFCed. This revert also skips files that require $FreeBSD$ property changes. Thank you to those who helped me get out of this mess including but not limited to gonzo, kevans, rgrimes. Requested by: gjb (re) 2018-03-14T03:19:51Z Eitan Adler eadler@FreeBSD.org 2018-03-14T03:19:51Z urn:sha1:be5d0b9566b13fdf8cabebb63334cbec12bfc409 These changes are incomplete but are making it difficult to determine what other changes can/should be merged. No objections from: pfg 2018-02-07T15:06:54Z Hans Petter Selasky hselasky@FreeBSD.org 2018-02-07T15:06:54Z urn:sha1:5bc78bde25fb9145ef211e58862291f7334461ae Use the __alloc_size2 attribute where relevant. This follows the documented use in GCC. It is basically only relevant for calloc(3), reallocarray(3) and mallocarray(9). NOTE: Without this change clang 5.0.1 can produce incorrect optimisation code for static processing of data using the allocated object. For example this has been seen compiling the mlx4 core module, which allocates a fixed size array which is then sorted by a fixed order loop. The optimised result, -O2, is incorrect unless this patch is in place. Suggested by: Mark Millard Reference: https://docs.freebsd.org/cgi/mid.cgi?9DE674C6-EAA3-4E8A-906F-446E74D82FC4 2018-01-12T17:36:19Z Pedro F. Giffuni pfg@FreeBSD.org 2018-01-12T17:36:19Z urn:sha1:9370e08c00c173a30a877c59413a64ae2dc03714 Use the __result_use_check attribute for reallocf(9). MFC r327751: Use the __result_use_check attribute also for reallocf(3). The GCC attribute causes a warning to be emitted if a caller of the function with this attribute does not use its return value. Unlike the traditional realloc, with reallocf(3) we don't have to check for NULL values but we still have to make sure the result is used. 2017-04-23T20:32:46Z Konstantin Belousov kib@FreeBSD.org 2017-04-23T20:32:46Z urn:sha1:57c8b92b8710a9cbcdab4c0ba2130d6621276fa4 Implement the memset_s(3) function as specified by the C11 ISO/IEC 9899:2011 Appendix K 3.7.4.1. MFC r316258: Only activate __EXT1_VISIBLE block when using sys/errno.h in userspace. 2017-03-14T20:14:57Z Pedro F. Giffuni pfg@FreeBSD.org 2017-03-14T20:14:57Z urn:sha1:0685b1047a24502ae7061889c18f282bce657dca Make use of clang nullability attributes in C headers. Replace uses of the GCC __nonnull__ attribute with the clang nullability qualifiers. These are starting to get use in clang's static analyzer. Replacement should be transparent for developers using clang. GCC ports from older FreeBSD versions may need updating if the compiler was built before r312860 (Jan-27-2017). Hinted by: Apple's Libc-1158.20.4, Bionic libc Relnotes: yes 2017-02-19T21:08:10Z Pedro F. Giffuni pfg@FreeBSD.org 2017-02-19T21:08:10Z urn:sha1:b90e6af77351b4f3fa431f494fb4a5e7f7d4e2c4 Remove outdated claim. Despite wishful thinking the removal of these old functions hasn't happened yet. 2017-01-04T02:51:39Z Pedro F. Giffuni pfg@FreeBSD.org 2017-01-04T02:51:39Z urn:sha1:9cd9b37e4d7c46dea5488d7eb7868250877ba813 Remove some uses of the GCC __nonnull() attribute. While the checks are considered useful, the attribute does dangerous optimizations, removing NULL checks where they can be needed. Remove the uses of this attribute introduced in r281130: the changes were inspired on Google's bionic where this attribute is not used anymore. In general, the __nonnull() attribute has fulfilled its roll and will be replaced with the Clang _Nonnull qualifier in the future. 2016-07-05T22:30:29Z Pedro F. Giffuni pfg@FreeBSD.org 2016-07-05T22:30:29Z urn:sha1:9143e6e49afc1bee47713c740c1fe290690739b6 Both __alloc_align and __alloc_size can't be used when the function returns a pointer to memory. This fixes breakage when building with clang 3.4: In file included from /usr/src/svn/usr.sbin/bhyve/atkbdc.c:40: /usr/include/stdlib.h:176:6: error: '__alloc_size__' attribute only applies to functions that return a pointer [-Werror,-Wignored-attributes] Pointed out by: ngie, cem Approved by: re (gjb) 2016-03-23T19:17:12Z Dimitry Andric dim@FreeBSD.org 2016-03-23T19:17:12Z urn:sha1:4ec98362ae5d572c46c2973eec55a9ed942f0ab0 etc) in stdlib.h. These will be needed for newer versions of libc++, which uses them for defining overloaded versions of abs() and div(). MFC after: 1 week