src/lib/libbe/be_error.c, branch releng/12.0 FreeBSD source tree https://cgit-dev.freebsd.org/src/atom?h=releng%2F12.0 2018-09-01T02:22:26Z libbe(3): Fix error handling with respect to be_exists 2018-09-01T02:22:26Z Kyle Evans kevans@FreeBSD.org 2018-09-01T02:22:26Z urn:sha1:162ec569493ba1919857c22a957c97700246da14 Some paths through be_exists will set the error state, others will not There are multiple reasons that a call can fail, so clean it up a bit: all paths now return an appropriate error code so the caller can attempt to distinguish between a BE legitimately not existing and just having the wrong mountpoint. The caller is expected to bubble the error through to the internal error handler as needed. This fixes some unfriendliness with bectl(8)'s activate subcommand, where it might fail due to a bad mountpoint but the only message output is a generic "failed to activate" message. Approved by: re (gjb) libbe(3): More error handling bits 2018-08-10T21:23:56Z Kyle Evans kevans@FreeBSD.org 2018-08-10T21:23:56Z urn:sha1:c65a211146e723379e956cdc63fe1c4a114deac3 be_add_child functionality gets split out into separate places as a bonus. A lot of places here we'll gloss over libzfs errors, because they shouldn't be happening given the conditions that we're operating under. "Unknown error" is what I'm intending to use for the moment to indicate an exceptional circumstance- exceptional enough that we can't tell the consumer did because we're not so certain that they did anything. libbe(3): Clarify some errors 2018-08-08T03:25:10Z Kyle Evans kevans@FreeBSD.org 2018-08-08T03:25:10Z urn:sha1:2989df090ae6fa23ea8c75420a37c9054c0d0500 While here, fix a bug with 'rename' that checked the wrong name for being the active BE. Catch up on BE_ERR messages 2018-08-08T03:11:13Z Kyle Evans kevans@FreeBSD.org 2018-08-08T03:11:13Z urn:sha1:50a1972ed878e14a0bb59c43f452058330865f74 libbe(3)/bectl(8): Standardize $FreeBSD$ IDs 2018-08-07T14:02:41Z Kyle Evans kevans@FreeBSD.org 2018-08-07T14:02:41Z urn:sha1:b6e7c421b75c07ddb0449e1692198dbb3c36547c libbe(3)/bectl(8): Standardize copyright headers 2018-08-07T13:46:06Z Kyle Evans kevans@FreeBSD.org 2018-08-07T13:46:06Z urn:sha1:b179da0111bf5734c60d07c110e8abae9cea300f - File names don't necessarily need to be repeated - Add SPDX tags - Add a missing copyright for Kyle Kneitinger in bectl.8, originally written by him in GSoC 2017; his standard copyright notice has been copied from other files within the same directory to remain consistent with how he clearly wished to portray it libbe(3): Document that we'll clobber previous errors set by set_error 2018-08-07T03:26:32Z Kyle Evans kevans@FreeBSD.org 2018-08-07T03:26:32Z urn:sha1:20b7b8d86cc142b839c661557553965984818e70 libbe(3): make style consistent with what I'll use going forward 2018-07-25T03:50:01Z Kyle Evans kevans@FreeBSD.org 2018-07-25T03:50:01Z urn:sha1:bfe0869c7f7f74f64fb0218f773e0d04be55de47 Import libbe(3)/be(1) from socsvn/soc2017/kneitinger/libbe-head 2018-07-24T13:17:40Z Kyle Evans kevans@FreeBSD.org 2018-07-24T13:17:40Z urn:sha1:28f16a0f1985b32a97075a540236e8abebaeadf1