src/lib/libc/gen/basename.c, branch releng/12.4

Replace basename(3) by a thread-safe implementation.

2016-11-03T20:21:34Z

Now that the changes to the dirname(3) function had some time to settle, let's go ahead and use the same approach for replacing basename(3) by a simple implementation that modifies the input string, thereby making it thread-safe and guaranteed to succeed. Unlike dirname(3), this function already had a thread-safe variant basename_r(3). This function had its own set of problems, like having an upper bound on the pathname length. Keep this function around for compatibility, but remove most references from the man page. Make the man page more similar to that of dirname(3). As the basename_r(3) function is only provided by FreeBSD (and Bionic), depending on its use is even more implementation defined than assuming that basename(3) is thread-safe. Reviewed by: emaste Differential Revision: https://reviews.freebsd.org/D8382

Fix up prototypes of basename(3) and dirname(3) to comply to POSIX.

2016-07-28T16:20:27Z

POSIX allows these functions to be implemented in a way that the resulting string is stored in the input buffer. Though some may find this annoying, this has the advantage that it makes it possible to implement this function in a thread-safe way. It also means that they can be implemented in a way that they work for paths of arbitrary length, as the output string of these functions is never longer than max(1, len(input)). Portable code already needs to be written with this in mind, so in my opinion it makes very little sense to allow the existing behaviour. Prevent the base system from falling back to this by switching over to POSIX prototypes. I'm not going to bump the __FreeBSD_version for this. The reason is that it's possible to account for this change in a portable way, without depending on a specific version of FreeBSD. An exp-run was done some time ago. As far as I know, all regressions as a result of this have already been fixed. I'll give this change some time to settle. In the long run I want to replace our copies by ones that are thread-safe and don't depend on PATH_MAX/MAXPATHLEN.

Sync with OpenBSD, primarily make the code easier to read, and a license

2011-06-18T00:33:34Z

change to standard OpenBSD ISC license. Obtained from: OpenBSD MFC after: 2 weeks

Add basename_r(3) to complement basename(3). basename_r(3) which accepts

2009-10-06T14:05:57Z

a caller-allocated buffer of at least MAXPATHLEN, rather than using a global buffer. MFC after: 1 month Sponsored by: Google

Fix LP64 architectures and especially ia64. Functions that return

2002-12-30T01:41:14Z

a pointer and lack a prototype will have the return value (assumed to be an integer) zero-extended to a pointer. On ia64 this is unconditionally fatal as it zeroes-out the region bits, forming an invalid pointer. Fix the sigsegv by including . Pointy hat: bbraun

Reduce libc.so's memory footprint by lazily allocating memory used internally

2002-12-21T07:12:35Z

by basename() and dirname(). Reviewed by: eric

* Remove 'register'. (some functions had 7+ register functions...)

2002-02-01T01:08:48Z

* Fix SCM ID's.

Fixed world breakage due to missing include of in previous

2002-01-31T12:58:36Z

commit. Fixed related style bugs: basename.c: misplaced '#if 0' dirname.c: misplaced '#if 0' getgrent.c: missing '#if 0', and tab lossage in vendor id (the previous commit fixed the complete corruption of the vendor id but lost a tab) getpwent.c: missing '#if 0'

Fix FreeBSD IDs.

2002-01-30T21:36:57Z

Fix a one-byte overrun.

2001-06-28T21:50:53Z

PR: 28472 Submitted by: David Xu Obtained from: OpenBSD