src/lib/libc/gen/initgroups.c, branch upstream/11.2.0 FreeBSD source tree https://cgit-dev.freebsd.org/src/atom?h=upstream%2F11.2.0 2018-03-29T02:50:57Z Revert r330897: 2018-03-29T02:50:57Z Eitan Adler eadler@FreeBSD.org 2018-03-29T02:50:57Z urn:sha1:4ab2e064d7950be84256d671a7ae93f87cc6aa36 This was intended to be a non-functional change. It wasn't. The commit message was thus wrong. In addition it broke arm, and merged crypto related code. Revert with prejudice. This revert skips files touched in r316370 since that commit was since MFCed. This revert also skips files that require $FreeBSD$ property changes. Thank you to those who helped me get out of this mess including but not limited to gonzo, kevans, rgrimes. Requested by: gjb (re) Partial merge of the SPDX changes 2018-03-14T03:19:51Z Eitan Adler eadler@FreeBSD.org 2018-03-14T03:19:51Z urn:sha1:be5d0b9566b13fdf8cabebb63334cbec12bfc409 These changes are incomplete but are making it difficult to determine what other changes can/should be merged. No objections from: pfg Use ANSI C prototypes. Eliminates -Wold-style-definition warnings. 2015-09-20T20:23:16Z Craig Rodrigues rodrigc@FreeBSD.org 2015-09-20T20:23:16Z urn:sha1:55b6b759c89e6a44468ff442f11bc2a4a1775699 In preparation for raising NGROUPS and NGROUPS_MAX, change base 2009-06-19T15:58:24Z Brooks Davis brooks@FreeBSD.org 2009-06-19T15:58:24Z urn:sha1:54404cfb13d40e474f72d3c75de1f4db3417df64 system callers of getgroups(), getgrouplist(), and setgroups() to allocate buffers dynamically. Specifically, allocate a buffer of size sysconf(_SC_NGROUPS_MAX)+1 (+2 in a few cases to allow for overflow). This (or similar gymnastics) is required for the code to actually follow the POSIX.1-2008 specification where {NGROUPS_MAX} may differ at runtime and where getgroups may return {NGROUPS_MAX}+1 results on systems like FreeBSD which include the primary group. In id(1), don't pointlessly add the primary group to the list of all groups, it is always the first result from getgroups(). In principle the old code was more portable, but this was only done in one of the two places where getgroups() was called to the overall effect was pointless. Document the actual POSIX requirements in the getgroups(2) and setgroups(2) manpages. We do not yet support a dynamic NGROUPS, but we may in the future. MFC after: 2 weeks Per Regents of the University of Calfornia letter, remove advertising 2007-01-09T00:28:16Z Warner Losh imp@FreeBSD.org 2007-01-09T00:28:16Z urn:sha1:c879ae3536e6d92b8d96c8965c5b05fcb9541520 clause. # If I've done so improperly on a file, please let me know. Fix problem where initgroups would silently truncate groups with 2003-11-19T15:51:26Z Diomidis Spinellis dds@FreeBSD.org 2003-11-19T15:51:26Z urn:sha1:434c74760ffe91c6f4cc3dff0d49a24dddb975c6 more than NGROUP elements without providing the opportunity to setgroups to fail and correctly return error and set errno. MFC after: 2 weeks Fix SCM ID's. 2002-02-01T00:57:29Z David E. O'Brien obrien@FreeBSD.org 2002-02-01T00:57:29Z urn:sha1:ea8d448a923f0d68d7ecf1d2a0583c7d17bdee4e Use the proper type (gid_t) for (group)->gr_gid to be orthogonal 2002-01-22T17:32:53Z Mark Murray markm@FreeBSD.org 2002-01-22T17:32:53Z urn:sha1:5567b258ebfb1a00cb9d07371894eae183e09a25 with uid_t usage and (user)->pw_uid. PR: 3242 Do not write warning messages on stderr - a caller is expected to check 2001-11-28T10:55:02Z Anton Berezin tobez@FreeBSD.org 2001-11-28T10:55:02Z urn:sha1:7d3346ca1f857d6078f948e03b83abae618820da the return code and errno instead. Those warnings did not do any good for daemonized users of initgroups(3), and confused cvs clients that communicated with non-root cvs pserver. The committed fix differs from the one suggested in the PR, and was submitted by ru. PR: 15421 Approved by: markm Discussed on: -stable, -current at various times Fixed namespace pollution related to `warn' in libc (but not in other 2001-08-29T13:52:27Z Bruce Evans bde@FreeBSD.org 2001-08-29T13:52:27Z urn:sha1:1643f03d5ffcd546a5ab371be686995141365d93 libraries or for other members of the err() family). This fixes world breakage in bc and rcs/* for NOSHARED worlds.