FreeBSD source tree https://cgit-dev.freebsd.org/src/atom?h=releng%2F11.3 2018-03-29T02:50:57Z 2018-03-29T02:50:57Z Eitan Adler eadler@FreeBSD.org 2018-03-29T02:50:57Z urn:sha1:4ab2e064d7950be84256d671a7ae93f87cc6aa36 This was intended to be a non-functional change. It wasn't. The commit message was thus wrong. In addition it broke arm, and merged crypto related code. Revert with prejudice. This revert skips files touched in r316370 since that commit was since MFCed. This revert also skips files that require $FreeBSD$ property changes. Thank you to those who helped me get out of this mess including but not limited to gonzo, kevans, rgrimes. Requested by: gjb (re) 2018-03-14T03:19:51Z Eitan Adler eadler@FreeBSD.org 2018-03-14T03:19:51Z urn:sha1:be5d0b9566b13fdf8cabebb63334cbec12bfc409 These changes are incomplete but are making it difficult to determine what other changes can/should be merged. No objections from: pfg 2012-07-04T17:35:07Z Pawel Jakub Dawidek pjd@FreeBSD.org 2012-07-04T17:35:07Z urn:sha1:988a521bf06a348bee36a079ba2522653d17d59a Change argument type from 'const unsigned char *' to 'const char *'. MFC after: 2 weeks 2010-03-11T17:03:32Z John Baldwin jhb@FreeBSD.org 2010-03-11T17:03:32Z urn:sha1:1b0181df2f46ef73a41ea8c9b7026718f8eec3a1 by *sprintf(), etc. - Explicitly initialize _fl_mutex to PTHREAD_MUTEX_INITIALIZER for all FILE objects. This is currently a nop on FreeBSD, but is import for other platforms (or in the future) where PTHREAD_MUTEX_INITIALIZER is not simply zero. PR: threads/141198 Reported by: Jeremy Huddleston @ Apple MFC after: 2 weeks 2008-05-05T16:03:52Z John Baldwin jhb@FreeBSD.org 2008-05-05T16:03:52Z urn:sha1:19e03ca8038019fe0fe7f511b91b758b95b78664 all the previous inline optimizations as well. FILE is back to using __mbstate_t, struct pthread *, and struct pthread_mutex *. 2008-05-02T15:25:07Z John Baldwin jhb@FreeBSD.org 2008-05-02T15:25:07Z urn:sha1:c17bf9a9a5a3b59e03108b785f6b15070ff25651 move the definition of the type backing FILE (struct __sFILE) into an internal header. - Remove macros to inline certain operations from stdio.h. Applications will now always call the functions instead. - Move the various foo_unlocked() functions from unlocked.c into foo.c. This lets some of the inlining macros (e.g. __sfeof()) move into foo.c. - Update a few comments. - struct __sFILE can now go back to using mbstate_t, pthread_t, and pthread_mutex_t instead of knowing about their private, backing types. MFC after: 1 month Reviewed by: kan 2008-04-17T22:17:54Z John Baldwin jhb@FreeBSD.org 2008-04-17T22:17:54Z urn:sha1:1e98f88776fc606df245a382685b1ac634a81389 __sFILE. This was supposed to be done in 6.0. Some notes: - Where possible I restored the various lines to their pre-__sFILEX state. - Retire INITEXTRA() and just initialize the wchar bits (orientation and mbstate) explicitly instead. The various places that used INITEXTRA didn't need the locking fields or _up initialized. (Some places needed _up to exist and not be off the end of a NULL or garbage pointer, but they didn't require it to be initialized to a specific value.) - For now, stdio.h "knows" that pthread_t is a 'struct pthread *' to avoid namespace pollution of including all the pthread types in stdio.h. Once we remove all the inlines and make __sFILE private it can go back to using pthread_t, etc. - This does not remove any of the inlines currently and does not change any of the public ABI of 'FILE'. MFC after: 1 month Reviewed by: peter 2006-10-23T07:25:25Z Konstantin Belousov kib@FreeBSD.org 2006-10-23T07:25:25Z urn:sha1:525cd732f963587dd5660ae46b0f8356e25a09b9 Remove the const qualifier from ap argument for __v2printf, that induced that breakage, and seems to be the real reason for bad code. ap is modified inside the __v2printf body by va_arg macro. Pointy hat to: kib Approved by: pjd (mentor) 2006-10-21T11:49:07Z Konstantin Belousov kib@FreeBSD.org 2006-10-21T11:49:07Z urn:sha1:129ccff2fb9df946928ba4f62605570e86732c4e i386 with default optimization level (-O2), va_list pointer ap in the __v2printf function is advanced before the use. That cause argument shift and garbage instead last argument in printf-family when xprintf is activated. The nsswitch is easy victim of the bug. Reviewed by: kan Approved by: kan (mentor) MFC after: 1 week 2006-04-01T19:06:54Z Poul-Henning Kamp phk@FreeBSD.org 2006-04-01T19:06:54Z urn:sha1:75239a017f0653feb41a3546cd643c356c56a5df