src/lib/libc/stdlib/strfmon.c, branch release/13.1.0

Compute the correct size of the string to move forward.

2020-09-02T20:04:26Z

Previously this was counting the amount of spare room at the start of the buffer that the string needed to move forward and passing that as the number of bytes to copy to memmove rather than the length of the string to be copied. In the strfmon test in the test suite this caused the memmove to overflow the allocated buffer by one byte which CHERI caught. Reported by: CHERI Reviewed by: kevans Obtained from: CheriBSD MFC after: 1 week Sponsored by: DARPA Differential Revision: https://reviews.freebsd.org/D26280

Allow multi-byte thousands separators in strfmon(3)

2018-12-19T22:57:47Z

PR: 234010 Reported by: Jon Tejnung Reviewed by: yuripv Differential Revision: https://reviews.freebsd.org/D18605

libc: further adoption of SPDX licensing ID tags.

2017-11-25T17:12:48Z

Mainly focus on files that use BSD 2-Clause license, however the tool I was using mis-identified many licenses so this was mostly a manual - error prone - task. The Software Package Data Exchange (SPDX) group provides a specification to make it easier for automated tools to detect and summarize well known opensource licenses. We are gradually adopting the specification, noting that the tags are considered only advisory and do not, in any way, superceed or replace the license texts.

libc: spelling fixes.

2016-04-30T01:24:24Z

Mostly on comments.

strfmon: reduce unnecessary snprintf.

2014-07-12T15:19:30Z

No need for the snprintf/asprintf dance; use fixed width formats. Obtained from: NetBSD (CVS rev. 1.8) MFC after: 1 week

Implement xlocale APIs from Darwin, mainly for use by libc++. This adds a

2011-11-20T14:45:42Z

load of _l suffixed versions of various standard library functions that use the global locale, making them take an explicit locale parameter. Also adds support for per-thread locales. This work was funded by the FreeBSD Foundation. Please test any code you have that uses the C standard locale functions! Reviewed by: das (gdtoa changes) Approved by: dim (mentor)

Fix PR

2010-02-10T00:02:09Z

http://www.freebsd.org/cgi/query-pr.cgi?pr=bin/143350 Empty string test gone wrong. Testing this requires that you have a locale that has the sign string unset but has int_n_sign_posn set (the default locale falls through to use "()" around negative numbers which is probably another bug). I created that setup by hand and indeed without this fix negative numbers are put out as positive numbers (doesn't fall through to use "-" as default indicator). Unfixed example in nl_NL.ISO8859-1 with lc->negative_sign set to empty string: strfmon(buf, sizeof(buf), "%-8i", -42.0); ==> example2: 'EUR 42,00' 'Eu 42,00' Fixed: example2: 'EUR 42,00-' 'Eu 42,00-' This file and suggested fix are identical in at least freebsd-8. Backport might be appropriate but some expert on locales should probably have a look at us defaulting to negative numbers in parenthesis when LC_* is default. That doesn't look right and is not what other OSes are doing. PR: 143350 Submitted by: Corinna Vinschen Reviewed by: bug reporter submitted, tested by me

Stricter check for integer overflow.

2008-04-24T07:49:00Z

Don't forget to free() currency_symbol and asciivalue when multiple

2008-04-19T07:22:58Z

conversion specifiers for them are present. Submitted by: Maxim Dounin Obtained from: NetBSD (partially) MFC after: 3 days

Better strfmon(3) conversion specifiers sanity checking.

2008-04-19T07:18:22Z

There were no checks for left and right precisions at all, and a check for field width had integer overflow bug. Reported by: Maksymilian Arciemowicz Security: http://securityreason.com/achievement_securityalert/53 Submitted by: Maxim Dounin MFC after: 3 days