src/lib/libc/tests/string, branch release/14.4.0

libc/tests/string: improve stpncpy() "bounds" unit test

2026-01-04T13:25:21Z

The test is extended the same way I previously extended the memccpy() test to fix what is probably the same kind of bug. PR: 291359 Reported by: Collin Funk Reviewed by: ngie Approved by: markj (mentor) Fixes: 6fa9e7d8737548ef93c573387ce62402c368d486 (D42519) See also: 61ed5748e4e9c7397fcb2638b442f46ac5c9e7c5 (D46051) MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D54169 lib/libc/tests/string/stpncpy_test.c: apply ngie's fixes (cherry picked from commit 123c086200491819595abc271d360e605288fd18) (cherry picked from commit 8be8642826099368208efb2c1222f2a102cc5b08)

lib/libc/tests/string: add memrchr unit tests

2024-01-24T19:39:30Z

The "values" test case is specifically crafted to detect the off-by-one error previous discovered in the scalar strchrnul implementation. Tested by: developers@, exp-run Approved by: mjg MFC after: 1 month MFC to: stable/14 PR: 275785 Differential Revision: https://reviews.freebsd.org/D42925 (cherry picked from commit 691ff1832e09a6ccbc8f5b04c88cafc7452b3ce6)

lib/libc/tests/string: add unit tests for memccpy()

2024-01-24T19:39:29Z

Adapted from the strlcpy() unit tests. Tested by: developers@, exp-run Approved by: mjg MFC after: 1 month MFC to: stable/14 PR: 275785 (cherry picked from commit e4b7b0bcbc741f0998640c2ba55ec00ba613bb75)

lib/libc/tests/string: add unit test for strlcpy

2024-01-24T19:39:28Z

A straightforward derivation from the stpncpy unit test. Sponsored by: The FreeBSD Foundation Tested by: developers@, exp-run Approved by: mjg MFC after: 1 month MFC to: stable/14 PR: 275785 Differential Revision: https://reviews.freebsd.org/D42863 (cherry picked from commit f7098b8659923873a7c60b64cb68182e470786f9)

lib/libc/tests/string/stpncpy_test.c: extend for upcoming SSE implementation

2024-01-24T19:39:27Z

This adds additional unit tests validating the function for All possible alignment offsets of source and destination. Also extend the test to allow testing of an external stpncpy implementation, which greatly simplifies the development of custom implementations. Sponsored by: The FreeBSD Foundation Tested by: developers@, exp-run Approved by: mjg MFC after: 1 month MFC to: stable/14 PR: 275785 Differential Revision: https://reviews.freebsd.org/D42519 (cherry picked from commit 6fa9e7d8737548ef93c573387ce62402c368d486)

lib/libc/tests/string: add unit tests for strncmp(3)

2024-01-24T19:39:25Z

These are patterned after the previously added (D41970) strcmp tests, but are extended to check for various length conditions. Sponsored by: The FreeBSD Foundation Tested by: developers@, exp-run Approved by: mjg MFC after: 1 month MFC to: stable/14 PR: 275785 Differential Revision: https://reviews.freebsd.org/D42122 (cherry picked from commit 459ddefcc9dcc010f6f7445285e61e2b6780379c)

lib/libc/tests/string/strcspn_test.c: add test for correct match order

2023-12-28T17:02:41Z

This new unit test verifies that if there are multiple matches, the first match is returned, ignoring later matches. Approved by: mjg (blanket, via IRC) MFC after: 1 week MFC to: stable/14 (cherry picked from commit a0ecf2224ea35d029d33541878f0eee42f5fd84f)

lib/libc/tests/string: expand memcmp test to bcmp, timingsafe_{b,mem}cmp

2023-12-28T17:02:41Z

The four functions more or less perform the same operation. Reuse the same unit test with slight changes so we can cover them all. Constant-time operation is not verified for the timingsafe_* functions. Sponsored by: The FreeBSD Foundation Approved by: ngie MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D41528 (cherry picked from commit c6cc06d465a98270ef734ffec7c9012ec3a1bd17)

lib/libc/tests/string/memcmp_test.c: extend test to support custom memcmp function

2023-12-28T17:02:41Z

Extend the tests to permit loading an external memcmp function and testing it over using the libc version. This was added by the example of other tests in the test suite doing the same thing and helped tremendously in development. This change was originally part of D41442 but was taken out to permit separate review as extrapolated from @ngie's request in D41349. Sponsored by: FreeBSD Foundation Approved by: ngie Differential Revision: https://reviews.freebsd.org/D41528 (cherry picked from commit b166580681e3af173ec368656019d02ba1cc55ad)

lib/libc/tests/string: add extended unit tests for strcmp()

2023-12-28T17:02:40Z

This changeset add a new set of tests that comprehensively test strcmp() on various alignments of the input. This made it easy to smoke out many exciting new bugs in the new SSE strcmp() implementation from D41971. MFC after: 1 week Reviewed by: ngie Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D41970 (cherry picked from commit b49596de2622a51e5673ba2c0b3718cd88a2aa41)