src/lib/libcrypt, branch releng/14.4FreeBSD source treehttps://cgit-dev.freebsd.org/src/atom?h=releng%2F14.42024-10-29T15:45:31Zlib/libcrypt: use explicit_bzero() to clear sensitive buffers2024-10-29T15:45:31ZRobert Clauseckerfuz@FreeBSD.org2024-10-10T09:08:35Zurn:sha1:1af027e583ec725ae772a4cc0b128652553fa7ec
Prevent a potentially sufficiently smart compiler from optimising
away our attempts to clear sensitive buffers.
A related change was discussed and rejected in D16059, but I don't
believe the reasoning there applies: the code clearly documents its
intent that the `memset` calls clear sensitive buffers so they don't
hang around. `explicit_bzero` is the appropriate function for this
purpose. A potential performance disadvantage seems less important:
the functions in crypt are specifically designed to be slow, so a
few extra calls to guarantee that sensitive buffers are cleared does
not significantly affect runtime.
See also: D16059
Reviewed by: delphij, kevans
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D47037
(cherry picked from commit a2c0d2026fb422ade2171da4bc6d5d2773b268a6)
lib/libcrypt: another trivial style change2024-09-28T03:58:19ZEnji Cooperngie@FreeBSD.org2023-10-28T01:56:41Zurn:sha1:c931eed5bc4346fac88a4a7224f26f280ecd11be
Normalize on hard tabs.
I didn't catch this before pushing the previous commit.
No functional changes intended.
MFC after: 2 weeks
MFC with: 8ef8da882ff475e3da3bde57d97593a68f7d97b2
(cherry picked from commit 61b15e6dfc963a0c67dbaeae7f4590674976111f)
lib/libcrypt: remove trailing whitespace2024-09-28T03:57:45ZEnji Cooperngie@FreeBSD.org2023-10-28T01:10:39Zurn:sha1:c6961c90fd2a320a0e4da1771dc47a1fe8f56b0b
No functional change intended.
MFC after: 2 weeks
(cherry picked from commit 8ef8da882ff475e3da3bde57d97593a68f7d97b2)
Remove $FreeBSD$: two-line nroff pattern2023-08-16T17:55:10ZWarner Loshimp@FreeBSD.org2023-08-16T17:55:10Zurn:sha1:fa9896e082a1046ff4fbc75fcba4d18d1f2efc19
Remove /^\.\\"\n\.\\"\s*\$FreeBSD\$$\n/
Remove $FreeBSD$: one-line sh pattern2023-08-16T17:55:03ZWarner Loshimp@FreeBSD.org2023-08-16T17:55:03Zurn:sha1:d0b2dbfa0ecf2bbc9709efc5e20baf8e4b44bbbf
Remove /^\s*#[#!]?\s*\$FreeBSD\$.*$\n/
Remove $FreeBSD$: one-line .c pattern2023-08-16T17:54:42ZWarner Loshimp@FreeBSD.org2023-08-16T17:54:42Zurn:sha1:1d386b48a555f61cb7325543adbbb5c3f3407a66
Remove /^[\s*]*__FBSDID\("\$FreeBSD\$"\);?\s*\n/
Remove $FreeBSD$: two-line .h pattern2023-08-16T17:54:16ZWarner Loshimp@FreeBSD.org2023-08-16T17:54:16Zurn:sha1:b3e7694832e81d7a904a10f525f8797b753bf0d3
Remove /^\s*\*\n \*\s+\$FreeBSD\$$\n/
spdx: The BSD-2-Clause-FreeBSD identifier is obsolete, drop -FreeBSD2023-05-12T16:44:03ZWarner Loshimp@FreeBSD.org2023-05-10T15:40:58Zurn:sha1:4d846d260e2b9a3d4d0a701462568268cbfe7a5b
The SPDX folks have obsoleted the BSD-2-Clause-FreeBSD identifier. Catch
up to that fact and revert to their recommended match of BSD-2-Clause.
Discussed with: pfg
MFC After: 3 days
Sponsored by: Netflix
libcrypt: Drop inclusion of libutil.h2021-12-07T00:24:19ZJessica Clarkejrtc27@FreeBSD.org2021-12-06T22:28:10Zurn:sha1:7d232d647e3583b495d431b12eaa9343bb29b271
This was rendered obsolete in 2012 by a0ee974f0bad, since auth_getval
was the only reason the header was included.
MFC after: 1 week
Do a sweep and remove most WARNS=6 settings2020-10-01T01:10:51ZKyle Evanskevans@FreeBSD.org2020-10-01T01:10:51Zurn:sha1:7cc42f6d25ef2e19059d088fa7d4853fe9afefb5
Repeating the default WARNS here makes it slightly more difficult to
experiment with default WARNS changes, e.g. if we did something absolutely
bananas and introduced a WARNS=7 and wanted to try lifting the default to
that.
Drop most of them; there is one in the blake2 kernel module, but I suspect
it should be dropped -- the default WARNS in the rest of the build doesn't
currently apply to kernel modules, and I haven't put too much thought into
whether it makes sense to make it so.