src/lib/libfetch/common.c, branch releng/11.3

MFH (r314778): use reallocarray(3) for extra bounds checks

2018-10-09T10:49:19Z

MFH (r333306): fix typo in man page MFH (r333571, r333572): preserve if-modified-since across redirects MFH (r334317): simplify the DEBUG macro MFH (r334319): style bug roundup MFH (r334326): fix netrc file location logic, improve netrcfd handling MFH (r338572): fix end-of-transfer statistics, improve no-tty display PR: 202424, 224426, 228017

Revert r330897:

2018-03-29T02:50:57Z

This was intended to be a non-functional change. It wasn't. The commit message was thus wrong. In addition it broke arm, and merged crypto related code. Revert with prejudice. This revert skips files touched in r316370 since that commit was since MFCed. This revert also skips files that require $FreeBSD$ property changes. Thank you to those who helped me get out of this mess including but not limited to gonzo, kevans, rgrimes. Requested by: gjb (re)

Partial merge of the SPDX changes

2018-03-14T03:19:51Z

These changes are incomplete but are making it difficult to determine what other changes can/should be merged. No objections from: pfg

MFC: r322669

2017-09-17T01:32:38Z

In fetch_resolve() if the port number or service name is included in the host argument (e. g. "www.freebsd.org:443"), correctly set the service pointer accordingly. Previously, the service pointer was set to the separator instead, causing getaddrinfo(3) to fail.

MFH (r313974,r314596): open .netrc early in case we want to drop privs

2017-03-24T14:19:52Z

MFH (r314396,r315143): fix a crash caused by an incorrect format string MFH (r314701): fix handling of 416 errors when requesting a range MFH (r315455): fix parsing of IP literals (square brackets) PR: 212065, 217723

MFH (r308996, r309051, r309738): refactor, avoid repeating DNS requests

2016-12-14T14:20:32Z

Don't leak addrinfo in fetch_bind()

2016-05-25T07:39:48Z

Reported by: Coverity CID: 1225038 MFC after: 1 week

lib: minor spelling fixes in comments.

2016-05-01T19:37:33Z

No functional change.

Test for /etc/ssl/cert.pem existence to avoid masking SSL_CA_CERT_PATH

2016-01-19T15:02:37Z

Prior to this patch, unless SSL_CA_CERT_FILE is set in the environment, libfetch will set the CA file to "/usr/local/etc/cert.pem" if it exists, and to "/etc/ssl/cert.pem" otherwise. This has the consequence of masking SSL_CA_CERT_PATH, because OpenSSL will ignore the CA path if a CA file is set but fails to load (see X509_STORE_load_locations()). While here, fall back to OpenSSL defaults if neither SSL_CA_CERT_FILE nor SSL_CA_CERT_PATH are set in the environment, and if neither of the libfetch default CA files exists. PR: 193871 Submitted by: John W. O'Brien Approved by: des MFC after: 1 week

Fix non-POSIX-compliant use of getaddrinfo in libfetch

2015-09-25T14:24:23Z

Submitted by: Boris Kolpackov Reviewed by: bapt Approved by: bapt MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D3724