src/lib/libfetch/common.c, branch releng/5.0

Fix a bug in fenner's _fetch_writev() patch (rev 1.36)

2002-10-30T14:25:00Z

Submitted by: fenner

Recommit the non-broken parts of 1.34 and 1.37.

2002-10-30T04:43:00Z

Change the type and name of a variable introduced in 1.33.

Reinstate revs 1.35-36 and 1.38. Revisions 1.34 and 1.37 were specifically

2002-10-30T00:17:16Z

the root cause of the bus errors I was experiencing. Submitted by: fenner Tested by: obrien Prompted by: peter

Fix `pkg_add -r' by backing out revs 1.34-1.38.

2002-10-29T12:17:43Z

Revs 1.37-8 produce a bus error in some environments. Revs 1.34-6 do not bus error, but write corrupted files.

Fix an off-by-one error (> where >= should have been used) which caused

2002-10-28T10:19:03Z

_fetch_writev() to incorrectly report EPIPE in certain cases. Also fix a number of const warnings by using __DECONST(), plus a signed / unsigned comparison by casting the rhs to ssize_t. Submitted by: fenner, Craig Rodrigues

Slight amendment to rev 1.34: instead of considering any short read an

2002-10-27T17:20:49Z

error, only report an error if no data was read at all (unless len was 0 to start with). Otherwise, the final read of practically any transfer will end in a fatal error.

Introduce _fetch_writev(), which is the conn_t version of writev(2). In

2002-10-27T16:11:21Z

the SSL case, it is no different from the old _fetch_write(), but in the non-SSL case it uses writev(2) to send the entire vector as a single packet (provided it can fit in one packet). Implement _fetch_write() and _fetch_putln() in terms of _fetch_writev(). This should improve performance in the non-SSL case (by reducing protocol overhead) and solve the problem where too-smart-for-their-own-good firewalls reject FTP packets that do not end in CRLF. PR: bin/44123 Submitted by: fenner

Eliminate two cases of undefined behaviour: total in _fetch_write() was

2002-10-27T15:43:40Z

not initialized before use, and _http_growbuf() did not return a value on success. Reported by: Peter Edwards MFC after: 2 weeks

Back out the previous commit, and fix the bug rather than try to hide its

2002-10-27T15:08:21Z

symptoms: make timeouts and short transfers fatal, and set errno to an appropriate value (ETIMEDOUT for a timeout, EPIPE for a short transfer). MFC after: 2 weeks

Fix an infinite loop when _fetch_read() can return 0 (if the

2002-09-20T21:50:57Z

connection is broken), take this into account and return at this point.