src/lib/libfetch/ftp.c, branch releng/5.0

The FTP connection caching needs a better interface -- connections are

2002-10-25T01:17:32Z

closed through _fetch_close() which is the only one who knows the connection REALLY was closed (since ref -> 0). However, FTP keeps its own local cached_connection and checks if it is valid by comparing it to NULL. This is bogus since it may have been freed elsewhere by _fetch_close(). This change checks if we are closing the cached_connection and the ref is 1 (soon to be 0). If so, set cached_connection to NULL so we don't accidentally reuse it. The REAL fix should be to move connection caching to the common.c level (_fetch_* functions) and NULL the cache(s) in _fetch_close(). Then all layers could benefit from caching.

When recycling a cached connection, increment the reference count so that

2002-10-20T10:36:27Z

the heap block does not get freed and reused. This should fix the pkg_add -r crashes that have been happening for months.

Make _fetch_connect() always set the error code.

2002-09-17T05:54:33Z

Tell ftp that _fetch_connect() always sets the error code (http already knew)

Cope with 2292bis-01 getaddrinfo (no NI_WITHSCOPEID, always attach

2002-07-02T11:09:02Z

scope identifier). Approved by: des MFC after: 3 weeks

Add a reference count to struct fetchconn so we don't prematurely close and

2002-06-11T11:27:28Z

free a cached FTP connection.

Wrap everything in struct connection, and enforce timeouts everywhere

2002-06-05T12:19:08Z

(except for DNS operations). Always use funopen() for HTTP, to support both timeouts and SSL.

First step towards SSL support: wrap connections in a 'struct connection'

2002-06-05T10:05:03Z

which contains the socket descriptor, the input buffer and (yet unused) SSL state variables. This has the neat side effect of greatly improving reentrance (though we're not *quite* there yet) and opening the door to HTTP connection caching. This commit is inspired by email conversations with and patches from Henry Whincup last fall.

Modernize my email address

2002-03-25T13:53:46Z

Reindent, and add parentheses to return statements. Some functions in

2002-02-05T22:13:51Z

ftp.c and http.c now have exceedingly long lines due to deep nesting; this will be corrected by reorganizing the code in a later revision.

Mark uploads as O_WRONLY, not O_RDONLY.

2002-01-20T19:52:25Z

PR: misc/34043 MFC after: 2 weeks