src/lib/libfetch, branch releng/13.5FreeBSD source treehttps://cgit-dev.freebsd.org/src/atom?h=releng%2F13.52024-04-03T19:12:38Zlibfetch: parse scheme://domain:/ correctly2024-04-03T19:12:38ZKa Ho Ngkhng@FreeBSD.org2024-03-25T20:10:42Zurn:sha1:c89889b9c342e764e39b351d5024a4ba3429fb15
This improves URL-parsing compability with cURL, and unbreaks parsing of
similar kinds of URLs after commit 8d9de5b10a24.
Sponsored by: Juniper Networks, Inc.
Reviewed by: des
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D44493
(cherry picked from commit fb860ed0c52c2c1e7792ef86718620a439663c7f)
libfetch, fetch: Stop recommending the use of ca_root_nss.2023-12-13T16:21:29ZDag-Erling Smørgravdes@FreeBSD.org2023-10-08T04:35:15Zurn:sha1:dc7d88c71d2be3363c94045fe439e21b8a838687
MFC after: 3 days
Reviewed by: kevans, emaste
Differential Revision: https://reviews.freebsd.org/D42119
(cherry picked from commit 2821a7498f65d357c68166e1978b491abef1ca4a)
libfetch: don't rely on ca_root_nss for certificate validation2023-10-05T15:55:33ZMichael Osipovmichael.osipov@siemens.com2023-10-03T05:53:20Zurn:sha1:baf69f6c997392cde9ae75d3ebc25a8201c7cc99
Before certctl(8), there was no system trust store, and libfetch
relied on the CA certificate bundle from the ca_root_nss port to
verify peers.
We now have a system trust store and a reliable mechanism for
manipulating it (to explicitly add, remove, or revoke certificates),
but if ca_root_nss is installed, libfetch will still prefer that to
the system trust store.
With this change, unless explicitly overridden, libfetch will rely on
OpenSSL to pick up the default system trust store.
PR: 256902
MFC after: 3 days
Reviewed by: kevans
Differential Revision: https://reviews.freebsd.org/D42059
(cherry picked from commit 09f5c1e118bb4eca77b83a0d08f559b20f60aa59)
Remove $FreeBSD$: two-line nroff pattern2023-08-23T17:43:31ZWarner Loshimp@FreeBSD.org2023-08-22T01:32:08Zurn:sha1:b144e70a3325e033163aa4e6e15d0446e245702d
Remove /^\.\\"\n\.\\"\s*\$FreeBSD\$$\n/
Similar commit in main:
(cherry picked from commit fa9896e082a1)
Remove $FreeBSD$: one-line sh pattern2023-08-23T17:43:30ZWarner Loshimp@FreeBSD.org2023-08-22T01:32:01Zurn:sha1:023fc80ee38a117fa65b2ccb2abf8bdc7dbd6fd9
Remove /^\s*#[#!]?\s*\$FreeBSD\$.*$\n/
Similar commit in main:
(cherry picked from commit d0b2dbfa0ecf)
Remove $FreeBSD$: one-line .c pattern2023-08-23T17:43:26ZWarner Loshimp@FreeBSD.org2023-08-22T01:31:41Zurn:sha1:3d497e17ebd33fe0f58d773e35ab994d750258d6
Remove /^[\s*]*__FBSDID\("\$FreeBSD\$"\);?\s*\n/
Similar commit in main:
(cherry picked from commit 1d386b48a555)
Remove $FreeBSD$: two-line .h pattern2023-08-23T17:43:21ZWarner Loshimp@FreeBSD.org2023-08-22T01:31:07Zurn:sha1:17da660ad5b3b9cd90e164dd4dbb9beaa7203054
Remove /^\s*\*\n \*\s+\$FreeBSD\$$\n/
Similar commit in main:
(cherry picked from commit b3e7694832e8)
libfetch: Pass a zeroed digest to DigestCalcResponse.2023-01-24T05:13:19ZJohn Baldwinjhb@FreeBSD.org2022-11-16T03:18:58Zurn:sha1:13961b5a48d10e3a045a54ce9a6639bce9416989
GCC 12 warns that passing "" (a constant of char[1]) to a parameter of
type char[33] could potentially overread. It is not clear from the
context that c->qops can never be "auth-int" (and if it can't, then
the "auth-int" handling in DigestCalcResponse is dead code that should
be removed since this is the only place the function is called).
Reviewed by: emaste
Differential Revision: https://reviews.freebsd.org/D36825
(cherry picked from commit 57fbafb8deac75b924faf1fa6c2222a7719fdfec)
fetch: support EAI_ADDRFAMILY error, correct two error messages2022-12-03T15:17:10ZMike Karelskarels@FreeBSD.org2022-11-02T15:59:09Zurn:sha1:8d44502e7f6438e32bf1d9f48cbf341d3c985bed
With the change to return EAI_ADDRFAMILY from getaddrinfo(), fetch
would print "Unknown resolver error" for that error. Add that error
and its string to libfetch's table, using an #ifdef just in case.
Correct error strings for EAI_NODATA (although it is currently unused)
and EAI_NONAME. Should maybe rework the code to use gai_strerror(3),
but that doesn't map directly, and the current strings are shortened.
Reviewed in https://reviews.freebsd.org/D37139 with related changes.
Reviewed by: bz
(cherry picked from commit 631b82aca0fd41c8e0d48eebdb9c4e38b7306472)
libfetch: Use memcpy in place of an odd strncpy.2022-11-11T18:18:54ZJohn Baldwinjhb@FreeBSD.org2022-10-03T23:10:43Zurn:sha1:7cefb4bc4b1cf8c5e61a2dde8c84249712290319
The length passed to strncpy is the length of the source string, not
the destination buffer. This triggers a non-fatal warning in GCC 12.
Hoewver, the code is also odd. It is really just a memcpy of the
string without its nul terminator. For that use case, memcpy is
clearer.
Reviewed by: imp, emaste
Differential Revision: https://reviews.freebsd.org/D36824
(cherry picked from commit 611cf392672cf7aa52a593412fb2537546a7d6a4)