src/lib/libgeom, branch main

libgeom: Fix 32-bit gcc build

2026-01-03T20:37:18Z

MFC after: 1 week Fixes: 27894e20f140 ("libgeom: Fix segfault in 32-on-64 case")

libgeom: Improve type safety of xml2tree code

2026-01-03T09:10:23Z

When resolving references, assert that the type of the object we find is what we expect. This will help prevent memory corruption if two objects of different types somehow end up with the same identifier. MFC after: 1 week Reviewed by: imp Differential Revision: https://reviews.freebsd.org/D54454

libgeom: Clean up xml2tree code

2026-01-03T09:10:23Z

MFC after: 1 week Reviewed by: imp Differential Revision: https://reviews.freebsd.org/D54453

libgeom: Fix segfault in 32-on-64 case

2026-01-03T09:10:23Z

We were using strtoul() to parse object identifiers, which are kernel pointers. This works fine as long as the kernel and userland match, but in a 32-bit libgeom on a 64-bit kernel this will return ULONG_MAX for all objects, resulting in memory corruption when we later pick the wrong object while resolving consumer-producer references. MFC after: 1 week PR: 292127 Reviewed by: imp Differential Revision: https://reviews.freebsd.org/D54452

libgeom: Avoid fixed remappings of the devstat device

2024-08-19T16:02:59Z

libgeom maintains a quasi-private mapping of /dev/devstat, which might grow over time if new devices appear. When the mapping needs to be expanded, the old mapping is passed as a hint, but this appears to be unnecessary. Simplify and improve things a bit: - stop passing a hint when remapping, - don't creat a mapping in geom_stats_open(), as geom_stats_resync() will create it for us, - check for errors from munmap(). Reviewed by: imp, asomers Tested by: asomers MFC after: 2 weeks Sponsored by: Innovate UK Differential Revision: https://reviews.freebsd.org/D46294

libgeom: Consistently use item count as the first argument to calloc

2024-07-19T17:06:03Z

Reported by: GCC 14 -Wcalloc-transposed-args Reviewed by: rlibby, imp, emaste Differential Revision: https://reviews.freebsd.org/D46006

Remove residual blank line at start of Makefile

2024-07-15T22:43:39Z

This is a residual of the $FreeBSD$ removal. MFC After: 3 days (though I'll just run the command on the branches) Sponsored by: Netflix

lib: Automated cleanup of cdefs and other formatting

2023-11-27T05:23:59Z

Apply the following automated changes to try to eliminate no-longer-needed sys/cdefs.h includes as well as now-empty blank lines in a row. Remove /^#if.*\n#endif.*\n#include\s+.*\n/ Remove /\n+#include\s+.*\n+#if.*\n#endif.*\n+/ Remove /\n+#if.*\n#endif.*\n+/ Remove /^#if.*\n#endif.*\n/ Remove /\n+#include\s+\n#include\s+/ Remove /\n+#include\s+\n#include\s+/ Remove /\n+#include\s+\n#include\s+/ Sponsored by: Netflix

Remove $FreeBSD$: two-line nroff pattern

2023-08-16T17:55:10Z

Remove /^\.\\"\n\.\\"\s*\$FreeBSD\$$\n/

Remove $FreeBSD$: one-line sh pattern

2023-08-16T17:55:03Z

Remove /^\s*#[#!]?\s*\$FreeBSD\$.*$\n/