src/lib/libutil/flopen.c, branch releng/8.3 FreeBSD source tree https://cgit-dev.freebsd.org/src/atom?h=releng%2F8.3 2009-06-06T18:47:03Z Revert (once again, and hopefully for the last time) to flock(2) locks. 2009-06-06T18:47:03Z Dag-Erling Smørgrav des@FreeBSD.org 2009-06-06T18:47:03Z urn:sha1:5649afd028c62ae91a75c10a285c88e7b38e15e6 The problem with fcntl(2) locks is that they are not inherited by child processes. This breaks pidfile(3), where the common idiom is to open and lock the PID file before daemonizing. Diff reduction against Varnish, including one important fix: use a shared 2008-10-20T18:11:30Z Dag-Erling Smørgrav des@FreeBSD.org 2008-10-20T18:11:30Z urn:sha1:0e25c55a954565bb491ed1f3a81c57057a64b29a lock if the file is opened with O_RDONLY. Reimplement flopen(3) using fcntl(2) locks instead of flock(2) locks. 2008-10-20T18:02:16Z Dag-Erling Smørgrav des@FreeBSD.org 2008-10-20T18:02:16Z urn:sha1:80de06ed6b796541c956ea77e8c6354eca0e2141 Back out previous commit until I figure out why my regression test fails. 2007-08-03T09:20:28Z Dag-Erling Smørgrav des@FreeBSD.org 2007-08-03T09:20:28Z urn:sha1:062044ebbecb3f215d9ba39a22faeba6f8720d75 Approved by: re (kensmith) Use fcntl(2)-style locks instead of less-portable flock(2)-style locks. 2007-08-03T06:32:45Z Dag-Erling Smørgrav des@FreeBSD.org 2007-08-03T06:32:45Z urn:sha1:7eb198c6424d784ecc2723f0457fd936b6ecf8d1 Approved by: re (kensmith) Nit: avoid shadowing truncate(2) with a local variable. 2007-05-23T12:09:33Z Dag-Erling Smørgrav des@FreeBSD.org 2007-05-23T12:09:33Z urn:sha1:4b5b992bbac261a7c5cfc9c350dc9c644dd3a383 Fix stupid braino in previous commit. 2007-05-23T10:06:03Z Dag-Erling Smørgrav des@FreeBSD.org 2007-05-23T10:06:03Z urn:sha1:400f77294311c74ad8db91d11f3c26c8c72170c9 If (flags & O_TRUNC), don't truncate the file until we've successfully 2007-05-23T08:12:34Z Dag-Erling Smørgrav des@FreeBSD.org 2007-05-23T08:12:34Z urn:sha1:d75d56060e0bb6ae2d9b44e26fb050c6fd82c299 locked it. MFC after: 3 weeks Well gag me with a spoon... I'm so used to working at high WARNS levels 2007-05-10T15:01:42Z Dag-Erling Smørgrav des@FreeBSD.org 2007-05-10T15:01:42Z urn:sha1:8f9085389f734f1e0f7e926ee0f3b44419d8c4fc that I make stupid fundamental mistakes like this when I don't. Remove superfluous unexpanded RCS tag. 2007-05-10T14:56:07Z Dag-Erling Smørgrav des@FreeBSD.org 2007-05-10T14:56:07Z urn:sha1:b252bedcc96bf1764737714f7bbd1a17f7c28e6c