src/libexec/comsat, branch mainFreeBSD source treehttps://cgit-dev.freebsd.org/src/atom?h=main2025-07-28T15:28:59Zcomsat: Don't return from the child2025-07-28T15:28:59ZDag-Erling Smørgravdes@FreeBSD.org2025-07-28T15:28:34Zurn:sha1:e40a2c4927a8068d7b6adee69c90ae3be8efc4df
Fixes: 91629228e3df
MFC after: 1 week
Reviewed by: emaste
Differential Revision: https://reviews.freebsd.org/D51581
comsat: Don't read arbitrary files2025-07-28T15:28:59ZDag-Erling Smørgravdes@FreeBSD.org2025-07-28T15:28:26Zurn:sha1:4a4338d94401f0012380d4f1a4d332bd6d44fa8e
When processing a notification, instead of accepting any file name
that doesn't begin with a slash, accept only file names that don't
contain any slashes at all. This makes it possible to notify a
user about a mailbox that doesn't bear their name, as long as they
are permitted to read it, but prevents comsat from reading files
outside the mail spool.
PR: 270404
MFC after: 1 week
Reviewed by: emaste
Differential Revision: https://reviews.freebsd.org/D51580
comsat: move uid/gid setting earlier2024-12-02T19:57:13ZEd Masteemaste@FreeBSD.org2024-12-01T20:43:10Zurn:sha1:91629228e3df14997df12ffc6e7be6b9964e5463
It's good to reduce privilege as early as possible.
Suggested by: jlduran
Reviewed by: jlduran
Obtained from: NetBSD
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D47869
comsat: Use initgroups and setgid not just setuid2024-12-01T20:29:02ZEd Masteemaste@FreeBSD.org2024-11-28T16:54:48Zurn:sha1:d4dd9e22c13896e6b5e2a6fc78dad4f8496cc14d
PR: 270404
Reviewed by: jlduran
Obtained from: NetBSD
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D47828
comsat: Improve use of setuid()2024-11-28T13:04:10ZEd Masteemaste@FreeBSD.org2024-11-27T20:36:46Zurn:sha1:062b69ba045dc0fef3d9b8d73365d2798c05a480
Just return from jkfprintf if either (a) user lookup fails (that is,
getpwnam fails) or (b) setuid() to the user's uid fails. If comsat is
invoked from inetd using the default of tty:tty we will now return due
to setuid() failing rather than fopen() failing.
PR: 270404
Reviewed by: kevans
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D47823
Remove residual blank line at start of Makefile2024-07-15T22:43:39ZWarner Loshimp@FreeBSD.org2024-07-15T04:46:32Zurn:sha1:e9ac41698b2f322d55ccf9da50a3596edb2c1800
This is a residual of the $FreeBSD$ removal.
MFC After: 3 days (though I'll just run the command on the branches)
Sponsored by: Netflix
Remove copyright strings ifdef'd out2023-11-27T05:23:58ZWarner Loshimp@FreeBSD.org2023-11-24T07:45:36Zurn:sha1:0b8224d1cc9dc6c9778ba04a75b2c8d47e5d7481
We've ifdef'd out the copyright strings for some time now. Go ahead and
remove the ifdefs. Plus whatever other detritis was left over from other
recent removals. These copyright strings are present in the comments and
are largely from CSRG's attempt at adding their copyright to every
binary file (which modern interpretations of the license doesn't
require).
Sponsored by: Netflix
libexec: Remove ancient SCCS tags.2023-11-27T05:23:28ZWarner Loshimp@FreeBSD.org2023-11-23T17:21:37Zurn:sha1:43581d7b6617959e4452094d9330ef020034a6c9
Remove ancient SCCS tags from the tree, automated scripting, with two
minor fixup to keep things compiling. All the common forms in the tree
were removed with a perl script.
Sponsored by: Netflix
Purge more stray embedded $FreeBSD$ strings2023-09-25T14:54:56ZJohn Baldwinjhb@FreeBSD.org2023-09-25T14:54:56Zurn:sha1:eba230afba4932f02a1ca44efc797cf7499a5cb0
These do not use __FBSDID but instead use bare char arrays.
Reviewed by: imp, emaste
Differential Revision: https://reviews.freebsd.org/D41957
Remove $FreeBSD$: one-line nroff pattern2023-08-16T17:55:15ZWarner Loshimp@FreeBSD.org2023-08-16T17:55:15Zurn:sha1:b2c76c41be32f904179efed29c0ca04d53f3996c
Remove /^\.\\"\s*\$FreeBSD\$$\n/