src/libexec/rexecd, branch releng/12.4

Remove rexecd(8), a server that implements a particularly insecure

2005-06-10T20:52:36Z

method of executing commands remotely. There are no rexec clients in the FreeBSD tree, and the client function rexec(3) is present only in libcompat. It has been documented as "obsolete" since 4.3BSD, and its use has been discouraged in the man page for over 10 years.

s/int/size_t/ as appropriate.

2005-04-17T01:06:37Z

Noticed by: bde

Revert parts of previous commits and use a temporary variable to avoid

2005-04-08T11:19:50Z

an invalid type pun.

An array was mistaken for a pointer in the previous commit.

2005-04-07T19:26:35Z

Noticed by: tinderbox, stefanf Pointy hat to: nectar

Correct type mismatch introduced in last commit.

2005-04-05T18:25:27Z

Noticed by: Steve Kargl

DES pointed out that the PAM layer may change the target user name

2005-04-05T14:55:33Z

during authentication. Thus we need to call getpwnam *after* the user has been authenticated. Colin mentioned that we should also move the check for root in that case.

When PAM support was added to rexecd in revision 1.29 (just prior to

2005-03-27T13:59:44Z

5.0-RELEASE), a visually elusive bug was introduced. A comparison operator was changed to assignment. As a result, rexecd behaved always as if the `-i' option had been specified. It would allow root logins. This commit corrects the situation in the obvious way. A separate bug was introduced at the same time. The PAM library functions are called between the invocation of getpwnam(3) and the use of the returned static object. Since many PAM library functions result in additional getpwnam(3) calls, the contents of the returned static object could be changed from under rexecd. With this commit, getpwnam_r(3) is used instead. Other PAM-using applications should be reviewed for similar errors in getpw* usage. Security: rexecd's documented default policy of disallowing root logins was not enforced. Reviewed by: cperciva

Use sysconf(_SC_ARG_MAX) instead of NCARGS.

2005-03-21T08:01:14Z

correct WARNS=6 fix to use cast to (void *).

2005-03-01T10:55:06Z

use of struct sockaddr_strage * is thought as not good manner. :)

If what we have is a struct sockaddr_storage * and what we want is a

2005-02-23T21:26:55Z

struct sockaddr_storage *, there's no point in casting it prematurely to a struct sockaddr *. This unbreaks WARNS=6 on sparc64.