src/libexec/rtld-elf, branch releng/13.5

rtld-elf: Fix for mips with LLD 14+

2024-12-13T00:18:33Z

As of LLD 14, it no longer falls back to the address of .text if it can't find the entry point, and instead just uses address 0. Since the mips port has always used rtld_start as its entry point symbol but has never set RTLD_ENTRY to match (instead getting the default .rtld_start), with LLD 14+ it ends up using an entry point of 0, i.e. reinterpreting various headers and metadata sections as code, and thus quickly dies, in my case with SIGILL. This has seemingly always been a warning with LLD even when it defaulted to .text, but that went unnoticed this whole time, until now. Fix this by specifying the right symbol name. This is a direct commit to stable/13 as mips no longer exists in main.

rtld/arm: fix initial-exec (IE) thread-local storage relocation

2024-11-22T15:41:10Z

net/frr[89] revealed an interesting edge-case on arm when dynamically linking a shared library that declares more than one static TLS variable with at least one using the "initial-exec" TLS model. In the case of frr[89], this library was libfrr.so which essentially does the following: #include #include "lib.h" static __thread int *a __attribute__((tls_model("initial-exec"))); void lib_test() { static __thread int b = -1; printf("&a = %p\n", &a); printf(" a = %p\n", a); printf("\n"); printf("&b = %p\n", &b); printf(" b = %d\n", b); } Allocates a file scoped `static __thread` pointer with tls_model("initial-exec") and later a block scoped TLS int. Notice in the above minimal reproducer, `b == -1`. The relocation process does the wrong thing and ends up pointing both `a` and `b` at the same place in memory. The output of the above in the broken state is: &a = 0x4009c018 a = 0xffffffff &b = 0x4009c018 b = -1 With the patch applied, the output becomes: &a = 0x4009c01c a = 0x0 &b = 0x4009c018 b = -1 Reviewed by: kib Approved by: kp (mentor) Sponsored by: Rubicon Communications, LLC ("Netgate") Differential Revision: https://reviews.freebsd.org/D42415/ (cherry picked from commit 98fd69f0090da73d9d0451bd769d7752468284c6)

Remove "All Rights Reserved" from FreeBSD Foundation copyrights

2024-09-07T16:30:19Z

These ones were unambiguous cases where the Foundation was the only listed copyright holder. Sponsored by: The FreeBSD Foundation (cherry picked from commit 5c2bc3db201a4fe8d7911cf816bea104d5dc2138) (cherry picked from commit f06d322e9d925ab56a4aa8210a67637d4d341ab6)

rtld: Define MD_OBJ_ENTRY for mips

2024-07-31T18:59:43Z

This is a direct commit to stable/13. Reported by: mmel Fixes: f9210d37c5c6 ("rtld: Add MD_OBJ_ENTRY to extend Struct_Obj_Entry")

rtld: Add MD_OBJ_ENTRY to extend Struct_Obj_Entry

2024-07-15T12:34:29Z

Add a macro the architectures can use to add per-arch fields to Struct_Obj_Entry. Reviewed by: kib Sponsored by: Arm Ltd Differential Revision: https://reviews.freebsd.org/D45116 (cherry picked from commit 06db20ffeca9898e5802d63f3b06caaa37c3a4ed)

rtld.1: clarify interaction between -u and -o

2024-05-07T08:59:07Z

(cherry picked from commit 6a7819e43f938992304472054c83f4a6602a9e19)

rtld direct exec: make -u behavior match the description

2024-05-07T08:59:07Z

(cherry picked from commit ef2694f368cee5957ee44b0298da88ff8360d561)

rtld: add direct-exec option -o

2024-05-07T08:59:07Z

(cherry picked from commit d1cd0cc32b53c09e72e33116b94a5b0b9781a183)

rtld snprintf: do not erronously skip a char at the buffer boundary

2024-05-03T00:26:26Z

(cherry picked from commit 56ee5fc43c40479e2651b21862e299bcf73017ae)

rtld(1): minor clarification for LD_STATIC_TLS_EXTRA

2024-04-23T00:32:54Z

(cherry picked from commit 8d7473703520f315c1bcd3b3d12498eee10d563e)