src/libexec/tftpd, branch release/9.0.0

Pull in some wording to the tftpd.8 man page

2011-07-31T03:18:36Z

from NetBSD, with some slight changes: ========================================================================================= http://cvsweb.netbsd.org/bsdweb.cgi/src/libexec/tftpd/tftpd.8?only_with_tag=MAIN#rev1.22 Revision 1.22 or diffs], Fri Jan 8 21:05:14 2010 UTC (18 months, 2 weeks ago) by christos Patrick Welche - add -p pathsep option - make wrap to zero work, but produce a warning While here: - fix gcc warnings, in particular variable clobbered warnings (compiling with fewer warnings does not really fix the problem) ========================================================================================= These wording changes clarify the default rollover behavior as a "kludge". Also, the block numbers and octet counts for 65535 blocks and 32767 blocks are more accurate than the existing documented numbers. Requested by: Pawan Gupta Obtained from: Juniper Networks Approved by: re (kib)

In the old TFTP server, there was an undocumented behavior where

2011-07-31T03:12:20Z

the block counter would rollover to 0 if a file larger than 65535 blocks was transferred. With the default block size of 512 octets per block, this is a file size of approximately 32 megabytes. The new TFTP server code would report an error and stop transferring the file if a file was larger than 65535 blocks. This patch restores the old TFTP server's behavior to the new TFTP server code. If a TFTP client transfers a file larger than 65535 blocks, and does *not* specify the "rollover" option, then automatically rollover the block counter to 0 every time we reach 65535 blocks. This restores interoperability with the FreeBSD 6 TFTP client. Without this change, if a FreeBSD 6 TFTP client tried to retrieve a file larger than 65535 blocks from a FreeBSD 9 TFTP server , the transfer would fail. The same file could be retrieved successfully if the same FreeBSD 6 TFTP client was used against a FreeBSD 6 TFTP server. Approved by: re (kib) Tested by: Pawan Gupta , Obtained from: Juniper Networks

Acknowledge Edwin Groothuis for the major rewrite he

2011-06-24T05:41:38Z

did of the tftpd and tftp code to support TFTP blocksize.

Bring back synchnet() implementation from older

2011-06-24T02:56:24Z

tftp implementation. The synchnet() function was converted to a no-op when the new TFTP implementation was committed to FreeBSD. However, this function, as it was in the older code, is needed in order to synchronize between the tftpd server and tftp clients, which may be buggy. Specifically, we had a buggy TFTP client which would send TFTP ACK packets for non-TFTP packets, which would cause the count of packets to get out of whack, causing transfers to fail with the new TFTPD implementation. Obtained from: Juniper Networks Submitted by: Santhanakrishnan Balraj

Update references to RFC's that the newer TFTP implementation supports.

2011-06-22T23:25:24Z

Fix typo.

2011-06-22T22:05:37Z

Reported by: Nick Mann

Clarify tftpd's -d flag in the new TFTP implementation.

2011-06-22T21:53:45Z

Bump date.

Clarify that the TFTP blocksize (RFC2348) or non-standard

2011-06-16T02:27:05Z

TFTP rollover option can be used to transfer larger files.

Fix tftp_log() usage.

2011-05-26T20:32:33Z

Fix typos.

2010-11-09T10:59:09Z

PR: bin/148894 Submitted by: olgeni