src/module, branch zfs-0.7.0-rc2

Fix lookup_bdev() on Ubuntu

2016-10-26T17:30:43Z

Ubuntu added support for checking inode permissions to lookup_bdev() in kernel commit 193fb6a2c94fab8eb8ce70a5da4d21c7d4023bee (merged in 4.4.0-6.21). Upstream bug: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1636517 This patch adds a test for Ubuntu's variant of lookup_bdev() to configure and calls the function in the correct way. Reviewed-by: Brian Behlendorf Signed-off-by: Hajo Möller Closes #5336

Disable zio_dva_throttle_enabled by default

2016-10-26T16:13:43Z

Until it can be determined definitively that a performance regression wasn't introduced accidentally by 3dfb57a this functionality is being disabled by default. It can be re- enabled by setting zio_dva_throttle_enabled=1. Signed-off-by: Brian Behlendorf Closes #5335 Issue #5289

Fix statechange-led.sh & unnecessary libdevmapper warning

2016-10-25T18:05:30Z

- Fix autoreplace behaviour on statechange-led.sh script. ZED sends the following events on an auto-replace: 1. statechange: Disk goes UNAVAIL->ONLINE 2. statechange: Disk goes ONLINE->UNAVAIL 3. vdev_attach: Disk goes ONLINE Events 1-2 happen when ZED first attempts to do an auto-online. When that fails, ZED then tries an auto-replace, generating the vdev_attach event in #3. In the previous code, statechange-led was only looking at the UNAVAIL->ONLINE transition to turn off the LED. It ignored the #2 ONLINE->UNAVAIL transition, assuming it was just the "old" VDEV going offline. This is problematic, as a drive can go from ONLINE->UNAVAIL when it's malfunctioning, and we don't want to ignore that. This new patch correctly turns on the fault LED every time a drive becomes UNAVAIL. It also monitors vdev_attach events to trigger turning off the LED when an auto-replaced disk comes online. - Remove unnecessary libdevmapper warning with --with-config=kernel This fixes an unnecessary libdevmapper warning when building --with-config=kernel. Kernel code does not use libdevmapper, so the warning is not needed. Reviewed-by: Brian Behlendorf Signed-off-by: Tony Hutter Closes #2375 Closes #5312 Closes #5331

icp: mark asm files with noexec stack

2016-10-25T17:44:09Z

Similar to commit a3600a106. Asm files need an explicit note that they do not require an executable stack. Reviewed-by: Brian Behlendorf Signed-off-by: Jason Zaman Closes #5332

Fix cred leak in zpl_fallocate_common

2016-10-24T23:41:56Z

This is caught by kmemleak when running compress_004_pos Reviewed-by: Tim Chase Reviewed by: Brian Behlendorf Signed-off-by: Chunwei Chen Closes #5244 Closes #5330

Fix taskq creation failure in vdev_open_children()

2016-10-24T20:28:58Z

When creating and destroying pools in tight loop it's possible to exhaust the number of allowed threads on a system. This results in taskq_create() failling and a NULL dereference. Resolve the issue by falling back to opening the vdevs all synchronously. Reviewed-by: Denys Rtveliashvili Reviewed-by: Håkan Johansson Signed-off-by: Brian Behlendorf Closes zfsonlinux/spl#521 Closes #4637

Turn on/off enclosure slot fault LED even when disk isn't present

2016-10-24T17:45:59Z

Previously when a drive faulted, the statechange-led.sh script would lookup the drive's LED sysfs entry in /sys/block/sd*/device/enclosure_device, and turn it on. During testing we noticed that if you pulled out a drive, or if the drive was so badly broken that it no longer appeared to Linux, that the /sys/block/sd* path would be removed, and the script could not lookup the LED entry. To fix this, this patch looks up the disks's more persistent "/sys/class/enclosure/X:X:X:X/Slot N" LED sysfs path at pool import. It then passes that path to the statechange-led script to use, rather than having the script look it up on the fly. This allows the script to turn on/off the slot LEDs even when the drive is missing. Closes #5309 Closes #2375

Fletcher4 algorithm implemented in pure NEON for Aarch64 / ARMv8 64 bits

2016-10-21T17:55:49Z

This is not useful on micro-architecture with a weak NEON implementation (only 64 bits); the native version is slower & the byteswap barely faster than scalar. On A53 or A57, it's a small improvement on scalar but OK for byteswap. Results from an A53 system: 0 0 0x01 -1 0 1499068294333000 1499101101878000 implementation native byteswap scalar 1008227510 755880264 aarch64_neon 1198098720 1044818671 fastest aarch64_neon aarch64_neon Results from a A57 system: 0 0 0x01 -1 0 4407214734807033 4407233933777404 implementation native byteswap scalar 2302071241 1124873346 aarch64_neon 2542214946 2245570352 fastest aarch64_neon aarch64_neon Reviewed-by: Gvozden Neskovic Reviewed-by: Brian Behlendorf Signed-off-by: Romain Dolbeau Closes #5248

Fix userquota_compare() function

2016-10-21T15:23:27Z

The AVL tree compare function requires that either -1, 0, or 1 be returned. However the strcmp() function only guarantees that a negative, zero, or positive value is returned. Therefore, the return value of strcmp() needs to be sanitized with AVL_ISIGN. This was initially overlooked because the x86_64 implementation of strcmp() happens to only returns the allowed values. This was observed on an aarch64 platform which behaves correctly but differently as described above. Reviewed-by: Jinshan Xiong Reviewed-by: Richard Laager Signed-off-by: Brian Behlendorf Closes #5311 Closes #5313

Fix coverity defects: CID 153459

2016-10-20T18:54:02Z

CID 153459: Null pointer dereferences (FORWARD_NULL) Accidentally introduced by #5159. Reviewed-by: Brian Behlendorf Signed-off-by: luozhengzheng Closes #5310