src/sbin/mount_msdosfs/mount_msdosfs.c, branch releng/7.3FreeBSD source treehttps://cgit-dev.freebsd.org/src/atom?h=releng%2F7.32007-01-29T01:49:08ZPass "errmsg" to nmount(), so that if nmount() fails, we can get2007-01-29T01:49:08ZCraig Rodriguesrodrigc@FreeBSD.org2007-01-29T01:49:08Zurn:sha1:578cfbaae8bf26b839069304a941824bf476d7f8
strings provided by vfs_mount_error().
mount_msdosfs.c:2006-06-01T02:25:00ZCraig Rodriguesrodrigc@FreeBSD.org2006-06-01T02:25:00Zurn:sha1:829b898c7c7cb4a3ada1df414357a18548550659
- remove call to getmntopts(), and just pass -o options to
nmount(). This removes some confusion as to what options
msdosfs can parse, by pushing the responsibility of option parsing
to the VFS and FS specific code in the kernel.
msdosfs_vfsops.c:
- add "force" and "sync" to msdosfs_opts. They used to be specified
in mount_msdosfs.c, so move them here. It's not clear whethere these
options should be placed into global_opts in vfs_mount.c or not.
Motivated by: marcus
Fixing yet another regression introduced in rev1.37 by preserving cs_local2005-12-01T00:18:48ZTai-hwa Liangavatar@FreeBSD.org2005-12-01T00:18:48Zurn:sha1:9f6442eea21b7a41950739437c5c6cfb8bf78f7c
pointer such that local to DOS code page conversion with combined option
'-L,-D' works again.
Reviewed by: rodrigc
It turns out that set_charset() invokes build_iovec_argf() which modifies2005-11-25T19:55:14ZTai-hwa Liangavatar@FreeBSD.org2005-11-25T19:55:14Zurn:sha1:6a604ed4fb00cb137568dcf4b307aa7aea7312c7
iov address internally through realloc(3). However, since the function
parameter wasn't designed to allow the modified iov being passed back to
the caller, we ended up feeding iov with several corrupted entries(this
depends on how many arguments were pushed into iovec before set_charset())
to nmount(2).
This commit fixes this regression introduced in rev1.37 such that
mount_msdosfs(8) with code page conversion option(-W,-D) enabled works again.
Reviewed by: rodrigc
- Adding the missing 'W' option back which was accidentally removed2005-11-23T19:52:14ZTai-hwa Liangavatar@FreeBSD.org2005-11-23T19:52:14Zurn:sha1:62c7cb517a040826a8c1ffbdae9b999082ad6248
in rev1.37.
- Fixing a core dump inside build_iovec_argf by providing a !NULL format
string to vsnprintf(3).
Reviewed by: rodrigc
o Style: restore tab indentation mangled in the previous delta.2005-11-14T16:04:01ZMaxim Konovalovmaxim@FreeBSD.org2005-11-14T16:04:01Zurn:sha1:c22d354139b81b7ee77d75b93a31fdfa20c27c49Convert mount_msdosfs to use nmount().2005-11-13T03:24:44ZCraig Rodriguesrodrigc@FreeBSD.org2005-11-13T03:24:44Zurn:sha1:825197f9a02a3f076957813ef8d655ddd2b18e8fUse MOPT_END in favor of MOPT_NULL, which better describes the purporse2005-06-10T09:51:43ZXin LIdelphij@FreeBSD.org2005-06-10T09:51:43Zurn:sha1:46b7a14ba40ee64e15ab2022897d62484b4cedf6
of the macro.
Add a handy macro to represent null mount option, MOPT_NULL, and make2005-06-01T09:39:36ZXin LIdelphij@FreeBSD.org2005-06-01T09:39:36Zurn:sha1:73ac45052f0c9d5ff55352ce80a0cec86b831908
use of the macro in sbin/mount*'s, by replacing:
mopts[] = {
MOPT_STDOPTS,
{ NULL }
}
With:
mopts[] = {
MOPT_STDOPTS,
MOPT_NULL
}
This change will help to reduce the situation that we don't explicitly
initialize "struct mntopt"'s. It should not contribute to any
functional/logical changes as far as I can tell.
Correct a style bug: remove a gratuitous space between ( and ".2004-08-31T05:19:57ZTom Rhodestrhodes@FreeBSD.org2004-08-31T05:19:57Zurn:sha1:8f28fe7f421860e7a06bd73cfc5f06c7e1dde6d6
Ok'ed by: fjoe