src/sbin/ping/tests/test_ping.py, branch main

ping: Fix bell char ordering in -A test cases

2026-06-30T13:07:59Z

Previously, these tests expected the bell chars to arrive before the initial status line. This appeared to be ok because ping(8) incorrectly mixed unbuffered and buffered writes by using printf(3) calls for the initial status, but direct write(2) calls for the bell chars. 141bb85798 revealed that the test's assertions only passed because the buffered writes did not get flushed before the direct writes in the test runs. 8bda488114f3 fixed ping(8) to use POSIX stdio buffered writes in all cases and guarantee a deterministic output ordering to stdout observers. This patch fixes the test to match the correct ordering. Reviewed by: des Sponsored by: The FreeBSD Foundation

Revert "ping/tests: expect bell chars from stderr after initial status"

2026-06-30T13:07:47Z

This reverts commit 5b8c28adb829b50fb8ac065637fa99f717858bab. The commit message was wrong. Reported by: des

ping/tests: expect bell chars from stderr after initial status

2026-06-26T22:46:09Z

After 141bb85798 and 8bda488114f3, ping(8) first writes and flushes the initial status to stdout, then writes notification bell characters to stderr. This patch corrects the expected order of the output to stdout and stderr. This is a temporary fix; the test should be rewritten to separate the output streams and run expectations on each individually. Reviewed by: des MFC after: 3 days Sponsored by: The FreeBSD Foundation

ping: fix listing test cases when scapy is not installed

2026-05-02T15:20:16Z

The ATF-python test program was attempting to list test cases that require scapy. But it attempted to import the scapy module before the test cases had been listed, resulting in an ImportError that kyua interpreted as a test program crash. Fix this behavior by handling that ImportError well enough to list test cases, but not run them. If scapy isn't present, Kyua will refuse to run the test cases. But it needs to be able to list them in order to know to skip them. Sponsored by: ConnectWise MFC after: 2 weeks Reviewed by: maxim Differential Revision: https://reviews.freebsd.org/D56765

ping tests: Run tests unprivileged inside a vnet

2024-11-05T03:07:32Z

In order to create vnet jails, atf_python needs root privileges. However, once the vnet is created, its privileges inside the vnet can be demoted, as these tests should not require root in order to pass. Reviewed by: markj Approved by: emaste (mentor) Fixes: 4efaf43c6fa7 ("ping: Require root user for pytests") MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D42175

ping tests: Silence deprecation warnings

2024-11-05T03:07:03Z

Declare some regex patterns as a raw string by prepending `r`. Reviewed by: markj Approved by: emaste (mentor) Differential Revision: https://reviews.freebsd.org/D42174

ping: tests: Align with Scapy defaults

2024-11-05T02:48:34Z

Align some of pinger() defaults with Scapy to facilitate debugging when printing packets. No functional change intended. Reviewed by: emaste, kp Approved by: emaste (mentor) Differential Revision: https://reviews.freebsd.org/D47159

ping: tests: Cleanup IPOption()s

2024-11-05T02:46:45Z

Scapy now only accepts known options with IPOption(), so our unknown option must be passed raw. While here, prefer the named options for EOL and NOP. Reviewed by: emaste, kp Approved by: emaste (mentor) Differential Revision: https://reviews.freebsd.org/D47160

ping tests: fix for scapy-2.6.0

2024-10-16T15:25:57Z

Scapy 2.6.0 now appears to parse the IPOption during construction, and it then gets confused at a single-byte option. IP Options typically contain at least a 1 byte type and 1 byte length. Avoid this by just returning the raw bytes, rather than an IPOption object. MFC after: 1 week Reviewed by: Jose Luis Duran Sponsored by: Rubicon Communications, LLC ("Netgate") Differential Revision: https://reviews.freebsd.org/D47151

ping tests: Fix test on i386 platforms

2023-10-19T13:35:39Z

Actually use INT_MAX (0x7fffffff), not UINT_MAX (0xffffffff) to avoid overflowing time_t and missing the test. Reported by: Jenkins Reviewed by: markj Fixes: 5b8af90fe332 ("ping: Add ATF-Python tests") Pull Request: https://github.com/freebsd/freebsd-src/pull/874 Differential Revision: https://reviews.freebsd.org/D42268