FreeBSD source tree https://cgit-dev.freebsd.org/src/atom?h=stable%2F13 2023-08-23T17:43:21Z 2023-08-23T17:43:21Z Warner Losh imp@FreeBSD.org 2023-08-22T01:31:07Z urn:sha1:17da660ad5b3b9cd90e164dd4dbb9beaa7203054 Remove /^\s*\*\n \*\s+\$FreeBSD\$$\n/ Similar commit in main: (cherry picked from commit b3e7694832e8) 2023-01-24T21:49:38Z Warner Losh imp@FreeBSD.org 2022-11-30T22:08:15Z urn:sha1:8189dec087b741744eeaccd697a50c3a6ad9e4b4 Change the first argument to disk_parsedev() to be a pointer to a struct devdesc *. This now gets filled in with a malloc'd structure that's returned to the caller that the caller is repsonsible for freeing. Most places in the tree passed in a malloc'd pointer anyway, and this moves knowledge of disk_devdesc more firmly into the disk.[ch] code. Sponsored by: Netflix Differential Revision: https://reviews.freebsd.org/D37335 (cherry picked from commit 17276525fa1a28028f7ca423f365d5081cbe9a97) 2023-01-24T21:49:37Z Warner Losh imp@FreeBSD.org 2022-11-04T21:28:26Z urn:sha1:75d454911f7d243b546835d55da5aba3c5b5520c enum disk_ioctl is unused. It's only ever defined. All of the stand code uses DIOCGSECTORSIZE and DIOCGMEDIASIZE instead, both to query and to implement ioctl. Sponsored by: Netflix (cherry picked from commit c9ee39a3f255b62cbf106f4e5a704bcefdef017b) 2023-01-24T21:49:30Z Warner Losh imp@FreeBSD.org 2022-08-11T15:04:50Z urn:sha1:9dee581ad98055d8e56186f990f9bef18c0376bf We do a number of games with ploymorphism for different types struct *devdesc. Adjust one place that this affects to take the address of the base class (most others have void * at the moment). This is more type safe than a bare void *. Sponsored by: Netflix Differential Revision: https://reviews.freebsd.org/D35914 (cherry picked from commit c32dde3166922f55927764464d13f1bc9640f5f6) 2019-03-24T18:51:52Z Ian Lepore ian@FreeBSD.org 2019-03-24T18:51:52Z urn:sha1:14243f8de746e756ad3466aa6920a80e39157d9c The values of the d_slice and d_partition fields of a disk_devdesc have a few values with special meanings in the disk_open() routine. Through various evolutions of the loader code over time, a d_partition value of -1 has meant both "use the first ufs partition found in the bsd label" and "don't open a bsd partition at all, open the raw slice." This defines a new special value of -2 to mean open the raw slice, and it gives symbolic names to all the special values used in d_slice and d_partition, and adjusts all existing uses of those fields to use the new constants. The phab review for this timed out without being accepted, but I'm still citing it below because there is useful commentary there. Differential Revision: https://reviews.freebsd.org/D19262 2018-06-05T22:13:45Z Ian Lepore ian@FreeBSD.org 2018-06-05T22:13:45Z urn:sha1:9f6fd8397c3834500c8c1faa73d4ff153eed1091 r330809 replaced duplication of devdesc struct fields with an embedded copy of the devdesc struct, to avoid fragility. That means all the scattered comments indicating that structs must match are no longer valid. Likewise asserts that attempted to mitigate some of the old fragility. Reviewed by: imp@ 2018-03-12T21:39:49Z Warner Losh imp@FreeBSD.org 2018-03-12T21:39:49Z urn:sha1:de04d704a98a7d2e9e57ebd83d2dd7a19fc11dab The current system is fragile and requires very careful layout of all *_devdesc structures. It also makes it hard to change the base devdesc. Take a page from CAM and put the 'header' in all the derived classes and adjust the code to match. For OFW, move the iHandle h_handle out of a slot conflicting with d_opendata. Due to quirks in the alignment rules, this worked. However changing the code to use d_opendata storage now that it's a pointer is hard, so just have a separate field for it. All other cleanups were to make the *_devdesc structures match where they'd taken some liberties that were none-the-less compatible enough to work. 2018-03-12T21:39:27Z Warner Losh imp@FreeBSD.org 2018-03-12T21:39:27Z urn:sha1:b3a2aad11e983db76c5266df3ae7c92cf349849e Make sure { on the same line as struct for all struct *devdesc. Move some type definitions to next to the dv_type define, since that's what sets the d_type. 2017-11-14T23:02:19Z Warner Losh imp@FreeBSD.org 2017-11-14T23:02:19Z urn:sha1:ca987d4641cdcd7f27e153db17c5bf064934faf5 Sponsored by: Netflix