src/stand/forth, branch releng/14.3

loader/4th: Move from hint.acpi.0.rsdp to acpi.rsdp

2024-12-28T18:13:19Z

Use acpi.rsdp to test for ACPI. 4th wasn't updated with the old compat was dropped a while ago. MFC After: 1 week Sponsored by: Netflix (cherry picked from commit 37798b1d5dd12cd5e842b6f99135a2e4af8cf9e0)

loader.4th dictthreshold too small

2024-04-16T19:54:30Z

The dictthreshold in stand/forth/loader.4th is too small resulting in full dictionary. Reviewed by: stevek, imp Sponsored by: Juniper Networks, Inc. Differential Revision: https://reviews.freebsd.org/D44414 (cherry picked from commit a8eb3b365eb63d2a569b166f2dfc982967d3a7fa)

stand: Retire setting hw.ata.wc: it doesn't exist.

2024-04-16T02:32:05Z

hw.ata.wc was disconnected as part ot the 2013 cam-ification of ata. No need to continue setting it. It's been unused in FreeBSD 10.x and newer. Sponsored by: Netflix (cherry picked from commit 67d2bd974d34d918255307321107273562f11dde)

stand: Retire setting hw.eisa_slots.

2024-04-16T02:32:05Z

When the eisa code was removed in 2017, prior to the stable/12 branch, setting hw.eisa_slots became a nop. The oldest supported branch doesn't have eisa at all. The need to set it manually on boot disappeared largely by 2000... Sponsored by: Netflix (cherry picked from commit 21795c374aceb685dbdb1bd18c7a5c41c3cf0baf)

Remove $FreeBSD$: one-line forth tag

2023-08-16T17:55:43Z

Remove /^\\[\s*]*\$FreeBSD\$.*$\n/

Remove $FreeBSD$: two-line nroff pattern

2023-08-16T17:55:10Z

Remove /^\.\\"\n\.\\"\s*\$FreeBSD\$$\n/

Remove $FreeBSD$: one-line sh pattern

2023-08-16T17:55:03Z

Remove /^\s*#[#!]?\s*\$FreeBSD\$.*$\n/

loader.4th(8): Fix a typo in the manual page

2022-04-02T13:11:59Z

- s/commmand/command/ MFC after: 3 days

loader: support.4th resets the read buffer incorrectly

2021-07-28T19:50:38Z

Large nextboot.conf files (over 80 bytes) are not read correctly by the Forth loader, causing file parsing to abort, and nextboot configuration fails to apply. Simple repro: nextboot -e foo=xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx shutdown -r now That will cause the bug to cause a parse failure but shouldn't otherwise affect the boot. Depending on your loader configuration, you may also have to set beastie_disable and/or reduce the number of modules loaded to see the error on a small console screen. 12.0 or CURRENT users will also have to explicitly use the Forth loader instead of the Lua loader. The error will look something like: Warning: syntax error on file /boot/loader.conf.local foo="xxxxxxxxxxxxxxnextboot_enable="YES" ^ /boot/support.4th has crude file I/O buffering, which uses a buffer 'read_buffer', defined to be 80 bytes by the 'read_buffer_size' constant. The loader first tastes nextboot.conf, reading and parsing the first line in it for nextboot_enable="YES". If this is true, then it reopens the file and parses it like other loader .conf files. Unfortunately, the file I/O buffering code does not fully reset the buffer state in the reset_line_reading word. If the last file was read to the end, that doesn't matter; the file buffer is treated as empty anyway. But in the nextboot.conf case, the loader will not read to the end of file if it is over 80 bytes, and the file buffer may be reused when reading the next file. When the file is reread, the corrupt text may cause file parsing to abort on bad syntax (if the corrupt line has <>2 quotes in it), the wrong variable to be set, no variable to be set at all, or (if the splice happens to land at a line ending) something approximating normal operation. The bug is very old, dating back to at least 2000 if not before, and is still present in 12.0 and CURRENT r345863 (though it is now hidden by the Lua loader by default). Suggested one-line attached. This does change the behavior of the reset_line_reading word, which is exported in the line-reading dictionary (though the export is not documented in loader man pages). But repo history shows it was probably exported for the PNP support code, which was never included in the loader build, and was removed 5 months ago. One thing that puzzles me: how has this bug gone unnoticed/unfixed for nearly 2 decades? I find it hard to believe that nobody's tried to do something interesting with nextboot, like load a kernel and filesystem, which is what I'm doing. Tested by: Gary Jennejohn PR: 239315 MFC After: 3 weeks Reviewed by: imp (and correctly applied this time) Differential Revision: https://reviews.freebsd.org/D31328

Revert "loader: support.4th resets the read buffer incorrectly"

2021-07-26T22:40:41Z

This reverts commit 9c1c02093b90ae49745a174eb26ea85dd1990eec. It seems to have broken all old nextboot.conf files causing hangs on boot. Sponsored by: Netflix