FreeBSD source tree https://cgit-dev.freebsd.org/src/atom?h=main 2015-07-19T22:14:09Z 2015-07-19T22:14:09Z Mark Johnston markj@FreeBSD.org 2015-07-19T22:14:09Z urn:sha1:32cd0147fafec2d3d2817d733fa70bad9cdf34ce in lockstat.ko. This means that lockstat probes now have typed arguments and will utilize SDT probe hot-patching support when it arrives. Reviewed by: gnn Differential Revision: https://reviews.freebsd.org/D2993 2015-07-18T00:22:00Z Mark Johnston markj@FreeBSD.org 2015-07-18T00:22:00Z urn:sha1:efe8b26b82a7fc541e2f6a112ce34bf7a3d84973 enabled. The cost of a timecounter read can be quite significant, and the problem became more apparent after r284297, since that change resulted in a call to lockstat_nsecs() for each acquisition of an rwlock read lock. PR: 201642 Reviewed by: avg Tested by: Jason Unovitch MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D3073 2015-07-01T15:51:11Z Ruslan Bukin br@FreeBSD.org 2015-07-01T15:51:11Z urn:sha1:b78ee15e9f04ae15c3e1200df974473167524d17 Reviewed by: andrew, emaste Sponsored by: ARM Limited Differential Revision: https://reviews.freebsd.org/D2738 2015-02-10T19:41:30Z George V. Neville-Neil gnn@FreeBSD.org 2015-02-10T19:41:30Z urn:sha1:fcb560670601b2a4d87bb31d7531c8dcc37ee71b Submitted by: Howard Su based on work by Oleksandr Tymoshenko Reviewed by: ian, andrew, rpaulo, markj 2013-11-25T07:38:45Z Attilio Rao attilio@FreeBSD.org 2013-11-25T07:38:45Z urn:sha1:54366c0bd7d0ea904fb9ab32460c66d57684a7cb option, unbreak the lock tracing release semantic by embedding calls to LOCKSTAT_PROFILE_RELEASE_LOCK() direclty in the inlined version of the releasing functions for mutex, rwlock and sxlock. Failing to do so skips the lockstat_probe_func invokation for unlocking. - As part of the LOCKSTAT support is inlined in mutex operation, for kernel compiled without lock debugging options, potentially every consumer must be compiled including opt_kdtrace.h. Fix this by moving KDTRACE_HOOKS into opt_global.h and remove the dependency by opt_kdtrace.h for all files, as now only KDTRACE_FRAMES is linked there and it is only used as a compile-time stub [0]. [0] immediately shows some new bug as DTRACE-derived support for debug in sfxge is broken and it was never really tested. As it was not including correctly opt_kdtrace.h before it was never enabled so it was kept broken for a while. Fix this by using a protection stub, leaving sfxge driver authors the responsibility for fixing it appropriately [1]. Sponsored by: EMC / Isilon storage division Discussed with: rstone [0] Reported by: rstone [1] Discussed with: philip 2012-11-07T23:45:09Z Justin Hibbits jhibbits@FreeBSD.org 2012-11-07T23:45:09Z urn:sha1:c757049235edc6ecca32c6c584f7d5582aaeb74a There is one known issue: Some probes will display an error message along the lines of: "Invalid address (0)" I tested this with both a simple dtrace probe and dtruss on a few different binaries on 32-bit. I only compiled 64-bit, did not run it, but I don't expect problems without the modules loaded. Volunteers are welcome. MFC after: 1 month 2012-03-24T05:14:37Z Oleksandr Tymoshenko gonzo@FreeBSD.org 2012-03-24T05:14:37Z urn:sha1:c57e9d4e83c7d11dceed8dfd6ad682b723e0fca1 2009-05-26T20:28:22Z Stacey Son sson@FreeBSD.org 2009-05-26T20:28:22Z urn:sha1:a5aedd68b4eb5bb0cafdc51eb8f325c32543ad9a adds probes for mutexes, reader/writer and shared/exclusive locks to gather contention statistics and other locking information for dtrace scripts, the lockstat(1M) command and other potential consumers. Reviewed by: attilio jhb jb Approved by: gnn (mentor)