FreeBSD source tree https://cgit-dev.freebsd.org/src/atom?h=release%2F13.2.0 2023-02-06T19:34:37Z 2023-02-06T19:34:37Z Mitchell Horne mhorne@FreeBSD.org 2023-01-07T18:09:28Z urn:sha1:f0e49ab720d3bc71f82dc1e73db4047f3a03defb This conditionally gives all registered shutdown handlers a chance to perform the reboot, with cpu_reset() being the fallback. The '\s' modifier can be used with the command to get the previous behaviour. The motivation is that some platforms may not be able do anything meaningful via cpu_reset(), due to a lack of standardized reset mechanism and/or firmware shortcomings. However, they may have a separate device driver attached that normally performs the reboot. Such is the case for some versions of the Raspberry Pi, where reset via PSCI fails, but the BCM2835 watchdog driver has a shutdown hook. Reported by: bz Reviewed by: markj (slightly earlier version) MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D37981 (cherry picked from commit 5644850620aead7c257a4e3040e20201b510f499) 2022-11-06T14:54:46Z Mitchell Horne mhorne@FreeBSD.org 2022-10-28T21:20:05Z urn:sha1:3e00f4ab107d68d5f7782c8bdeeead41cb06b38b Some architectures will pretty-print a system call trap in the backtrace. Rather than printing the symbol, use the syscallname() function to pull the string from the sv_syscallnames array corresponding to the process. This simplifies the function somewhat. Mostly, this will result in dropping the "sys" prefix, e.g. "sys_exit" will now be printed simply as "exit". Make two minor tweaks to the function signature: use a u_int for the syscall number since this is a more correct type (see the 'code' member of struct syscall_args), and make the thread pointer the first argument. The latter is more natural and conventional. Suggested by: jrtc27 Reviewed by: jrtc27, markj, jhb MFC after: 1 week Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D37200 (cherry picked from commit aba921bd9e1869dae9ae4cc6e0c048f997401034) 2022-11-06T14:54:46Z Mitchell Horne mhorne@FreeBSD.org 2022-10-02T22:46:00Z urn:sha1:a4dd26ead25db6d5aa07938ccb83413172c9cf2b Only i386 and amd64 print the decoded syscall name in the backtrace. This de-duplication facilitates further changes and adoption by other platforms. Reviewed by: jrtc27, markj, jhb MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D36565 (cherry picked from commit 754cb545b68ba0a1643792763d000018ffe2afec) (cherry picked from commit 6f8a182b15c4c14cfb9462b806a928ddaf47c87e) (cherry picked from commit 89e5ef8917af900558c2d275f5d5c4c703520ead) (cherry picked from commit 85b715baae22ca12f2d24e1b2980f3d5b32937b8) 2022-08-11T14:22:57Z Mitchell Horne mhorne@FreeBSD.org 2022-06-30T15:58:22Z urn:sha1:53021bbf8255f57a422f9874a108d4a679b180a2 Provide _FLAGS variants of the various command definition macros, in anticipation of adding a new flag. This can also be used for some existing commands which require special flag values. Reviewed by: markj MFC after: 3 days Sponsored by: Juniper Networks, Inc. Sponsored by: Klara, Inc. Differential Revision: https://reviews.freebsd.org/D35581 (cherry picked from commit 7ce58d4e8c0cfcb42ec404aed6185b5eb7eef8a8) 2022-08-11T14:22:26Z Mitchell Horne mhorne@FreeBSD.org 2022-07-05T14:45:47Z urn:sha1:742622502ec0f29e0bea4ee36cefd18fae144a58 Provide separate helper macros for regular commands and next-level table commands as they are mutually exclusive. This ensures proper initialization of each element and allows us to exclude some redundant fields, such as specifying .more = NULL for every regular command. Reviewed by: markj, jhb MFC after: 3 days Sponsored by: Juniper Networks, Inc. Sponsored by: Klara, Inc. Differential Revision: https://reviews.freebsd.org/D35580 (cherry picked from commit 8a0994823365740f4d92842c2d6f7f524310ba64) 2022-08-11T14:22:26Z Mitchell Horne mhorne@FreeBSD.org 2022-07-05T14:44:36Z urn:sha1:e4f615b3e0f564df1dee5b8bc6cd40259bd4c156 Reviewed by: jhb MFC after: 3 days Sponsored by: Juniper Networks, Inc. Sponsored by: Klara, Inc. Differential Revision: https://reviews.freebsd.org/D35368 (cherry picked from commit 4f2ad6243f15ef325aa8daa680949b0ee1076c6e) 2022-07-23T08:56:44Z Dimitry Andric dim@FreeBSD.org 2022-07-19T18:31:08Z urn:sha1:08c55de237ed0067781981ef4704480938186104 With clang 15, the following -Werror warnings is produced: sys/ddb/db_lex.c:94:14: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes] db_flush_line() ^ void This is because db_flush_line() is declared with a (void) argument list, but defined with an empty argument list. Make the definition match the declaration. MFC after: 3 days (cherry picked from commit 939cb349b2ca4d3fcdc72ab1258eadee5e54881c) 2022-06-27T19:32:06Z Mitchell Horne mhorne@FreeBSD.org 2022-05-13T13:40:05Z urn:sha1:5a96b88f05d1b16637dc6bd7a387f601981ff593 It is unused, especially now that the underlying d_dumper methods do not accept the argument. Reviewed by: markj MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D35174 (cherry picked from commit db71383b8836a586051b25c20992066d153c6941) 2022-06-23T22:19:48Z Mitchell Horne mhorne@FreeBSD.org 2022-06-14T16:09:11Z urn:sha1:70bb14b902ffef656a9497acb5f5073b47c25bed 'command' is too generic for something specific to the kernel debugger; change this so it is less likely to collide with local variable names. Also rename struct command_table to struct db_command_table. Reviewed by: markj MFC after: 1 week Sponsored by: Juniper Networks, Inc. Sponsored by: Klara, Inc. Differential Revision: https://reviews.freebsd.org/D35367 (cherry picked from commit 4ef7db5a7e5c06cd8788e6f653ee955ace44b6c9) 2022-05-12T22:12:59Z Andrew Turner andrew@FreeBSD.org 2021-08-27T09:38:40Z urn:sha1:e5e2c7ffa0f7d9ba0874b95924f4d977b116f45b Move the common kernel function signatures from machine/reg.h to a new sys/reg.h. This is in preperation for adding PT_GETREGSET to ptrace(2). Reviewed by: imp, markj Sponsored by: DARPA, AFRL (original work) Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D19830 (cherry picked from commit b792434150d66b9b2356fb9a7548f4c7f0a0f16c)