FreeBSD source tree https://cgit-dev.freebsd.org/src/atom?h=release%2F10.1.0 2014-04-14T04:58:50Z 2014-04-14T04:58:50Z Pyun YongHyeon yongari@FreeBSD.org 2014-04-14T04:58:50Z urn:sha1:b6d85020eebf5a4930469239f8d2521af6d7d53e Failed m_devget(9) indicates lack of free mbuf cluster. Update if_iqdrops counter for that case since the received frame is ok. While here, simplify updating counter logic. 2013-07-17T01:34:25Z Pyun YongHyeon yongari@FreeBSD.org 2013-07-17T01:34:25Z urn:sha1:fcb1bf41530e241c43310e48d4c8320c083da698 No functional change. 2013-07-17T01:24:23Z Pyun YongHyeon yongari@FreeBSD.org 2013-07-17T01:24:23Z urn:sha1:b9a17c6ce4dc2cd4860ca4990edb40effe0824a9 constraint to 8. Previously it may have triggered watchdog timeouts. o Check whether interrupt is ours or not. o Enable interrupts before attemping to transmit queued packets. This will slightly improve TX performance. o No need to clear IFF_DRV_OACTIVE in a loop. AE_FLAG_TXAVAIL is used to know whether there are enough available TxD ring space. o Added missing bus_dmamap_sync(9) in ae_rx_intr() and rearranged code to avoid unncessary register access. o Make sure to clear TxD, TxS, RxD rings in driver initialization. Otherwise some data in these rings could be interpreted as 'updated' which in turn will advance internally maintained pointers and can trigger watchdog timeouts. PR: kern/180382 2012-06-06T09:07:50Z Sergey Kandaurov pluknet@FreeBSD.org 2012-06-06T09:07:50Z urn:sha1:4fb52be9c28e2c209287534c045874130cef302e 2012-06-06T02:42:30Z Kevin Lo kevlo@FreeBSD.org 2012-06-06T02:42:30Z urn:sha1:858f9d27f06a5366e0455698f6458e37d7e0cd78 2011-11-11T19:15:32Z Pyun YongHyeon yongari@FreeBSD.org 2011-11-11T19:15:32Z urn:sha1:e18783345a3e7ad070f37a418434d85c6fbbcb93 the length of frame should be treated as multiple of 4. Actual frame length is set in the TX header. The TX header position should be aligned on 4 byte boundary and actual frame start position should be aligned on 4 byte boundary as well. This means we need 4(TX header length) + 3(frame length fixup) additional free space in TX buffer in addition to actual frame length. Make sure TX handler check these additional bytes. ae_tx_avail_size() returns actual free space in TX buffer to ease the calculation of available TX buffer space in caller. While I'm here, replace magic number to appropriate sizeof operator to enhance readability. This change should fix controller lockup issue happened under certain conditions but it still does not fix watchdog timeout. It seems the watchdog timeout is side-effect of TxS and TxD mismatches. The root cause of TxD/TxD mismatch is not known yet but it looks like silicon bug. I guess driver may have to reinitialize controller whenever it sees TxS and TxD mismatches but leave it as it was at this moment. PR: kern/145918 2011-05-03T19:51:29Z Marius Strobl marius@FreeBSD.org 2011-05-03T19:51:29Z urn:sha1:3fcb7a5365f9de7824a2b5f8e8ab159c8d3d79a0 (reporting IFM_LOOP based on BMCR_LOOP is left in place though as it might provide useful for debugging). For most mii(4) drivers it was unclear whether the PHYs driven by them actually support loopback or not. Moreover, typically loopback mode also needs to be activated on the MAC, which none of the Ethernet drivers using mii(4) implements. Given that loopback media has no real use (and obviously hardly had a chance to actually work) besides for driver development (which just loopback mode should be sufficient for though, i.e one doesn't necessary need support for loopback media) support for it is just dropped as both NetBSD and OpenBSD already did quite some time ago. - Let mii_phy_add_media() also announce the support of IFM_NONE. - Restructure the PHY entry points to use a structure of entry points instead of discrete function pointers, and extend this to include a "reset" entry point. Make sure any PHY-specific reset routine is always used, and provide one for lxtphy(4) which disables MII interrupts (as is done for a few other PHYs we have drivers for). This includes changing NIC drivers which previously just called the generic mii_phy_reset() to now actually call the PHY-specific reset routine, which might be crucial in some cases. While at it, the redundant checks in these NIC drivers for mii->mii_instance not being zero before calling the reset routines were removed because as soon as one PHY driver attaches mii->mii_instance is incremented and we hardly can end up in their media change callbacks etc if no PHY driver has attached as mii_attach() would have failed in that case and not attach a miibus(4) instance. Consequently, NIC drivers now no longer should call mii_phy_reset() directly, so it was removed from EXPORT_SYMS. - Add a mii_phy_dev_attach() as a companion helper to mii_phy_dev_probe(). The purpose of that function is to perform the common steps to attach a PHY driver instance and to hook it up to the miibus(4) instance and to optionally also handle the probing, addition and initialization of the supported media. So all a PHY driver without any special requirements has to do in its bus attach method is to call mii_phy_dev_attach() along with PHY-specific MIIF_* flags, a pointer to its PHY functions and the add_media set to one. All PHY drivers were updated to take advantage of mii_phy_dev_attach() as appropriate. Along with these changes the capability mask was added to the mii_softc structure so PHY drivers taking advantage of mii_phy_dev_attach() but still handling media on their own do not need to fiddle with the MII attach arguments anyway. - Keep track of the PHY offset in the mii_softc structure. This is done for compatibility with NetBSD/OpenBSD. - Keep track of the PHY's OUI, model and revision in the mii_softc structure. Several PHY drivers require this information also after attaching and previously had to wrap their own softc around mii_softc. NetBSD/OpenBSD also keep track of the model and revision on their mii_softc structure. All PHY drivers were updated to take advantage as appropriate. - Convert the mebers of the MII data structure to unsigned where appropriate. This is partly inspired by NetBSD/OpenBSD. - According to IEEE 802.3-2002 the bits actually have to be reversed when mapping an OUI to the MII ID registers. All PHY drivers and miidevs where changed as necessary. Actually this now again allows to largely share miidevs with NetBSD, which fixed this problem already 9 years ago. Consequently miidevs was synced as far as possible. - Add MIIF_NOMANPAUSE and mii_phy_flowstatus() calls to drivers that weren't explicitly converted to support flow control before. It's unclear whether flow control actually works with these but typically it should and their net behavior should be more correct with these changes in place than without if the MAC driver sets MIIF_DOPAUSE. Obtained from: NetBSD (partially) Reviewed by: yongari (earlier version), silence on arch@ and net@ 2011-03-23T13:10:15Z John Baldwin jhb@FreeBSD.org 2011-03-23T13:10:15Z urn:sha1:3b0a4aef967e33d85308e74b00c472820e173c7a pci_find_cap() instead. 2011-01-12T19:53:56Z Matthew D Fleming mdf@FreeBSD.org 2011-01-12T19:53:56Z urn:sha1:6dc7dc9a3ece89691444e906783892ccaa77a192 Commit the rest of the devices. 2011-01-03T18:28:30Z John Baldwin jhb@FreeBSD.org 2011-01-03T18:28:30Z urn:sha1:32341ad63cacae167f86f1ce627384608d04b6d3 from interrupt handlers and watchdog routines instead of queueing a task to call foo_start(). Reviewed by: yongari MFC after: 1 month