FreeBSD source tree https://cgit-dev.freebsd.org/src/atom?h=release%2F12.3.0 2019-03-23T23:43:33Z 2019-03-23T23:43:33Z Oleksandr Tymoshenko gonzo@FreeBSD.org 2019-03-23T23:43:33Z urn:sha1:6e7984cf48a12a46592d378ef3e1d22e1cc13327 Fix off-by-one error in BERI virtio driver The hardcoded ident is exactly 20 bytes long but sprintf adds terminating zero, so there is one byte written out of array bounds.As a fix use strncpy it appends \0 only if space allows and its behavior matches virtio spec: When VIRTIO_BLK_T_GET_ID is issued, the device identifier, up to 20 bytes, is written to the buffer. The identifier should be interpreted as an ascii string. It is terminated with \0, unless it is exactly 20 bytes long. PR: 202298 Reviewed by: br Differential Revision: https://reviews.freebsd.org/D18852 2018-01-21T15:42:36Z Pedro F. Giffuni pfg@FreeBSD.org 2018-01-21T15:42:36Z urn:sha1:ac2fffa4b74cd83963f0d462c379c7f50eeabf20 Uses of mallocarray(9). The use of mallocarray(9) has rocketed the required swap to build FreeBSD. This is likely caused by the allocation size attributes which put extra pressure on the compiler. Given that most of these checks are superfluous we have to choose better where to use mallocarray(9). We still have more uses of mallocarray(9) but hopefully this is enough to bring swap usage to a reasonable level. Reported by: wosch PR: 225197 2018-01-13T22:30:30Z Pedro F. Giffuni pfg@FreeBSD.org 2018-01-13T22:30:30Z urn:sha1:26c1d774b55c4db79bca772941883244986e6f44 Focus on code where we are doing multiplications within malloc(9). None of these is likely to overflow, however the change is still useful as some static checkers can benefit from the allocation attributes we use for mallocarray. This initial sweep only covers malloc(9) calls with M_NOWAIT. No good reason but I started doing the changes before r327796 and at that time it was convenient to make sure the sorrounding code could handle NULL values. 2017-02-20T03:43:12Z Pedro F. Giffuni pfg@FreeBSD.org 2017-02-20T03:43:12Z urn:sha1:4d24901ac9131267fd188c5e1ee19a219847238a Makes things easier to read, plus architectures may set NULL to something different than zero. Found with: devel/coccinelle MFC after: 3 weeks 2015-07-03T14:27:28Z Ruslan Bukin br@FreeBSD.org 2015-07-03T14:27:28Z urn:sha1:4934834d6bc1ed05e246daa216cd169ddc60ff0e We will use it with Bluespec simulator of CHERI processor for invalidating caches only. 2015-01-05T16:43:22Z Ruslan Bukin br@FreeBSD.org 2015-01-05T16:43:22Z urn:sha1:1aac28e753967c1154100cd3d344deaf89d038f7 o Operate with copy of iov as we expect later it was not modified 2015-01-04T23:14:04Z Ruslan Bukin br@FreeBSD.org 2015-01-04T23:14:04Z urn:sha1:2499610b9add5038e21e1f69d42e60f739f8823c PIO is a device implemented in soft-core and becomes available after flashing FPGA only. 2014-12-29T00:35:44Z Bryan Venteicher bryanv@FreeBSD.org 2014-12-29T00:35:44Z urn:sha1:f83577167c89aff02b68c7c9022006cb45a30df1 This header file contains prototypes and defines that only make sense to the guest VirtIO device drivers. Reviewed by: br 2014-12-21T21:24:19Z Ian Lepore ian@FreeBSD.org 2014-12-21T21:24:19Z urn:sha1:734ba86366e6617f3fd62b5a5f1c9edde7093b1d 2014-12-12T11:19:10Z Ruslan Bukin br@FreeBSD.org 2014-12-12T11:19:10Z urn:sha1:156b97fa1f4366966b8cb50be6e720a58e50e959 going to poll virtqueue. Use on BERI soft-core to invalidate cpu caches. Reviewed by: bryanv Sponsored by: DARPA, AFRL