FreeBSD source tree https://cgit-dev.freebsd.org/src/atom?h=releng%2F12.4 2018-01-29T00:14:46Z 2018-01-29T00:14:46Z Warner Losh imp@FreeBSD.org 2018-01-29T00:14:46Z urn:sha1:2ced565834bf1df11d08fe7b5618aa1ca01adf08 Differential Revision: https://reviews.freebsd.org/D13818 2017-11-27T14:52:40Z Pedro F. Giffuni pfg@FreeBSD.org 2017-11-27T14:52:40Z urn:sha1:718cf2ccb9956613756ab15d7a0e28f2c8e91cab Mainly focus on files that use BSD 2-Clause license, however the tool I was using misidentified many licenses so this was mostly a manual - error prone - task. The Software Package Data Exchange (SPDX) group provides a specification to make it easier for automated tools to detect and summarize well known opensource licenses. We are gradually adopting the specification, noting that the tags are considered only advisory and do not, in any way, superceed or replace the license texts. 2017-02-20T03:43:12Z Pedro F. Giffuni pfg@FreeBSD.org 2017-02-20T03:43:12Z urn:sha1:4d24901ac9131267fd188c5e1ee19a219847238a Makes things easier to read, plus architectures may set NULL to something different than zero. Found with: devel/coccinelle MFC after: 3 weeks 2017-02-19T17:27:58Z Alexander Motin mav@FreeBSD.org 2017-02-19T17:27:58Z urn:sha1:950c5aca4ac28e845fc8f5077f21451dbe9fabb4 This makes grepping kernel for target mode implementation much easier. 2017-02-16T21:57:25Z Warner Losh imp@FreeBSD.org 2017-02-16T21:57:25Z urn:sha1:792c00971aed1fe91e2885802a1a07fced74a4d2 man page. Tweak comments to not refer to EISA scenarios now that it is no longer supported. Remove unused enum. 2017-02-15T23:04:25Z Warner Losh imp@FreeBSD.org 2017-02-15T23:04:25Z urn:sha1:5625fe92467ac884efd681949d304d5d7663b6d7 machines, only a few 486 machines that used it, and those haven't had enough memory to run FreeBSD for quite some time (often limited to 16MB). Not to be confused with the Machine Check Architecture, which is still very much alive and used (and untouched by this commit). No Objection From: arch@ 2017-01-04T20:26:42Z Alan Somers asomers@FreeBSD.org 2017-01-04T20:26:42Z urn:sha1:4195c7de2471d6212744bcbf128d659e94801d17 The sim_vid, hba_vid, and dev_name fields of struct ccb_pathinq are fixed-length strings. AFAICT the only place they're read is in sbin/camcontrol/camcontrol.c, which assumes they'll be null-terminated. However, the kernel doesn't null-terminate them. A bunch of copy-pasted code uses strncpy to write them, and doesn't guarantee null-termination. For at least 4 drivers (mpr, mps, ciss, and hyperv), the hba_vid field actually overflows. You can see the result by doing "camcontrol negotiate da0 -v". This change null-terminates those fields everywhere they're set in the kernel. It also shortens a few strings to ensure they'll fit within the 16-character field. PR: 215474 Reported by: Coverity CID: 1009997 1010000 1010001 1010002 1010003 1010004 1010005 CID: 1331519 1010006 1215097 1010007 1288967 1010008 1306000 CID: 1211924 1010009 1010010 1010011 1010012 1010013 1010014 CID: 1147190 1010017 1010016 1010018 1216435 1010020 1010021 CID: 1010022 1009666 1018185 1010023 1010025 1010026 1010027 CID: 1010028 1010029 1010030 1010031 1010033 1018186 1018187 CID: 1010035 1010036 1010042 1010041 1010040 1010039 Reviewed by: imp, sephe, slm MFC after: 4 weeks Sponsored by: Spectra Logic Corp Differential Revision: https://reviews.freebsd.org/D9037 Differential Revision: https://reviews.freebsd.org/D9038 2016-05-04T06:24:10Z Adrian Chadd adrian@FreeBSD.org 2016-05-04T06:24:10Z urn:sha1:d19677ddd7c8a9ce7f9858c558e177863cfb5b66 Submitted by: kmacy 2016-05-03T03:41:25Z Pedro F. Giffuni pfg@FreeBSD.org 2016-05-03T03:41:25Z urn:sha1:453130d9bfc1c6d68b366dfcb041689d69f81295 Most affect comments, very few have user-visible effects. 2015-03-22T16:10:28Z Alexander Motin mav@FreeBSD.org 2015-03-22T16:10:28Z urn:sha1:6f954fb36b28550c58678125b289ae80ea4d7089 In some cases limits are just not needed, in others -- DFLTPHYS is the right constant to use instead. MFC after: 1 month