src/sys/dev/e1000, branch release/12.3.0

e1000: print EEPROM/NVM/OROM versions

2021-10-13T02:16:04Z

This is useful for diagnosing problems. In particular, the errata sheets identify the EEPROM version for many fixes. Reviewed by: gallatin MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D32333 (cherry picked from commit 293663f4da9e8b8aeb106ce3b73a8ed2aa2a8a90)

e1000: Lock nvm print sysctl

2021-10-13T02:12:21Z

Otherwise results in KASSERT with debug kernels because we rely on the iflib CTX lock to implement the software serialization to the NVM model Reviewed by: gallatin MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D32333 (cherry picked from commit 9b3e252e59c6e63594fb20e3f65188dab9e1eeff)

e1000: Function prototype cleanup

2021-10-09T01:03:54Z

Drop arguments of function prototypes since the file is mixed between listing arg names and not. No functional changes Reviewed by: markj MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D32329 (cherry picked from commit 28ccd780a96fe49364072955636829cff1589cfb)

iflib: Make if_shared_ctx_t a pointer to const

2021-10-03T01:55:49Z

This structure is shared among multiple instances of a driver, so we should ensure that it doesn't somehow get treated as if there's a separate instance per interface. This is especially important for software-only drivers like wg. DEVICE_REGISTER() still returns a void * and so the per-driver sctx structures are not yet defined with the const qualifier. Reviewed by: gallatin, erj MFC after: 2 weeks Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D29102 (cherry picked from commit ffe3def903a5f239c319e5fe12450659658974a5)

e1000: fix K1 configuration

2021-09-30T00:23:56Z

This patch is for the following updates to the K1 configurations: Tx idle period for entering K1 should be 128 ns. Minimum Tx idle period in K1 should be 256 ns. Signed-off-by: Wenzhuo Lu PR: 258153 Reviewed by: erj Tested by: iron.udjin@gmail.com Approved by: imp Obtained from: DPDK (6f934fa24dfd437c90ead96bc7598ee77a117ede) MFC after: 1 week (cherry picked from commit d5ad2f2a67df54ac40148cca21e726bc61a48982)

e1000: Re-arm link changes

2021-09-28T17:28:54Z

A change to MSI-X link handler was somehow causing issues on MSI-based em(4) NICs. Revert the change based on user reports and testing. PR: 258551 Reported by: Franco Fichtner , t_uemura@macome.co.jp Reviewed by: markj, Franco Fichtner Tested by: t_uemura@macome.co.jp MFC after: 1 day (cherry picked from commit 450c3f8b3d259c7eb82488319aff45f1f6554aaf)

e1000: Fix tabstop width in if_em.h

2021-09-28T17:28:28Z

Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D32145 (cherry picked from commit 21ab8c75c940dd15343b4af28b18a66f377e670a)

e1000: Rename 'struct adapter' to 'struct e1000_sc'

2021-09-28T17:26:13Z

Rename the 'struct adapter' to 'struct e1000_sc' to avoid type ambiguity in things like kgdb. Reviewed by: jhb, markj MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D32129 (cherry picked from commit dc9260515449cde9a4b26b5448f7386388c55bbd)

iflib: Free resources in a consistent order during detach

2021-09-28T17:21:52Z

Memory and PCI resources are freed with no particular order. This could cause use-after-frees when detaching following a failed attach. For instance, iflib_tx_structures_free() frees ctx->ifc_txqs[] but iflib_tqg_detach() attempts to access this array. Similarly, adapter queues gets freed by IFDI_QUEUES_FREE() but IFDI_DETACH() attempts to access adapter queues to free PCI resources. MFC after: 2 weeks Sponsored by: NetApp, Inc. Differential Revision: https://reviews.freebsd.org/D27634 (cherry picked from commit 38bfc6dee33bedb290e1ea2540f97a86fe3caee0)

e1000: Consistently use FALLTHROUGH

2021-09-28T17:07:34Z

Approved by: imp MFC after: 1 week (cherry picked from commit e05d9788b7e90ffd6405dc59656b52a63ba7ff3e)