FreeBSD source tree https://cgit-dev.freebsd.org/src/atom?h=releng%2F12.2 2020-09-23T23:56:49Z 2020-09-23T23:56:49Z Eric Joyner erj@FreeBSD.org 2020-09-23T23:56:49Z urn:sha1:97f844cd60ddb0b56fa4ed0977620fd0cd7e15b0 Contains fixes for issues in em(4)/igb(4): - Fix define and includes with RSS option enabled - Properly retain promisc flag in init PR: 249191, 248869 Approved by: re (gjb@) 2020-08-27T19:12:39Z Vincenzo Maffione vmaffione@FreeBSD.org 2020-08-27T19:12:39Z urn:sha1:d54d569052f9cb610593ee2c536a73cc518085ff em(4): honor vlanhwtag offload The FreeBSD em driver fails to properly reset the VME flag in the e1000 CTRL register oneg the following ifconfig command ifconfig em1 -vlanhwtag Tested on the e1000 device emulated by QEMU, and on a real NIC (chip=0x10d38086). PR: 236584 Submitted by: murat@sunnyvalley.io Reported by: murat@sunnyvalley.io Differential Revision: https://reviews.freebsd.org/D25286 2020-07-30T18:31:25Z Eric Joyner erj@FreeBSD.org 2020-07-30T18:31:25Z urn:sha1:452a7e4b4e4892460e7fd89e08f15667cd582c6e PR: 240818 Sponsored by: Intel Corporation 2020-06-12T00:42:05Z Eric Joyner erj@FreeBSD.org 2020-06-12T00:42:05Z urn:sha1:d0650dcead762d324e9826ba71d5f91d1935611c This change introduces Comet Lake Mobile Platform support in the e1000 driver along with shared code patches described below. - Cast return value of e1000_ltr2ns() to higher type to avoid overflow - Remove useless statement of assigning act_offset - Add initialization of identification LED - Fix flow control setup after connected standby: After connected standby the driver blocks resets during "AdapterStart" and skips flow control setup. This change adds condition in e1000_setup_link_ich8lan() to always setup flow control and to setup physical interface only when there is no need to block resets. Sponsored by: Intel Corporation 2020-05-14T19:56:54Z Eric Joyner erj@FreeBSD.org 2020-05-14T19:56:54Z urn:sha1:098959689147cbadf167971a6e6ebc822267024a These commits introduce a new iflib device-dependent method and implements that method in the Intel ethernet network drivers; this method tells iflib if the network interface needs to be restarted when certain events happen. This fixes several issues that occur when VLANs are registered or unregistered with the network interface. PR: 240818, 241785 Sponsored by: Intel Corporation 2020-02-04T03:31:28Z George V. Neville-Neil gnn@FreeBSD.org 2020-02-04T03:31:28Z urn:sha1:03746bf0ae7883be9450abd549010f5a74392d1c Add support for latest Intel I219 device, supported in Lenovo Carbon X1 v7 2020-01-02T22:57:21Z Eric Joyner erj@FreeBSD.org 2020-01-02T22:57:21Z urn:sha1:84945cafdd94d30c78c0e5aa21ca6c2f67eedf5a This MFC includes: r353656, r353657, r353658, and r353661 Sponsored by: Intel Corporation 2019-10-24T14:18:06Z Marius Strobl marius@FreeBSD.org 2019-10-24T14:18:06Z urn:sha1:53cf20ed8a8f83dd880b193fe1328722554a82f2 - In em_intr(), just call em_handle_link() instead of duplicating it. - In em_msix_link(), properly handle IGB-class devices after the iflib(4) conversion again by only setting EM_MSIX_LINK for the EM-class 82574 and by re-arming link interrupts unconditionally, i. e. not only in case of spurious interrupts. This fixes the interface link state change detection for the IGB-class. [1] - In em_if_update_admin_status(), only re-arm the link state change interrupt for 82574 and also only if such a device uses MSI-X, i. e. takes advantage of autoclearing. In case of INTx and MSI as well as for LEM- and IGB-class devices, re-arming isn't appropriate here and setting EM_MSIX_LINK isn't either. While at it, consistently take advantage of the hw variable. PR: 236724 [1] Differential Revision: https://reviews.freebsd.org/D21924 2019-06-16T15:30:07Z Marius Strobl marius@FreeBSD.org 2019-06-16T15:30:07Z urn:sha1:0b0b006f8e9ccd5d06a1a9274a606a2d6b19812f o Avoid determining the MAC class (LEM/EM or IGB) - possibly even multiple times - on every interrupt by using an own set of device methods for the IGB class. This translates to introducing igb_if_intr_{disable,enable}() and igb_if_{rx,tx}_queue_intr_enable() with that IGB-specific code moved out of their EM counterparts and otherwise continuing to use the EM IFDI methods also for IGB. Note that igb_if_intr_{disable,enable}() also issue E1000_WRITE_FLUSH as lost with the conversion of igb(4) to iflib(4). Also note, that the em_if_{disable,enable}_intr() methods are renamed to em_if_intr_{disable,enable}() for consistency with the names used in the interface declaration. o In em_intr(): - Don't bother to bail out if the interrupt type is "legacy", i. e. INTx or MSI, as iflib(4) doesn't use ift_legacy_intr methods for MSI-X. All other iflib(4)-based drivers avoid this check, too. - Given that only the MSI-X interrupts have one-shot behavior (by taking advantage of the EIAC register), explicitly disable interrupts. Hence, em_intr() now matches what {em,igb}_irq_fast() previously did (in case of igb(4) supposedly also to work around MSI message reordering errata on certain systems). o In em_if_intr_disable(): - Clear the EIAC register unconditionally for 82574 and not just in case of MSI-X, matching em_if_intr_enable() and bringing back the last hunk of r206437 lost with the iflib(4) conversion. - Write to EM_EIAC for clearing said register instead of to the IGB-only E1000_EIAC used ever since the iflib(4) conversion. Reviewed by: shurd Differential Revision: https://reviews.freebsd.org/D20176 2019-04-17T23:02:37Z Eric Joyner erj@FreeBSD.org 2019-04-17T23:02:37Z urn:sha1:cb517a6207e178bc938b3b712d8ee46f76c05eba Includes: - iflib: prevent possible infinite loop in iflib_encap - iflib: expose the Rx mbuf buffer size to drivers - iflib: hold the CTX lock in iflib_pseudo_register - iflib: return ENETDOWN when the network device is down