src/sys/dev/ena, branch releng/12.4

ena: Update driver version to v2.6.1

2022-07-26T19:33:06Z

Minor version update which improves styling of a printouts, fixes the KASAN and KMSAN kernel builds and LLQ reconfiguration after the device reset. Obtained from: Semihalf MFC after: 2 weeks Sponsored by: Amazon, Inc. (cherry picked from commit 25b64933a48c47baef698a302fa2dc5c6e3013ea)

ena: Fix LLQ descriptor reconfiguration

2022-07-26T19:33:05Z

After the device reset, the LLQ configuration descriptor wasn't passed to the hardware. On a 6-generation AWS instances (like C6gn), it is required to pass the LLQ descriptor after the device reset, otherwise the hardware will be missing the LLQ configuration resulting in performance degradation. This patch reconfigures the LLQ each time the ena_device_init() is called. This means that the LLQ descriptor will be passed during the initial configuration and after a reset. The ena_map_llq_mem_bar() function call was moved before the ena_device_init() call, to make sure that the mem bar is available. Obtained from: Semihalf MFC after: 2 weeks Sponsored by: Amazon, Inc. (cherry picked from commit 3324e304c14d121dc04338a38c7f3277cbfba58b)

ena: Align req_id and qid print order

2022-07-26T19:33:05Z

In most places, the req_id is printed first, and the qid is printed as a second. To align the driver, one printout was reworked and the print order of those variables was changed. Suggested by: rpokala Obtained from: Semihalf MFC after: 2 weeks Sponsored by: Amazon, Inc. (cherry picked from commit 38d036e91a8c29bf97b86d441a9d627c5cef2aea)

ena: Make first_interrupt a uint8_t

2022-07-26T19:33:05Z

We do not have atomic(9) routines for bools, and it is not guaranteed that sizeof(bool) is 1. This fixes the KASAN and KMSAN kernel builds, which fail because the compiler refuses to silently cast a _Bool * to a uint8_t * when calling the atomic(9) sanitizer interceptors. Reviewed by: Dawid Górecki MFC after: 2 weeks Fixes: 0ac122c388d9 ("ena: Use atomic_load/store functions for first_interrupt variable") Differential Revision: https://reviews.freebsd.org/D35683 (cherry picked from commit b72f1f4516896ad6da0ea74d146a56045de171f7)

ena: Update driver version to v2.6.0

2022-07-26T19:33:05Z

Some of the changes in this release: * Style fixes * Fix ENI stats probing * Add trace for the last Tx cleanup call * Prevent LLQ initialization if member isn't exposed * Improve logging Obtained from: Semihalf MFC after: 2 weeks Sponsored by: Amazon, Inc. (cherry picked from commit 79e1500276a993c8be857a6e32f0c05ec8f3cdc8)

ena: Fix invalid KASSERT test in netmap code

2022-07-26T19:33:04Z

The KASSERT was originally added to ensure that the netmap Rx ring is not NULL, however, it was checking for the opposite. Obtained from: Semihalf MFC after: 2 weeks Sponsored by: Amazon, Inc. (cherry picked from commit 79770fdad6c18d968cc122c4294820931cc542e0)

ena: Align names of constants

2022-07-26T19:33:04Z

Most of the constants in ena.h file were prefixed with ENA_*, while others did not have this prefix. Align the constants by prefixing the remaining constants with ENA. Obtained from: Semihalf MFC after: 2 weeks Sponsored by: Amazon, Inc. (cherry picked from commit 8f15f8a72b5474b81c5951d4039d203b2d80e2e3)

ena: Remove write-only datapath variable

2022-07-26T19:33:04Z

The ena_qid variable value is never used. It can be safely removed. That also silences the compilation warning. Obtained from: Semihalf MFC after: 2 weeks Sponsored by: Amazon, Inc. (cherry picked from commit d5d5ea87236d8f839cad84296f23d285a696195c)

ena: Fix styling issues

2022-07-26T19:33:04Z

Align code style with FreeBSD style(9) guidelines. Obtained from: Semihalf MFC after: 2 weeks Sponsored by: Amazon, Inc. (cherry picked from commit 82e558eacf222ac497bc11fa9f2c7778e97fbc7a)

ena: Use device_set_desc in probe

2022-07-26T19:33:04Z

During probe the driver created a temporary buffer to which the value of DEVICE_DESC constant was printed. This buffer was then copied to the device structure using device_set_desc_copy. Since the value of this string is exactly the same for every device using the ENA driver, using sprintf is unnecessary, and device_set_desc can be used instead. Obtained from: Semihalf MFC after: 2 weeks Sponsored by: Amazon, Inc. (cherry picked from commit 755e60ca046390bdcfc097b6a8f1a032d47a7b65)