src/sys/dev/ipmi/ipmi.c, branch release/8.1.0 FreeBSD source tree https://cgit-dev.freebsd.org/src/atom?h=release%2F8.1.0 2009-12-21T13:53:33Z MFC r200666: Fixed incorrect watchdog timeout setting. 2009-12-21T13:53:33Z Ruslan Ermilov ru@FreeBSD.org 2009-12-21T13:53:33Z urn:sha1:3135744c5976a1aa11db5fe8c4e9c8c905cd84e0 PR: kern/130512 Fix typo where the code was missing the "IPMICTL_RECEIVE_MSG_32" condition 2008-11-14T01:53:10Z David E. O'Brien obrien@FreeBSD.org 2008-11-14T01:53:10Z urn:sha1:c12dbd1d96e615eca5b650aa39526b40cf03a31b test. Remove hack attempt at using devfs cloning for per-file descriptor storage. 2008-08-28T02:13:53Z John Baldwin jhb@FreeBSD.org 2008-08-28T02:13:53Z urn:sha1:943bebd2c9c6452a47c807dbfc62ad8a6ad3687e Use the much simpler cdevpriv for per-fd state and enable it. This allows multiple opens of /dev/ipmi0 (e.g. using ipmitool while ipmievd is running in the background). MFC after: 1 week Revisit the watchdogs: Resetting the error to EINVAL after failing to set the 2007-03-27T21:03:37Z Nick Hibma n_hibma@FreeBSD.org 2007-03-27T21:03:37Z urn:sha1:f29fa1dfa4c73d0ad8ae958e4cb0160232473309 watchdog might hide the succesful arming of an earlier one. Accept that on failing to arm any watchdog (because of non-supported timeouts) EOPNOTSUPP is returned instead of the more appropriate EINVAL. MFC after: 3 days o break newbus api: add a new argument of type driver_filter_t to 2007-02-23T12:19:07Z Paolo Pisati piso@FreeBSD.org 2007-02-23T12:19:07Z urn:sha1:ef544f631226436ef590825881e7a28369df82f6 bus_setup_intr() o add an int return code to all fast handlers o retire INTR_FAST/IH_FAST For more info: http://docs.freebsd.org/cgi/getmsg.cgi?fetch=465712+0+current/freebsd-current Reviewed by: many Approved by: re@ Align the interfaces for the various watchdogs and make the interface 2006-12-15T21:44:49Z Nick Hibma n_hibma@FreeBSD.org 2006-12-15T21:44:49Z urn:sha1:9079fff5504650793319895e16f3f9cd431c5ec5 behave as expected. Also: - Return an error if WD_PASSIVE is passed in to the ioctl as only WD_ACTIVE is implemented at the moment. See sys/watchdog.h for an explanation of the difference between WD_ACTIVE and WD_PASSIVE. - Remove the I_HAVE_TOTALLY_LOST_MY_SENSE_OF_HUMOR define. If you've lost your sense of humor, than don't add a define. Specific changes: i80321_wdog.c Don't roll your own passive watchdog tickle as this would defeat the purpose of an active (userland) watchdog tickle. ichwd.c / ipmi.c: WD_ACTIVE means active patting of the watchdog by a userland process, not whether the watchdog is active. See sys/watchdog.h. kern_clock.c: (software watchdog) Remove a check for WD_ACTIVE as this does not make sense here. This reverts r1.181. Fix some edge cases in detach() as well as a memory leak if we fail to 2006-12-06T15:10:11Z John Baldwin jhb@FreeBSD.org 2006-12-06T15:10:11Z urn:sha1:d78cd1ad5538d7ec8f6292706c485bf1b17901ef talk to the BMC. Reported by: Alexander Logvinov : ports at logvinov_com MFC after: 1 week ipmi_polled_enqueue_request() is already called with the lock held, just 2006-10-12T16:26:42Z John Baldwin jhb@FreeBSD.org 2006-10-12T16:26:42Z urn:sha1:5283d39b989edba29ed0fe7d8f5b946bf7bcfb62 assert it rather than recursing. Reported by: mjacob Pointy hat: jhb MFC after: 3 days Fix a memory leak in ipmi_unload(). 2006-09-26T15:48:13Z John Baldwin jhb@FreeBSD.org 2006-09-26T15:48:13Z urn:sha1:bec0c98eaee483f59785559e03707d607d289d65 CID: 1542 Found by: Coverity Prevent Update the ipmi(4) driver: 2006-09-22T22:11:29Z John Baldwin jhb@FreeBSD.org 2006-09-22T22:11:29Z urn:sha1:d72a078647de20e31ab09295e671f1b8b4ad89b2 - Split out the communication protocols into their own files and use a couple of function pointers in the softc that the commuication protocols setup in their own attach routine. - Add support for the SSIF interface (talking to IPMI over SMBus). - Add an ACPI attachment. - Add a PCI attachment that attaches to devices with the IPMI interface subclass. - Split the ISA attachment out into its own file: ipmi_isa.c. - Change the code to probe the SMBIOS table for an IPMI entry to just use pmap_mapbios() to map the table in rather than trying to setup a fake resource on an isa device and then activating the resource to map in the table. - Make bus attachments leaner by adding attach functions for each communication interface (ipmi_kcs_attach(), ipmi_smic_attach(), etc.) that setup per-interface data. - Formalize the model used by the driver to handle requests by adding an explicit struct ipmi_request object that holds the state of a given request and reply for the entire lifetime of the request. By bundling the request into an object, it is easier to add retry logic to the various communication backends (as well as eventually support BT mode which uses a slightly different message format than KCS, SMIC, and SSIF). - Add a per-softc lock and remove D_NEEDGIANT as the driver is now MPSAFE. - Add 32-bit compatibility ioctl shims so you can use a 32-bit ipmitool on FreeBSD/amd64. - Add ipmi(4) to i386 and amd64 NOTES. Submitted by: ambrisko (large portions of 2 and 3) Sponsored by: IronPort Systems, Yahoo! MFC after: 6 days