src/sys/dev/isci, branch releng/12.2

MFC r346386, r347890, r347896, r349895:

2020-07-08T17:59:00Z

remove the 4GB boundary requirement on PCI DMA segments

MFC r345070:

2019-03-26T11:03:09Z

isci(4): Use controller->lock for busdma tags.

Correct typo in ATA_WRITE_UNCORRECTABLE_PSEUDO

2018-02-23T20:01:42Z

Also correct a typo in the comment for these values, noted by jimharris. Reviewed by: jimharris Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D3715

kernel: Fix several typos and minor errors

2017-12-27T03:23:21Z

- duplicate words - typos - references to old versions of FreeBSD Reviewed by: imp, benno

sys/dev: further adoption of SPDX licensing ID tags.

2017-11-27T14:52:40Z

Mainly focus on files that use BSD 2-Clause license, however the tool I was using misidentified many licenses so this was mostly a manual - error prone - task. The Software Package Data Exchange (SPDX) group provides a specification to make it easier for automated tools to detect and summarize well known opensource licenses. We are gradually adopting the specification, noting that the tags are considered only advisory and do not, in any way, superceed or replace the license texts.

Include opt files in the kernel with "" instead of <>.

2017-07-10T05:08:01Z

scif_sas_controller: Fix inverted logic range check

2017-03-13T17:58:08Z

PR: 217742 Submitted by: Svyatoslav Sponsored by: Viva64 (PVS-Studio)

Always null-terminate ccb_pathinq.(sim_vid|hba_vid|dev_name)

2017-01-04T20:26:42Z

The sim_vid, hba_vid, and dev_name fields of struct ccb_pathinq are fixed-length strings. AFAICT the only place they're read is in sbin/camcontrol/camcontrol.c, which assumes they'll be null-terminated. However, the kernel doesn't null-terminate them. A bunch of copy-pasted code uses strncpy to write them, and doesn't guarantee null-termination. For at least 4 drivers (mpr, mps, ciss, and hyperv), the hba_vid field actually overflows. You can see the result by doing "camcontrol negotiate da0 -v". This change null-terminates those fields everywhere they're set in the kernel. It also shortens a few strings to ensure they'll fit within the 16-character field. PR: 215474 Reported by: Coverity CID: 1009997 1010000 1010001 1010002 1010003 1010004 1010005 CID: 1331519 1010006 1215097 1010007 1288967 1010008 1306000 CID: 1211924 1010009 1010010 1010011 1010012 1010013 1010014 CID: 1147190 1010017 1010016 1010018 1216435 1010020 1010021 CID: 1010022 1009666 1018185 1010023 1010025 1010026 1010027 CID: 1010028 1010029 1010030 1010031 1010033 1018186 1018187 CID: 1010035 1010036 1010042 1010041 1010040 1010039 Reviewed by: imp, sephe, slm MFC after: 4 weeks Sponsored by: Spectra Logic Corp Differential Revision: https://reviews.freebsd.org/D9037 Differential Revision: https://reviews.freebsd.org/D9038

Pass proper arguments (handles, not directly structure pointers) to

2016-12-28T14:50:39Z

scif_cb_domain_device_removed(). This should fix NULL dereference on task management function timeout. Reviewed by: jimharris MFC after: 2 weeks

Fix improper use of "its".

2016-11-08T23:59:41Z