src/sys/dev/mpi3mr, branch mainFreeBSD source treehttps://cgit-dev.freebsd.org/src/atom?h=main2026-02-25T05:59:34Zchore: replace {0, 0} with {DEV,KOBJ}METHOD_END2026-02-25T05:59:34ZEnji Cooperngie@FreeBSD.org2026-02-21T06:14:46Zurn:sha1:0fc6c3f731a2cca3120798806c330a3081c9424b
Both of the aforementioned macros have been present in FreeBSD
for well over a decade: 2009 for `KOBJMETHOD_END`; 2011 for
`DEVMETHOD_END`.
Adapt all hardcoded references of `{0, 0}` with `DEVMETHOD_END`
and `KOBJMETHOD_END` as appropriate. This helps ensure that
future adaptations to drivers following patterns documented
in driver(9) can be made more easily/without issue.
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D55414
mpi3mr: Get rid of a supurious printf2025-09-14T17:29:40ZWarner Loshimp@FreeBSD.org2025-09-14T17:29:40Zurn:sha1:52096ba6b7692ca204214959b8efffae87efa652
If we have outstanding tractions and then poll and still have
outstanding transactions, we print a warning. However, we print the
warning, confusingly, even if there's 0 left. Enclose the two statements
in {} to avoid this relatively harmless effect and quiet gcc12's
indentation complaint.
Sponsored by: Netflix
mpi3mr: Build with gcc12 by being more explicit about conditions2025-09-14T17:24:16ZWarner Loshimp@FreeBSD.org2025-09-14T17:24:16Zurn:sha1:3dfb4e52587ae692745993a3fee975ad1d3865be
Help the flow analysis in gcc12 by initializing scsi_reply to NULL and
testing it along with sense_buf. Sense buf should be non-null only in
this code path, but might also be non-null if the PA for is somehow set
to zero. I debated adding an assert for the latter, but opted to instead
preserve existing behavior.
Also set host_diagnostic to 0. gcc12 can't quite realize that we only
test it after we've been through this loop at least once to report an
error condition. Initialize to 0 to avoid a diagnostic.
Sponsored by: Netflix
mpr3mr: Fix missing braces2025-09-14T17:18:44ZWarner Loshimp@FreeBSD.org2025-09-14T17:18:44Zurn:sha1:a85adbcd3dee8d062bf49e1f713e718f59ec0e9f
We detect an error condiction and print it. And then unconditionally
jump to the err code, which is incorrect. It's clear from indentation
and code tracing there should be braces here.
Sponsored by: Netflix
machine/stdarg.h -> sys/stdarg.h2025-06-11T16:39:02ZBrooks Davisbrooks@FreeBSD.org2025-06-11T16:39:02Zurn:sha1:e453e498cbb88570a3ff7b3679de65c88707da95
Switch to using sys/stdarg.h for va_list type and va_* builtins.
Make an attempt to insert the include in a sensible place. Where
style(9) was followed this is easy, where it was ignored, aim for the
first block of sys/*.h headers and don't get too fussy or try to fix
other style bugs.
Reviewed by: imp
Exp-run by: antoine (PR 286274)
Pull Request: https://github.com/freebsd/freebsd-src/pull/1595
mpi3mr: modified the log messages to be on a single line2025-04-28T03:24:52ZChandrakanth patilchandrakanth.patil@broadcom.com2025-04-27T23:41:19Zurn:sha1:4494ea5406f79a6cb2d3631a723eb286ca96a9b9
qThis change was made after feedback from upstream, aiming to align with
the style guide for consistent log formatting. No functional changes
were made to the driver, only the formatting of the log messages.
Reviewed by: ssaxena, imp
Differential Revision: https://reviews.freebsd.org/D49799
mpi3mr: Update Driver Version to 8.14.0.2.02025-04-28T03:22:56ZChandrakanth patilchandrakanth.patil@broadcom.com2025-04-27T23:40:35Zurn:sha1:f4d51d3e1a90dabbed26aacf1b58e20e23a19342
The driver version has been updated to 8.14.0.2.0 to reflect the
latest release. This is a version-only update with no functional
code changes.
Reviewed by: ssaxena, imp
Differential Revision: https://reviews.freebsd.org/D49753
mpi3mr: Update Copyright Year to 20252025-04-28T03:22:56ZChandrakanth patilchandrakanth.patil@broadcom.com2025-04-27T23:40:25Zurn:sha1:69be9a247b845b35146fed4575dacb565c9c18ba
All driver source files have been updated to reflect the year 2025.
This change is cosmetic and does not affect functionality.
Reviewed by: ssaxena, imp
Differential Revision: https://reviews.freebsd.org/D49752
mpi3mr: Process LOG Data Events in Interrupt Top Half for Early Notification2025-04-28T03:22:56ZChandrakanth patilchandrakanth.patil@broadcom.com2025-04-27T23:40:14Zurn:sha1:df8a74fca036a0ba8026f3ae3da830dffb922faa
The driver now processes LOG Data events in the interrupt top
half instead of the bottom half. This allows LOG events to be
handled immediately upon receipt, reducing latency and enabling
early notification to the Library or applications.
This change ensures LOG event handling occurs closer to the
firmware's generation point, improving alignment with event-driven
diagnostic and monitoring mechanisms.
Reviewed by: ssaxena, imp
Differential Revision: https://reviews.freebsd.org/D49751
mpi3mr: Enable Diag Save for All Diagnostic Fault Cases2025-04-28T03:22:56ZChandrakanth patilchandrakanth.patil@broadcom.com2025-04-27T23:40:04Zurn:sha1:b854677d970a11e87929fa95d0e4067f911faa62
This patch ensures the driver sets the Diag Save bit for all
diagnostic fault conditions before issuing a Diagnostic Fault Reset.
The firmware now incorporates logic to manage snapdump saving
and requires the driver to always set the Diag Save bit to enable
this feature. This change supports improved diagnostic data
collection and fault handling.
Reviewed by: ssaxena, imp
Differential Revision: https://reviews.freebsd.org/D49750