FreeBSD source tree https://cgit-dev.freebsd.org/src/atom?h=releng%2F12.4 2022-04-14T06:31:43Z 2022-04-14T06:31:43Z Gordon Bergling gbe@FreeBSD.org 2022-04-09T12:10:05Z urn:sha1:4a4c6243e9e014f4b499ed788336b2edce1e87ef - s/proccessor/processor/ (cherry picked from commit a37c6fcc46caffc15f0f22a7e4afce9192872c1a) 2022-04-04T00:46:34Z Ed Maste emaste@FreeBSD.org 2022-03-28T13:33:54Z urn:sha1:56d0638c738e3f9b7fbc7f78bd49590523e01ada *_CFG_PAGE ioctl handlers in the mpr, mps, and mpt drivers allocated a buffer of a caller-specified size, but copied to it a fixed size header. Add checks that the size is at least the required minimum. Note that the device nodes are owned by root:operator with 0640 permissions so the ioctls are not available to unprivileged users. This change includes suggestions from scottl, markj and mav. Two of the mpt cases were reported by Lucas Leong (@_wmliang_) of Trend Micro Zero Day Initiative; scottl reported the third case in mpt. Same issue found in mpr and mps after discussion with imp. Reported by: Lucas Leong (@_wmliang_), Trend Micro Zero Day Initiative Reviewed by: imp, mav MFC after: 3 days Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D34692 (cherry picked from commit 8276c4149b5fc7c755d6b244fbbf6dae1939f087) 2021-04-24T00:43:29Z Alexander Motin mav@FreeBSD.org 2021-04-17T14:41:35Z urn:sha1:dd01826ad3add7e5285f4f391c9f502906c78600 First, two of those four checks are unreachable. Second, I don't believe there should be ">=" instead of ">". Third, bus_dma(9) already returns the same EFBIG if ">". This fixes false I/O errors in worst S/G cases with maxphys >= 2MB. MFC after: 1 week (cherry picked from commit 0f29396e493bd87ffa6a63fcb602b12e79d21a1e) 2020-04-28T17:59:37Z Brooks Davis brooks@FreeBSD.org 2020-04-28T17:59:37Z urn:sha1:18fec7394da653a176be797ebcdd1eaf55897f9d Centralize compatability translation macros. Copy the CP, PTRIN, etc macros from freebsd32.h into a sys/abi_compat.h and replace existing definitation with includes where required. This eliminates duplicate code and allows Linux and FreeBSD compatability headers to be included in the same files. Obtained from: CheriBSD Sponsored by: DARPA Differential Revision: https://reviews.freebsd.org/D24275 2018-01-21T15:42:36Z Pedro F. Giffuni pfg@FreeBSD.org 2018-01-21T15:42:36Z urn:sha1:ac2fffa4b74cd83963f0d462c379c7f50eeabf20 Uses of mallocarray(9). The use of mallocarray(9) has rocketed the required swap to build FreeBSD. This is likely caused by the allocation size attributes which put extra pressure on the compiler. Given that most of these checks are superfluous we have to choose better where to use mallocarray(9). We still have more uses of mallocarray(9) but hopefully this is enough to bring swap usage to a reasonable level. Reported by: wosch PR: 225197 2018-01-13T22:30:30Z Pedro F. Giffuni pfg@FreeBSD.org 2018-01-13T22:30:30Z urn:sha1:26c1d774b55c4db79bca772941883244986e6f44 Focus on code where we are doing multiplications within malloc(9). None of these is likely to overflow, however the change is still useful as some static checkers can benefit from the allocation attributes we use for mallocarray. This initial sweep only covers malloc(9) calls with M_NOWAIT. No good reason but I started doing the changes before r327796 and at that time it was convenient to make sure the sorrounding code could handle NULL values. 2017-11-27T14:52:40Z Pedro F. Giffuni pfg@FreeBSD.org 2017-11-27T14:52:40Z urn:sha1:718cf2ccb9956613756ab15d7a0e28f2c8e91cab Mainly focus on files that use BSD 2-Clause license, however the tool I was using misidentified many licenses so this was mostly a manual - error prone - task. The Software Package Data Exchange (SPDX) group provides a specification to make it easier for automated tools to detect and summarize well known opensource licenses. We are gradually adopting the specification, noting that the tags are considered only advisory and do not, in any way, superceed or replace the license texts. 2017-11-20T19:36:21Z Pedro F. Giffuni pfg@FreeBSD.org 2017-11-20T19:36:21Z urn:sha1:7282444b103e0b3e7c8cd053413ff6c068831cc6 Mainly focus on files that use BSD 3-Clause license. The Software Package Data Exchange (SPDX) group provides a specification to make it easier for automated tools to detect and summarize well known opensource licenses. We are gradually adopting the specification, noting that the tags are considered only advisory and do not, in any way, superceed or replace the license texts. Special thanks to Wind River for providing access to "The Duke of Highlander" tool: an older (2014) run over FreeBSD tree was useful as a starting point. 2017-06-30T22:06:24Z Ryan Libby rlibby@FreeBSD.org 2017-06-30T22:06:24Z urn:sha1:5a62cbcaad2d7851f1dd03d5a078a64f743e0d8f Build with gcc -Wint-in-bool-context revealed a macro parenthesization error (invoking mpt_lprt with a ternary expression for level). Reviewed by: markj Approved by: markj (mentor) Sponsored by: Dell EMC Isilon Differential revision: https://reviews.freebsd.org/D11412 2017-03-11T14:25:14Z Alexander Motin mav@FreeBSD.org 2017-03-11T14:25:14Z urn:sha1:67445003fb9407f05b1f8a6404428b9be7874076 - XPT_NOTIFY_ACKNOWLEDGE was not handled, causing stuck requests. - XPT_ABORT was not even trying to abort active ATIOs/INOTs. - Initiator's tag was not stored and not used where needed. - List of TM request types needed update. - mpt_scsi_tgt_status() missed some useful debugging. After this change global TM requests, such as reset, should work properly. ABORT TASK (ABTS) requests are still not passes to CTL, that is not good and should be fixed. MFC after: 2 weeks