FreeBSD source tree https://cgit-dev.freebsd.org/src/atom?h=release%2F13.1.0 2022-03-07T10:55:11Z 2022-03-07T10:55:11Z Ram Kishore Vegesna ram@FreeBSD.org 2022-03-04T14:40:32Z urn:sha1:120ba9ec7ffb68b95f3da56cb514db5a2c273169 Updated commit 79c56c9af583, do not proceed with discovery if flogi fails in pt2pt winner case. MFC after: 3 days (cherry picked from commit 625a8bfb047a94459b4ab41f08fe5a2c23694039) 2022-03-07T10:54:56Z Ram Kishore Vegesna ram@FreeBSD.org 2022-03-03T12:46:56Z urn:sha1:4a90d6c823df322112440d1294c91846d101b85a Summary: Drop unsolicited BLS commands other than ABTS. Reviewed by: mav MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D34423 (cherry picked from commit 57e4b677559a742031c7478d801c1e218afae239) 2022-03-07T10:54:45Z Ram Kishore Vegesna ram@FreeBSD.org 2022-03-03T16:00:27Z urn:sha1:95c714c6c4735aacec1a683eb39c596a3ae7b2bd Summary: Enable persistent topology across power cycles/firmware resets. Reviewed by: mav MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D34425 (cherry picked from commit 965e2154e7682572e99e4c8fd4776dfe8f836b24) 2022-03-07T10:54:27Z Ram Kishore Vegesna ram@FreeBSD.org 2022-03-03T11:44:03Z urn:sha1:927f2126d28905cce350964984c72c5444f7d193 Summary: Some targets are not responding to the FLOGI in point-to-point topology, If the pt2pt discovery is done, Ignore the FLOGI failure. MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D34422 (cherry picked from commit 79c56c9af583b4c6e079594b7b6ff8176e6bff7d) 2022-02-14T07:12:55Z Ram Kishore Vegesna ram@FreeBSD.org 2022-02-09T10:14:12Z urn:sha1:2748f68db95e2e921814472f9c1b77ef49b8fde6 Fix a possible Null pointer dereference in ocs_hw_get_profile_list_cb() PR: 261453 Reported by: lwhsu MFC after: 3 days (cherry picked from commit 7bf31432fd03e2a5a815d1cc81de9a7b1ea3d3ca) 2021-12-24T08:58:15Z Ram Kishore Vegesna ram@FreeBSD.org 2021-12-20T12:25:13Z urn:sha1:cc3114e17b247536979bd365185f3de950fe0b62 Enable serialnumber reporting. Reviewed by: mav MFC after: 3 days (cherry picked from commit cba757ef2a7ec2bb985fbcd67e8d616328b7209a) ocs_fs(4): Fix some common typos in source code comments - s/transfered/transferred/ - s/associted/associated/ MFC after: 3 days (cherry picked from commit 16b71d98d96a3a9a2ac666440aa80f12d478959d) 2021-12-17T10:31:06Z Ram Kishore Vegesna ram@FreeBSD.org 2021-12-06T07:02:02Z urn:sha1:de7809c1eeedce27a60b84df23b1735f8658369a Remove unused function declarations. Changes required for internal tool. Approved by: ken (cherry picked from commit 6f78736cb12026fcb423e1b313e83efb80597f21) 2021-12-17T10:31:06Z Ram Kishore Vegesna ram@FreeBSD.org 2021-09-24T09:35:30Z urn:sha1:161148e61f5dd98aba6b17ca90f396902a00d2b5 Issue: Devices wont go away after the link down. Device lost timer functionality in ocs_fc is broken, `is_target` flag is not set in the target database and target delete is skipped. Fix: Remove unused flags and delete the device when timer expires. Reported by: ken@kdm.org Reviewed by: mav, ken (cherry picked from commit 41e946694333bcc6f64242f294312553f2ef2dcd) 2021-12-17T10:31:06Z Ram Kishore Vegesna ram@FreeBSD.org 2021-09-24T09:32:09Z urn:sha1:0fff02894f308ec3943b9cbce09d468e7d9974ea Proper error recovery depends on freezing the device queue when an error occurs, so we can recover from an error before sending additional commands. The ocs_fc(4) driver was not freezing the device queue for most SCSI errors, and that broke error recovery. sys/dev/ocs_fc/ocs_cam.c: In ocs_scsi_initiator_io_cb(), freeze the device queue if we're passing back status other than CAM_REQ_CMP. Submitted by: ken@kdm.org Reviewed by: mav, ken (cherry picked from commit d063d1bc928165e7798df5ec1c424794a1ec41e9) 2021-12-17T10:31:05Z Ram Kishore Vegesna ram@FreeBSD.org 2021-09-24T09:19:49Z urn:sha1:4821da88ab77fb603abe1c07162ea37d01730edb In ocs_scsi_initiator_io_cb(), if the SCSI command that is getting completed had a residual equal to the transfer length, it was setting the CCB status to CAM_REQ_CMP. That breaks the expected behavior for commands like READ ATTRIBUTE. For READ ATTRIBUTE, if the first attribute requested doesn't exist, the command is supposed to return an error (Illegal Request, Invalid Field in CDB). The broken behavior for READ ATTRIBUTE caused LTFS tape formatting to fail. It looks for attribute 0x1623, and expects to see an error if the attribute isn't present. In addition, if the residual is negative (indicating an overrun), only set the CCB status to CAM_DATA_RUN_ERR if we have not already reported an error. The SCSI sense data will have more detail about what went wrong. sys/dev/ocs_fc/ocs_cam.c: In ocs_scsi_initiator_io_cb(), don't set the status to CAM_REQ_CMP if the residual is equal to the transfer length. Also, only set CAM_DATA_RUN_ERR if we didn't get SCSI status. Submitted by: ken@kdm.org Reviewed by: mav, ken (cherry picked from commit 1af49c2eeb4a05f524ed9a6657c741bc96fbaf87)