FreeBSD source tree https://cgit-dev.freebsd.org/src/atom?h=releng%2F12.2 2020-04-27T23:47:40Z 2020-04-27T23:47:40Z Brooks Davis brooks@FreeBSD.org 2020-04-27T23:47:40Z urn:sha1:33b80acf60a1cdf0390c7acc33f13022c7a9515b Fix -Wvoid-pointer-to-enum-cast warnings. This pattern is used in callbacks with void * data arguments and seems both relatively uncommon and relatively harmless. Silence the warning by casting through uintptr_t. This warning is on by default in Clang 11. Reviewed by: arichardson Obtained from: CheriBSD (partial) Sponsored by: DARPA Differential Revision: https://reviews.freebsd.org/D24425 2019-02-12T17:07:15Z Ram Kishore Vegesna ram@FreeBSD.org 2019-02-12T17:07:15Z urn:sha1:86893be9068d3311bb224d75cb1e0c5fe3527850 while processing cam actions. Issue: ocs_fc(4) driver panics. It's induced by setting the port_state sysctl to offline, then online, then offline, then online, and so forth and so on in rapid succession. Reason: While we set the port_state to online fc discovery will start and OS is enumerating the target discs by calling ocs_action(), then set the port state to "offline" which deletes domain/sport/nodes. In ocs_action()->XPT_GET_TRAN_SETTINGS we are accessing the remote node which can be invalid to get the wwpn, wwnn and port. Fix: Removed accessing of remote node and domain in some ocs_action() cases. Populated the required values from ocs_fcport. This removes the dependency of node and domain structures while processing XPT_PATH_INQ and XPT_GET_TRAN_SETTINGS. We will invalidate the target entries after the device lost timeout(30 seconds). Approved by:ken,mav 2019-01-24T01:03:12Z Mark Johnston markj@FreeBSD.org 2019-01-24T01:03:12Z urn:sha1:a6c3ca3c1e7503c653f382f52aa15ffdeed30be5 ocs_fc: Ensure that we zero-initialize memory before copying it out. admbugs: 765 2018-07-22T18:31:15Z Mark Johnston markj@FreeBSD.org 2018-07-22T18:31:15Z urn:sha1:84f0fb8a9347d01a55364a34c440c012695f8386 PR: 229952 2018-07-18T07:01:34Z Ram Kishore Vegesna ram@FreeBSD.org 2018-07-18T07:01:34Z urn:sha1:6affb8eb8f0385fd5932f2475442af7efe40ba9d Issue: IO fails immediately after doing port-toggle. Fix: Added LDT(Device Lost Timer)- we wait a specific period of time prior to telling the OS about lost device. Approved by: ken, mav MFC after: 3 days Differential Revision: D16196 2018-06-11T07:57:32Z Dimitry Andric dim@FreeBSD.org 2018-06-11T07:57:32Z urn:sha1:bc5ea07c09b4468f4c4bd247c6e7ca38bd6841b3 Add a few intermediate casts to uintptr_t to suppress "cast to pointer from integer of different size" warnings from gcc. Also remove a few incorrect casts. Reviewed by: ram MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D15747 2018-06-05T15:05:26Z Ram Kishore Vegesna ram@FreeBSD.org 2018-06-05T15:05:26Z urn:sha1:ca21db854682926959c0fb25e74e80e93f95159a Utility hangs when OCS_IOCTL_CMD_MGMT_GET_ALL called in parallel on port 0 and port 1. Fix: Using static structure for results is corrupting the second ioctl request. Removed static for results structure. Approved by: ken MFC after: 3 days 2018-05-11T14:50:26Z Kenneth D. Merry ken@FreeBSD.org 2018-05-11T14:50:26Z urn:sha1:e440863e06b258f6697d768df92955b8d7a80ce1 sys/dev/ocs/ocs_os.c: In ocs_thread_create(), use sizeof(*thread) (instead of sizeof(thread)) as the size argument to memset so that we clear out the entire thread structure instead of just a few bytes of it. Submitted by: jtl MFC after: 3 days 2018-04-17T15:29:32Z Ram Kishore Vegesna ram@FreeBSD.org 2018-04-17T15:29:32Z urn:sha1:5eaf9435d043ada2459cca87079dd1817db51768 PR: 227446 Approved by: ken MFC after: 3 days 2018-04-13T13:31:20Z Ram Kishore Vegesna ram@FreeBSD.org 2018-04-13T13:31:20Z urn:sha1:80b5058dccdda81751c8fe0358d53b756268b881 PR: 227446 Reported by: emaste Approved by: ken