FreeBSD source tree https://cgit-dev.freebsd.org/src/atom?h=release%2F12.3.0 2020-05-21T02:08:34Z 2020-05-21T02:08:34Z Kyle Evans kevans@FreeBSD.org 2020-05-21T02:08:34Z urn:sha1:f359167141f2ab817ca5adaf027cfcb37a347ddf __builtin_unreachable doesn't raise any compile-time warnings/errors on its own, so problems with its usage can't be easily detected. While it would be nice for this situation to change and compilers to at least add a warning for trivial cases where local state means the instruction can't be reached, this isn't the case at the moment and likely will not happen. This commit adds an __assert_unreachable, whose intent is incredibly clear: it asserts that this instruction is unreachable. On INVARIANTS builds, it's a panic(), and on non-INVARIANTS it expands to __unreachable(). Existing users of __unreachable() are converted to __assert_unreachable, to improve debuggability if this assumption is violated. 2019-12-22T19:30:13Z Ian Lepore ian@FreeBSD.org 2019-12-22T19:30:13Z urn:sha1:4c3987c8857473c252dbe9995c770e4f95ffd0c8 r355598: Do not attach children of owc_gpiobus until interrupts are working. The children of the bus need to do IO on the bus to probe for hardware presence. Doing IO means timing the bus states using sbinuptime(), and that requires working timecounters, which are not initialized until after device attachment has completed. PR: 242526 r355727 (by imp): Create new wrapper function: bus_delayed_attach_children() Delay the attachment of children, when requested, until after interrutps are running. This is often needed to allow children to run transactions on i2c or spi busses. It's a common enough idiom that it will be useful to have its own wrapper. Reviewed by: ian Differential Revision: https://reviews.freebsd.org/D21465 r355735 (by imp): Be consistent about checking return value from bus_delayed_attach_children. Most places checked, but a couple last minute changes didn't. Make them all use the return value. Noticed by: rpokala@ r355858: Update owc_gpiobus (one-wire over gpio) to the modern gpio_pin interface. It used to be required that a device be a child of gpiobus(4) to manipulate gpio pins. That requirement didn't work well for FDT-based systems with many cross-hierarchy users of gpio, so a more modern framework was created that removed the old hierarchy requirement. These changes adapt the owc_gpiobus driver to use the newer gpio_pin_* functions to acquire, release, and manipulate gpio pins. This allows a single driver to work for both hinted-attachment and fdt-based systems, and removes the requirement that any one-wire fdt nodes must appear at the root of the devicetree. Differential Revision: https://reviews.freebsd.org/D22710 2019-11-20T08:39:21Z Andriy Gapon avg@FreeBSD.org 2019-11-20T08:39:21Z urn:sha1:ed661a1f2dd2584a049472cbfc350a2a211c535c gcc CI complains, but clang doesn't. 2019-11-20T08:37:22Z Andriy Gapon avg@FreeBSD.org 2019-11-20T08:37:22Z urn:sha1:492b7317c3d04777e38af983e05bd93ae54b752d 2019-11-20T08:35:54Z Andriy Gapon avg@FreeBSD.org 2019-11-20T08:35:54Z urn:sha1:459f12d6dbd416fe09b2743b363300b64b880bb4 2019-11-20T08:34:24Z Andriy Gapon avg@FreeBSD.org 2019-11-20T08:34:24Z urn:sha1:a8ede3907a6fc40eb35ecb25d5df17a45b1092db 2019-11-08T07:38:34Z Andriy Gapon avg@FreeBSD.org 2019-11-08T07:38:34Z urn:sha1:4869ee8c50e0cb0da7ac1a67691bd55fb3a6bbaf 2019-11-08T07:36:51Z Andriy Gapon avg@FreeBSD.org 2019-11-08T07:36:51Z urn:sha1:80fa48d9d784dbddf32e9809d1541a640a3ec412 2019-11-08T07:35:32Z Andriy Gapon avg@FreeBSD.org 2019-11-08T07:35:32Z urn:sha1:25721a3daae80e22e770c5de61e4c009c90b8be6 2019-11-05T07:00:10Z Andriy Gapon avg@FreeBSD.org 2019-11-05T07:00:10Z urn:sha1:0a2c8f28e22bbd8d69855765b836d10a02514542 And use better scopes for the lock.