src/sys/dev/pccard, branch releng/12.4FreeBSD source treehttps://cgit-dev.freebsd.org/src/atom?h=releng%2F12.42020-09-09T22:45:11ZMFC r364335,r364336,r364337,r3643512020-09-09T22:45:11ZWarner Loshimp@FreeBSD.org2020-09-09T22:45:11Zurn:sha1:e38a9372939fe304ec5ec33366bb2a293f0ba695
r364335 | imp | 2020-08-18 00:07:34 -0600 (Tue, 18 Aug 2020) | 6 lines
Modernize a bit.
Remove PC Card specific information. It's of little value these days and on
the way out after most of its drivers have been removed.
Use iwn instead of wi device.
r364336 | imp | 2020-08-18 00:18:18 -0600 (Tue, 18 Aug 2020) | 9 lines
Document that PC Card will likely be removed before 13.
This was discussed in arch@ a while ago. Most of the 16-bit drivers that it
relied on have been removed. There's only a few other drivers remaining that
support it, and those are very rare the days (even the once ubiquitious wi(1)
is now quite rare).
Indvidual drivers will be handled separately before pccard itself is removed.
r364337 | imp | 2020-08-18 00:34:56 -0600 (Tue, 18 Aug 2020) | 2 lines
Use better gone_in_dev rather than just gone_in to print the device name.
r364351 | imp | 2020-08-18 11:29:01 -0600 (Tue, 18 Aug 2020) | 4 lines
bt(4) has already been removed. Add a deprecation notice.
MFC After: 1 day
Reapply, with minor tweaks, r338025, from the original commit:2018-09-26T17:12:14ZWarner Loshimp@FreeBSD.org2018-09-26T17:12:14Zurn:sha1:329e817fcc97aa847765c5171cc89a81a0b25527
Remove unused and easy to misuse PNP macro parameter
Inspired by r338025, just remove the element size parameter to the
MODULE_PNP_INFO macro entirely. The 'table' parameter is now required to
have correct pointer (or array) type. Since all invocations of the macro
already had this property and the emitted PNP data continues to include the
element size, there is no functional change.
Mostly done with the coccinelle 'spatch' tool:
$ cat modpnpsize0.cocci
@normaltables@
identifier b,c;
expression a,d,e;
declarer MODULE_PNP_INFO;
@@
MODULE_PNP_INFO(a,b,c,d,
-sizeof(d[0]),
e);
@singletons@
identifier b,c,d;
expression a;
declarer MODULE_PNP_INFO;
@@
MODULE_PNP_INFO(a,b,c,&d,
-sizeof(d),
1);
$ rg -l MODULE_PNP_INFO -- sys | \
xargs spatch --in-place --sp-file modpnpsize0.cocci
(Note that coccinelle invokes diff(1) via a PATH search and expects diff to
tolerate the -B flag, which BSD diff does not. So I had to link gdiff into
PATH as diff to use spatch.)
Tinderbox'd (-DMAKE_JUST_KERNELS).
Approved by: re (glen)
Back out r338035 until Warner is finished churning GSoC PNP patches2018-08-19T00:46:22ZConrad Meyercem@FreeBSD.org2018-08-19T00:46:22Zurn:sha1:b8e771e97a39a88bbf6ebf8f31dcc820c91fe355
I was not aware Warner was making or planning to make forward progress in
this area and have since been informed of that.
It's easy to apply/reapply when churn dies down.
Remove unused and easy to misuse PNP macro parameter2018-08-19T00:22:21ZConrad Meyercem@FreeBSD.org2018-08-19T00:22:21Zurn:sha1:faa319436f0d548cff97c2c8c763538997b63f34
Inspired by r338025, just remove the element size parameter to the
MODULE_PNP_INFO macro entirely. The 'table' parameter is now required to
have correct pointer (or array) type. Since all invocations of the macro
already had this property and the emitted PNP data continues to include the
element size, there is no functional change.
Mostly done with the coccinelle 'spatch' tool:
$ cat modpnpsize0.cocci
@normaltables@
identifier b,c;
expression a,d,e;
declarer MODULE_PNP_INFO;
@@
MODULE_PNP_INFO(a,b,c,d,
-sizeof(d[0]),
e);
@singletons@
identifier b,c,d;
expression a;
declarer MODULE_PNP_INFO;
@@
MODULE_PNP_INFO(a,b,c,&d,
-sizeof(d),
1);
$ rg -l MODULE_PNP_INFO -- sys | \
xargs spatch --in-place --sp-file modpnpsize0.cocci
(Note that coccinelle invokes diff(1) via a PATH search and expects diff to
tolerate the -B flag, which BSD diff does not. So I had to link gdiff into
PATH as diff to use spatch.)
Tinderbox'd (-DMAKE_JUST_KERNELS).
pccard: recode to use devctl_safe_quote_sb instead of devctl_safe_quote.2018-06-27T04:11:14ZWarner Loshimp@FreeBSD.org2018-06-27T04:11:14Zurn:sha1:d21a52ae1b97ff44d97d090e6823b0ef2a73861a
Sponsored by: Netflix
Differential Review: https://reviews.freebsd.org/D16026
Push down Giant one layer. In the days of yore, back when Penitums2018-03-20T22:01:18ZWarner Loshimp@FreeBSD.org2018-03-20T22:01:18Zurn:sha1:4e96c99bdfb3ec4738c61d189249c280ee1d465b
were the new kids on the block and F00F hacks were all the rage, one
needed to take out Giant to do anything moderately complicated with
the VM, mappings and such. So the pccard / cardbus code held Giant for
the entire insertion or removal process.
Today, the VM is MP safe. The lock is only needed for dealing with
newbus things. Move locking and unlocking Giant to be only around
adding and probing devices in pccard and cardbus.
Minor formatting and style tweaks to some comments.2017-12-28T18:51:35ZJohn Baldwinjhb@FreeBSD.org2017-12-28T18:51:35Zurn:sha1:a4f66e5f21fec804a9ff63e523398f0422a0691bCreate a new ISA_PNP_INFO macro. Use this macro every where we have2017-12-23T06:49:27ZWarner Loshimp@FreeBSD.org2017-12-23T06:49:27Zurn:sha1:5fe4723c701cae7118f3293d9d1f173dcbb062a2
ISA PNP card support (replace by hand version in if_ed). Move module
declarations to the end of some files. Fix PCCARD_PNP_INFO to use
nitems(). Remove some stale comments about pc98, turns out the comment
was simply wrong.
Expand cryptic comment with inforation I've learned in the mean time2017-12-23T06:11:19ZWarner Loshimp@FreeBSD.org2017-12-23T06:11:19Zurn:sha1:75d037476586d8d42eeea701166b20d847c48455
about CIS3/CIS4, including studies I've done on my large collection of
PC Cards bought off e-bay over the years since the original entry as
well as conversations I've had at conferences.
PC Card PNP tables are terminated by a NULL sentinel. This shouldn't2017-12-22T16:59:50ZWarner Loshimp@FreeBSD.org2017-12-22T16:59:50Zurn:sha1:56f3600c8b722ead4e74371bfe8b4afdfc7714e7
be recorded in the linker hints, so subtract one to omit it.