FreeBSD source tree https://cgit-dev.freebsd.org/src/atom?h=release%2F12.3.0 2021-08-19T07:35:05Z 2021-08-19T07:35:05Z Gordon Bergling gbe@FreeBSD.org 2021-08-14T06:55:58Z urn:sha1:54e111ec0c74dc7ae50758aaaa8d34571a3bc3b0 - s/struture/structure/ - s/structre/structure/ (cherry picked from commit 17db4b52fb41aeabeb945c68c1b5edd4db4eac31) 2021-04-23T01:09:07Z Alexander Motin mav@FreeBSD.org 2021-04-16T19:39:01Z urn:sha1:39c37df826a73a8dd4d2d3e5909102969291170e There is a weird limit of AGTIAPI_MAX_DMA_SEGS (128) S/G segments per I/O since the initial driver import. I don't know why it was added, can only guess some hardware limitation, but in worst case it means maximum I/O size of 508KB. Respect it to be safe, rounding to 256KB. MFC after: 1 week Sponsored by: iXsystems, Inc. (cherry picked from commit 3e347834200b5d91a33384e696793e4ac20a44d4) 2021-04-23T01:09:07Z Alexander Motin mav@FreeBSD.org 2021-04-16T19:16:09Z urn:sha1:320fd259c69ef16e9b8d64424f66eeed8ddc3c77 It is a direct request for data corruptions, one report of which we have received. I am very surprised that only one. MFC after: 1 week Sponsored by: iXsystems, Inc. (cherry picked from commit 8434a65ce49bd6bc6779f0e57b0ce0f4bc46f48e) 2021-04-14T00:46:19Z Ryan Libby rlibby@FreeBSD.org 2021-01-20T21:59:49Z urn:sha1:bc6d368bb8a359c557af200a93f2862f0571d6ea Define the maximum numbers of segments to allow for non-page alignment at the beginning and end of a maxphys size transfer. Also set ccb_pathinq.maxio consistent with maxphys. Reviewed by: imp Sponsored by: Dell EMC Isilon Differential Revision: https://reviews.freebsd.org/D28043 (cherry picked from commit e54a1d5751805714bf6ea5e2e99887388110f9f0) 2019-03-25T17:03:39Z David Bright dab@FreeBSD.org 2019-03-25T17:03:39Z urn:sha1:be92309b55ffe93272cf95366aecbfc15bb046e2 Fix a scribbler in the PMS driver. The ESGL bit was left uninitialized when executing the REPORT LUNS ioctl. This could allow a zeroed data buffer to be treated as a scatter/gather list. The firmware would eventually walk past the end of the data buffer, potentially find what looked like a valid address/length pair, and write the result to semi-random memory. Obtained from: Dell EMC Isilon Sponsored by: Dell EMC Isilon 2019-02-27T22:29:12Z David Bright dab@FreeBSD.org 2019-02-27T22:29:12Z urn:sha1:74d711d5377b494a3dc906da93ac919b30467136 CID 1332000: Logically dead code in sys/dev/pms/RefTisa/tisa/sassata/sas/ini/itdio.c A pointer is first tested for NULL. If non-NULL, another pointer is set equal to the first. The second pointer is then checked for NULL and an error path taken if so. This second test and the associated path is dead code as the pointer value, having just been checked for NULL, cannot be NULL at this point. Remove the dead code. Sponsored by: Dell EMC Isilon 2017-10-21T07:23:45Z Ryan Libby rlibby@FreeBSD.org 2017-10-21T07:23:45Z urn:sha1:2efbd10aded4018c33c9938c5acc151021370d3a - A number of unused variable warnings, - a missing prototype warning (actually a dead function), - and a potential use of an uninitialized variable. Reviewed by: pfg Sponsored by: Dell EMC Isilon Differential Revision: https://reviews.freebsd.org/D12683 2017-02-20T03:43:12Z Pedro F. Giffuni pfg@FreeBSD.org 2017-02-20T03:43:12Z urn:sha1:4d24901ac9131267fd188c5e1ee19a219847238a Makes things easier to read, plus architectures may set NULL to something different than zero. Found with: devel/coccinelle MFC after: 3 weeks 2017-01-04T20:26:42Z Alan Somers asomers@FreeBSD.org 2017-01-04T20:26:42Z urn:sha1:4195c7de2471d6212744bcbf128d659e94801d17 The sim_vid, hba_vid, and dev_name fields of struct ccb_pathinq are fixed-length strings. AFAICT the only place they're read is in sbin/camcontrol/camcontrol.c, which assumes they'll be null-terminated. However, the kernel doesn't null-terminate them. A bunch of copy-pasted code uses strncpy to write them, and doesn't guarantee null-termination. For at least 4 drivers (mpr, mps, ciss, and hyperv), the hba_vid field actually overflows. You can see the result by doing "camcontrol negotiate da0 -v". This change null-terminates those fields everywhere they're set in the kernel. It also shortens a few strings to ensure they'll fit within the 16-character field. PR: 215474 Reported by: Coverity CID: 1009997 1010000 1010001 1010002 1010003 1010004 1010005 CID: 1331519 1010006 1215097 1010007 1288967 1010008 1306000 CID: 1211924 1010009 1010010 1010011 1010012 1010013 1010014 CID: 1147190 1010017 1010016 1010018 1216435 1010020 1010021 CID: 1010022 1009666 1018185 1010023 1010025 1010026 1010027 CID: 1010028 1010029 1010030 1010031 1010033 1018186 1018187 CID: 1010035 1010036 1010042 1010041 1010040 1010039 Reviewed by: imp, sephe, slm MFC after: 4 weeks Sponsored by: Spectra Logic Corp Differential Revision: https://reviews.freebsd.org/D9037 Differential Revision: https://reviews.freebsd.org/D9038 2016-05-17T12:52:31Z Eitan Adler eadler@FreeBSD.org 2016-05-17T12:52:31Z urn:sha1:cef367e6a15b6e3e2aca88d453c74962cf1f94e7 (one manual change to fix grammar) Confirmed With: db Approved by: secteam (not really, but this is a comment typo fix)