FreeBSD source tree https://cgit-dev.freebsd.org/src/atom?h=releng%2F12.2 2019-09-02T00:31:03Z 2019-09-02T00:31:03Z Ed Maste emaste@FreeBSD.org 2019-09-02T00:31:03Z urn:sha1:f8166d71435927f081208eaabf3b4d398d4f16f5 Reported by: Dr Silvio Cesare of InfoSect Sponsored by: The FreeBSD Foundation 2018-05-18T20:13:34Z Matt Macy mmacy@FreeBSD.org 2018-05-18T20:13:34Z urn:sha1:d7c5a620e2b99e914f1770abde956cf0d0a970b7 Run on LLNW canaries and tested by pho@ gallatin: Using a 14-core, 28-HTT single socket E5-2697 v3 with a 40GbE MLX5 based ConnectX 4-LX NIC, I see an almost 12% improvement in received packet rate, and a larger improvement in bytes delivered all the way to userspace. When the host receiving 64 streams of netperf -H $DUT -t UDP_STREAM -- -m 1, I see, using nstat -I mce0 1 before the patch: InMpps OMpps InGbs OGbs err TCP Est %CPU syscalls csw irq GBfree 4.98 0.00 4.42 0.00 4235592 33 83.80 4720653 2149771 1235 247.32 4.73 0.00 4.20 0.00 4025260 33 82.99 4724900 2139833 1204 247.32 4.72 0.00 4.20 0.00 4035252 33 82.14 4719162 2132023 1264 247.32 4.71 0.00 4.21 0.00 4073206 33 83.68 4744973 2123317 1347 247.32 4.72 0.00 4.21 0.00 4061118 33 80.82 4713615 2188091 1490 247.32 4.72 0.00 4.21 0.00 4051675 33 85.29 4727399 2109011 1205 247.32 4.73 0.00 4.21 0.00 4039056 33 84.65 4724735 2102603 1053 247.32 After the patch InMpps OMpps InGbs OGbs err TCP Est %CPU syscalls csw irq GBfree 5.43 0.00 4.20 0.00 3313143 33 84.96 5434214 1900162 2656 245.51 5.43 0.00 4.20 0.00 3308527 33 85.24 5439695 1809382 2521 245.51 5.42 0.00 4.19 0.00 3316778 33 87.54 5416028 1805835 2256 245.51 5.42 0.00 4.19 0.00 3317673 33 90.44 5426044 1763056 2332 245.51 5.42 0.00 4.19 0.00 3314839 33 88.11 5435732 1792218 2499 245.52 5.44 0.00 4.19 0.00 3293228 33 91.84 5426301 1668597 2121 245.52 Similarly, netperf reports 230Mb/s before the patch, and 270Mb/s after the patch Reviewed by: gallatin Sponsored by: Limelight Networks Differential Revision: https://reviews.freebsd.org/D15366 2018-04-25T17:51:17Z David C Somayajulu davidcs@FreeBSD.org 2018-04-25T17:51:17Z urn:sha1:b9a4945e17cb6773ffd3b554c3dac301501cca6d MFC after:5 days 2018-03-29T17:36:34Z David C Somayajulu davidcs@FreeBSD.org 2018-03-29T17:36:34Z urn:sha1:971e53c9378a7041ecf7cbfb0ced29b05376a4a1 2. Break transmit when IFF_DRV_RUNNING is OFF. 3. set desc_count=0 for default case in switch in ql_rcv_isr() MFC after:5 days 2018-02-23T03:36:24Z David C Somayajulu davidcs@FreeBSD.org 2018-02-23T03:36:24Z urn:sha1:b65c0c07b2e045bc9df5de2ded05cb9351caf372 2. Sysctls to enable/disable driver_state_dump and error_recovery. 3. Sysctl to control the delay between hw/fw reinitialization and restarting the fastpath. 4. Stop periodic stats retrieval if interface has IFF_DRV_RUNNING flag off. 5. Print contents of PEG_HALT_STATUS1 and PEG_HALT_STATUS2 on heartbeat failure. 6. Speed up slowpath shutdown during error recovery. 7. link_state update using atomic_store. 8. Added timestamp information on driver state and minidump captures. 9. Added support for Slowpath event logging 10.Added additional failure injection types to simulate failures. 2017-11-27T14:52:40Z Pedro F. Giffuni pfg@FreeBSD.org 2017-11-27T14:52:40Z urn:sha1:718cf2ccb9956613756ab15d7a0e28f2c8e91cab Mainly focus on files that use BSD 2-Clause license, however the tool I was using misidentified many licenses so this was mostly a manual - error prone - task. The Software Package Data Exchange (SPDX) group provides a specification to make it easier for automated tools to detect and summarize well known opensource licenses. We are gradually adopting the specification, noting that the tags are considered only advisory and do not, in any way, superceed or replace the license texts. 2017-10-18T19:28:28Z Ryan Libby rlibby@FreeBSD.org 2017-10-18T19:28:28Z urn:sha1:dd00a8cd290a4189c3e0cf4aad5100e6b4ec66f7 QL_ALIGN is a set of copies of roundup2, but it was missing an outer set of parentheses, which began to matter with r324538. Now, fully copy the parenthesization of roundup2. Reviewed by: davidcs Differential Revision: https://reviews.freebsd.org/D12673 2017-10-11T20:22:01Z David C Somayajulu davidcs@FreeBSD.org 2017-10-11T20:22:01Z urn:sha1:ab142b3f492cfa96b77b48a8b51442d9c95c8c4f MFC after:5 days 2017-10-11T18:25:05Z David C Somayajulu davidcs@FreeBSD.org 2017-10-11T18:25:05Z urn:sha1:c6acf96aac649c34f9455db5eef042522ae19745 in Tx Ring map to empty slot in Tx_buf array before Transmits. If the checks fail further Transmission on that Tx Ring is prevented. MFC after:5 days 2017-10-10T20:45:45Z David C Somayajulu davidcs@FreeBSD.org 2017-10-10T20:45:45Z urn:sha1:143ed053e901b8827101deec8a7342d8b574f7fe Add sanity checks in ql_hw_send() qla_send() to ensure that empty slots in Tx Ring map to empty slot in Tx_buf array before Transmits. If the checks fail further Transmission on that Tx Ring is prevented.