src/sys/dev/re, branch release/5.2.1 FreeBSD source tree https://cgit-dev.freebsd.org/src/atom?h=release%2F5.2.1 2003-11-28T05:28:29Z Sometimes cardbus attachments don't attach, so while we track down 2003-11-28T05:28:29Z Warner Losh imp@FreeBSD.org 2003-11-28T05:28:29Z urn:sha1:347934fa630483db685b288c70a07621cb6f8721 this problem put these lines back in. While they should be unnecessary, they appear to be sometimes necessary. Reviewed in concept: dfr Approved by: re (scottl@) Drop the driver lock around calls to if_input to avoid a LOR when 2003-11-14T19:00:32Z Sam Leffler sam@FreeBSD.org 2003-11-14T19:00:32Z urn:sha1:5120abbfb44aea8edaca3311a60e73429dc71942 the packets are immediately returned for sending (e.g. when bridging or packet forwarding). There are more efficient ways to do this but for now use the least intrusive approach. Reviewed by: imp, rwatson Remove duplicate FBSDID's, move others to their right place. 2003-11-14T17:16:58Z David E. O'Brien obrien@FreeBSD.org 2003-11-14T17:16:58Z urn:sha1:4dc52c32bf0d738474a580a6bcff86f9dc3606f5 Try to create some sort of consistency in how the routings to find the 2003-11-13T20:55:53Z David E. O'Brien obrien@FreeBSD.org 2003-11-13T20:55:53Z urn:sha1:aa8255025ab0924083e32a0a72457566d8d6e7da multicast hash are written. There are still two distinct algorithms used, and there actually isn't any reason each driver should have its own copy of this function as they could all share one copy of it (if it grew an additional argument). Remove explicit cardbus attachments from drivers where this is identical 2003-11-03T09:22:18Z Doug Rabson dfr@FreeBSD.org 2003-11-03T09:22:18Z urn:sha1:0be389f3caaecdef16c6b4168f7c0c13ac05cab0 to the pci attachment. Cardbus is a derived class of pci so all pci drivers are automatically available for matching against cardbus devices. Reviewed by: imp Replace the if_name and if_unit members of struct ifnet with new members 2003-10-31T18:32:15Z Brooks Davis brooks@FreeBSD.org 2003-10-31T18:32:15Z urn:sha1:9bf40ede4a299f315bc4b0ae5329631b8c7dc271 if_xname, if_dname, and if_dunit. if_xname is the name of the interface and if_dname/unit are the driver name and instance. This change paves the way for interface renaming and enhanced pseudo device creation and configuration symantics. Approved By: re (in principle) Reviewed By: njl, imp Tested On: i386, amd64, sparc64 Obtained From: NetBSD (if_xname) Remove the dual-address cycle stuff. DAC is used to allow a bus master 2003-09-20T21:18:27Z Bill Paul wpaul@FreeBSD.org 2003-09-20T21:18:27Z urn:sha1:edd033746c5a0e5a36770d127ee3a360c27c8cde device to access 64-bit addresses from a 32-bit PCI bus. While the RealTek manual says you can set this bit and the chip will perform DAC only if you give it a DMA address with any of the upper 32 bits set, this appears not to be the case. If I turn on the DAC bit, the chip sets the 'system error' bit in the status register when I to do a DMA on my Athlon test box with 32-bit PCI bus (VIA chipset) even though I only have 128MB of physical memory, and thus can never give the chip a 64-bit address. Obviously, I can't just set it and forget it, so until I figure out the right rule for when it's safe/necessary to enable it, keep it turned off. Remove jumbo buffer #defines that I ended up not needing. 2003-09-19T02:35:03Z Bill Paul wpaul@FreeBSD.org 2003-09-19T02:35:03Z urn:sha1:6110675fd6991b44dc3eb1dff4a9e8f79a0a14a0 In re_diag(), there's no need for us to call re_start() ourselves: 2003-09-18T18:32:15Z Bill Paul wpaul@FreeBSD.org 2003-09-18T18:32:15Z urn:sha1:7cae6651cfb933a53329dfc19a653ccaf9ace176 IF_HANDOFF() does it for us behind the scenes. Remove the extra call to re_start() otherwise we try to transmit twice. In re_encap(), fix the code that guards against consuming too many descriptors in the TX ring so that it actually works. With the new 8169S chip, I was able to hit a corner case that drained the free descriptor count all the way to 0. This is not supposed to be possible. Teach the re(4) driver about the CFG2 register, which tells us whether 2003-09-13T23:51:35Z Bill Paul wpaul@FreeBSD.org 2003-09-13T23:51:35Z urn:sha1:c2c6548b3a08607903f853683343053c5fef94cb we're on a 32-bit/64-bit bus or not. Use this to decide if we should set the PCI dual-address cycle enable bit in the C+ command register. (Enabling DAC on a 32-bit bus seems to do bad things.) Also, initialize the C+ command register early in the re_init() routine. The documentation says this register should be configured first.