src/sys/dev/sound/pcm/buffer.h, branch releng/6.4

MFC: [stage: 1/7]

2007-05-13T20:50:31Z

buf_addr should be bus_addr_t rather than u_int32_t.

Partial MFC (buffer.h 1.14, buffer.c 1.30)

2007-02-04T06:17:48Z

Fix huge memory leak within sound buffer (during channel destruction, buffer resizing, etc.) that was here since eon. Free all (unmanaged) allocated buffer through sndbuf_destroy() in case we forgot to call sndbuf_free(). For a managed buffer (mostly hw specific managed buffer), either provide CHANNEL_FREE() method with appropriate return value to invoke semi-automatic sndbuf_free() or simply do it on their own. If everything is failed, sndbuf_destroy() will come to the rescue as a final measure.

Start each of the license/copyright comments with /*-, minor shuffle of lines

2005-01-06T01:43:34Z

Change KASSERT() in feed_vchan16() into an explicit test and call to

2004-01-28T08:02:15Z

panic() so that the buffer overflow just beyond this point is always caught, even when the code is not compiled with INVARIANTS. Change chn_setblocksize() buffer reallocation code to attempt to avoid the feed_vchan16() buffer overflow by attempting to always keep the bufsoft buffer at least as large as the bufhard buffer. Print a diagnositic message Danger! %s bufsoft size increasing from %d to %d after CHANNEL_SETBLOCKSIZE() if our best attempts fail. If feed_vchan16() were to be called by the interrupt handler while locks are dropped in chn_setblocksize() to increase the size bufsoft to match the size of bufhard, the panic() code in feed_vchan16() will be triggered. If the diagnostic message is printed, it is a warning that a panic is possible if the system were to see events in an "unlucky" order. Change the locking code to avoid the need for MTX_RECURSIVE mutexes. Add the MTX_DUPOK option to the channel mutexes and change the locking sequence to always lock the parent channel before its children to avoid the possibility of deadlock. Actually implement locking assertions for the channel mutexes and fix the problems found by the resulting assertion violations. Clean up the locking code in dsp_ioctl(). Allocate the channel buffers using the malloc() M_WAITOK option instead of M_NOWAIT so that buffer allocation won't fail. Drop locks across the malloc() calls. Add/modify KASSERTS() in attempt to detect problems early. Abuse layering by adding a pointer to the snd_dbuf structure that points back to the pcm_channel that owns it. This allows sndbuf_resize() to do proper locking without having to change the its API, which is used by the hardware drivers. Don't dereference a NULL pointer when setting hw.snd.maxautovchans if a hardware driver is not loaded. Noticed by Ryan Sommers . Tested by: Stefan Ehmann Tested by: matk (Mathew Kanner) Tested by: Gordon Bergling

Fix a panic due to holding a lock over calls to uiomove.

2003-11-27T19:51:44Z

Pointed out by: Artur Poplawski Explained by: Don Lewis (truckman) Approved by: tanimura (mentor) Approved by: scottl (re)

update my email address.

2003-09-07T16:28:03Z

Implement a "sndbuf_getbufaddr" function and use it instead of vtophys().

2003-02-20T17:31:12Z

Reviewed by: orion

- Clean up ISA DMA supports.

2003-02-07T14:05:34Z

- Rename all sndbuf_isadma* functions to sndbuf_dma* and move them into sys/dev/sound/isa/sndbuf_dma.c. No response from: sound

* improve error handling

2002-01-26T22:13:24Z

* be more specific in verbose boot messages * allow the feeder subsystem to veto pcm* attaching if there is an error initialising the root feeder * don't free/malloc a new tmpbuf when resizing a snd_dbuf to the same size as it currently is * store the feeder description in the feeder structure instead of mallocing space for it

don't erase info in sndbuf_setup()

2001-05-27T14:39:34Z

set free'd pointers to NULL in sndbuf_free() add a new function