FreeBSD source tree https://cgit-dev.freebsd.org/src/atom?h=releng%2F14.2 2024-10-27T16:32:30Z 2024-10-27T16:32:30Z Christos Margiolis christos@FreeBSD.org 2024-10-25T11:36:59Z urn:sha1:6bfac3b2a335c4fb133f670e7b484ea13072882c No longer used. Sponsored by: The FreeBSD Foundation MFC after: 2 days Reviewed by: dev_submerge.ch Differential Revision: https://reviews.freebsd.org/D47269 (cherry picked from commit 9a6cf27583ffc13bb0a7c5be0704ba0d2f3b834d) 2024-10-27T16:32:30Z Christos Margiolis christos@FreeBSD.org 2024-10-25T11:36:51Z urn:sha1:bf3a355a874abfcf7ab77bff84bc355ef79ef0a6 When adding a new vchan, we are looking for a parent channel which either already has vchans (i.e CHN_F_HAS_VCHAN), or does not, but is also not being used (i.e !CHN_F_BUSY). Since CHN_F_BUSY essentially tells us if the channel is currently being used or not, there is no need to check if the channel's refcount is 0 as well. When removing a vchan, we first check if we have only 1 vchan allocated that is also being used (so we cannot remove it at the moment), and then we check if the vchan is not busy and remove it. Again, checking CHN_F_BUSY is enough. Sponsored by: The FreeBSD Foundation MFC after: 2 days Reviewed by: dev_submerge.ch Differential Revision: https://reviews.freebsd.org/D47268 (cherry picked from commit 43c0b593c2c3b2c07009c031a0e7e8190a45b31a) 2024-10-27T16:32:23Z Christos Margiolis christos@FreeBSD.org 2024-10-24T11:37:23Z urn:sha1:f3449b1a2115ed0f680568b8e0d647b8595f5a92 Before de8c0d15a64fa ("sound: Get rid of snd_clone and use DEVFS_CDEVPRIV(9)"), sound(4) would create one device for each allocated channel. The device names would be chosen from dsp_cdevs[], and created with dsp_unit2name(). Additionally, dsp_cdevs[] was also used to match these devices names, as well as OSSv4 aliases in dsp_clone(). Since sound(4) does not create separate devices for each channel anymore, the meaning and use dsp_cdevs[] has changed. Part of it no longer corresponds to devices at all, but instead is used to create channel names, and another part is used to match only OSSv4 aliases in dsp_clone(). To address this confusion, separate dsp_cdevs[] into a dsp_aliases[] array, and move dsp_unit2name() to pcm/channel.c and rename it to chn_mkname(). While here, get rid of the SND_DEV_DSPHW_* channel types, and simply use the existing PCMDIR_* constants as the channel types. There is no need to duplicate the same meaning twice. Sponsored by: The FreeBSD Foundation MFC after: 2 days Reviewed by: dev_submerge.ch Differential Revision: https://reviews.freebsd.org/D47199 (cherry picked from commit 802c78f5194e4524faa30ea57adbf00f28fc72c6) (cherry picked from commit b1bb6934bb8774dd96be76d88e6824e49b613549) 2024-10-27T16:32:17Z Christos Margiolis christos@FreeBSD.org 2024-10-24T11:37:17Z urn:sha1:26524f063fca6d6ab981e08911078f6e59f00f14 Needed by a follow-up patch, so that channels can be sorted properly. This change does not affect the behavior of any subsystem. While here, change to an enum. Sponsored by: The FreeBSD Foundation MFC after: 2 days Reviewed by: dev_submerge.ch, markj Differential Revision: https://reviews.freebsd.org/D47198 (cherry picked from commit a4111e9dc7225618fa8d2af64d866cf0b0aebd56) 2024-10-27T16:32:16Z Christos Margiolis christos@FreeBSD.org 2024-10-24T11:37:10Z urn:sha1:32a2994b4487d9de5190982fd88cbc6d57414cdb DSP_REGISTERED calls PCM_REGISTERED, and already contains all the checks we are doing. No functional change intended. Sponsored by: The FreeBSD Foundation MFC after: 2 days Reviewed by: dev_submerge.ch, markj Differential Revision: https://reviews.freebsd.org/D47196 (cherry picked from commit bb5e3ac1a7b71480a50fc0c813c916a3d058336c) 2024-10-27T16:32:16Z Christos Margiolis christos@FreeBSD.org 2024-10-24T11:37:01Z urn:sha1:ace5484e48c9c8585cf914963912ee1ebf35327a DSP_REGISTERED first checks if the softc is not null, through PCM_REGISTERED, which in turn calls PCM_ALIVE, whereas PCM_DETACHING accesses the softc flags directly. Sponsored by: The FreeBSD Foundation MFC after: 2 days Reviewed by: dev_submerge.ch, markj, emaste Differential Revision: https://reviews.freebsd.org/D47195 (cherry picked from commit 9693241188aa6882166b091d9006f9d0affeda7e) 2024-10-20T11:21:06Z Christos Margiolis christos@FreeBSD.org 2024-10-18T08:41:55Z urn:sha1:e609dfa98fd349ed868f2d4d16bd1994fc53875f Both conditions are the same, so the second one is unreachable. PR: 229550 Sponsored by: The FreeBSD Foundation MFC after: 2 days Reviewed by: andreast, markj Differential Revision: https://reviews.freebsd.org/D47167 (cherry picked from commit 6f96ef84b359137a51dc1e717887ca7d31ba7bad) 2024-10-20T11:21:06Z Jani Salonen salojan@goto10.co 2024-10-18T08:41:44Z urn:sha1:4f11a5312370ee33784a34213c24974baeb77b0f PR: 228615 MFC after: 2 days Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D47166 (cherry picked from commit d643e82356d46a20a8f3f2f3c42573a6827d568a) 2024-10-20T11:21:06Z Christos Margiolis christos@FreeBSD.org 2024-10-18T08:41:36Z urn:sha1:867b2ee999950ac5ef4c68d1edd9cd57a13519dc No functional change intended. Sponsored by: The FreeBSD Foundation MFC after: 2 days Reviewed by: markj, emaste Differential Revision: https://reviews.freebsd.org/D47152 (cherry picked from commit de009cf68ba68aa5823be3d6afeebb49a15b1251) 2024-10-20T11:21:06Z Christos Margiolis christos@FreeBSD.org 2024-10-18T08:41:23Z urn:sha1:565a9b8f86b203517e4e7210c912970adcf614f0 Sponsored by: The FreeBSD Foundation MFC after: 2 days Reviewed by: dev_submerge.ch, zlei Differential Revision: https://reviews.freebsd.org/D46857 (cherry picked from commit 0ff0a8234f83e6b25e9a2f1b64623baaf723d6dc)