src/sys/dev/speaker, branch releng/12.4

Adjust playinit() definition to avoid clang 15 warning

2022-07-29T18:43:14Z

With clang 15, the following -Werror warning is produced: sys/dev/speaker/spkr.c:182:9: error: a function declaration without a prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes] playinit() ^ void This is because playinit() is declared with a (void) argument list, but defined with an empty argument list. Make the definition match the declaration. MFC after: 3 days (cherry picked from commit 57c46916e145581807333bc06a08e9532721bd8f)

Remove register keyword from sys/ and ANSIfy prototypes

2017-05-17T00:34:34Z

A long long time ago the register keyword told the compiler to store the corresponding variable in a CPU register, but it is not relevant for any compiler used in the FreeBSD world today. ANSIfy related prototypes while here. Reviewed by: cem, jhb Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D10193

sys/dev: use our nitems() macro when it is avaliable through param.h.

2016-04-19T23:37:24Z

No functional change, only trivial cases are done in this sweep, Drivers that can get further enhancements will be done independently. Discussed in: freebsd-current

Do not define bool/true/false if the symbols already exist.

2011-12-12T18:43:24Z

MFC after: 2 weeks Sponsored by: Isilon Systems, LLC

Change the type of uio_resid member of struct uio from int to ssize_t.

2009-06-25T18:46:30Z

Note that this does not actually enable full-range i/o requests for 64 architectures, and is done now to update KBI only. Tested by: pho Reviewed by: jhb, bde (as part of the review of the bigger patch)

Remove unneeded checks of device unit number from speaker(4).

2009-01-25T09:20:59Z

Calls on the cdev can only be made on existing devices. This means we don't have to check the value of dev2unit().

Replace all calls to minor() with dev2unit().

2008-09-27T08:51:18Z

After I removed all the unit2minor()/minor2unit() calls from the kernel yesterday, I realised calling minor() everywhere is quite confusing. Character devices now only have the ability to store a unit number, not a minor number. Remove the confusion by using dev2unit() everywhere. This commit could also be considered as a bug fix. A lot of drivers call minor(), while they should actually be calling dev2unit(). In -CURRENT this isn't a problem, but it turns out we never had any problem reports related to that issue in the past. I suspect not many people connect more than 256 pieces of the same hardware. Reviewed by: kib

Move speaker a lot closer to style(9)

2008-05-15T01:22:48Z

Submitted by: Martin Voros

Make speaker a pseudo device driver instead of attaching to a PnP id.

2008-03-26T21:33:41Z

If somebody cleaned this code up to proper style(9), it could become a great educational starting point for aspiring kernel hackers.

The "free-lance" timer in the i8254 is only used for the speaker

2008-03-26T20:09:21Z

these days, so de-generalize the acquire_timer/release_timer api to just deal with speakers. The new (optional) MD functions are: timer_spkr_acquire() timer_spkr_release() and timer_spkr_setfreq() the last of which configures the timer to generate a tone of a given frequency, in Hz instead of 1/1193182th of seconds. Drop entirely timer2 on pc98, it is not used anywhere at all. Move sysbeep() to kern/tty_cons.c and use the timer_spkr*() if they exist, and do nothing otherwise. Remove prototypes and empty acquire-/release-timer() and sysbeep() functions from the non-beeping archs. This eliminate the need for the speaker driver to know about i8254frequency at all. In theory this makes the speaker driver MI, contingent on the timer_spkr_*() functions existing but the driver does not know this yet and still attaches to the ISA bus. Syscons is more tricky, in one function, sc_tone(), it knows the hz and things are just fine. In the other function, sc_bell() it seems to get the period from the KDMKTONE ioctl in terms if 1/1193182th second, so we hardcode the 1193182 and leave it at that. It's probably not important. Change a few other sysbeep() uses which obviously knew that the argument was in terms of i8254 frequency, and leave alone those that look like people thought sysbeep() took frequency in hertz. This eliminates the knowledge of i8254_freq from all but the actual clock.c code and the prof_machdep.c on amd64 and i386, where I think it would be smart to ask for help from the timecounters anyway [TBD].